Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vSphere tests optional #13963

Merged

Conversation

jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Dec 1, 2020

The operator is not installed yet, so vSphere tests should should not block merges.

The operator is not installed yet, so vSphere tests should should not block
merges.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2020
@tsmetana
Copy link
Member

tsmetana commented Dec 1, 2020

/lgtm
(we will revert once the operator is being installed)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@jsafrane
Copy link
Contributor Author

jsafrane commented Dec 1, 2020

Opened https://bugzilla.redhat.com/show_bug.cgi?id=1903107 to enable it later.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0a89f6c into openshift:master Dec 1, 2020
@openshift-ci-robot
Copy link
Contributor

@jsafrane: Updated the following 2 configmaps:

  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-vsphere-problem-detector-master-presubmits.yaml using file ci-operator/jobs/openshift/vsphere-problem-detector/openshift-vsphere-problem-detector-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-vsphere-problem-detector-master-presubmits.yaml using file ci-operator/jobs/openshift/vsphere-problem-detector/openshift-vsphere-problem-detector-master-presubmits.yaml

In response to this:

The operator is not installed yet, so vSphere tests should should not block merges.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
4 participants