Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSI step registry workflow for OpenStack #14243

Merged
merged 1 commit into from Jun 15, 2021
Merged

Add CSI step registry workflow for OpenStack #14243

merged 1 commit into from Jun 15, 2021

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Dec 10, 2020 •
edited

This patch registers a new step registry workflow for running CSI tests.

@Fedosin
Copy link
Contributor Author

Fedosin commented Dec 10, 2020

/test pj-rehearse

8 similar comments
@Fedosin
Copy link
Contributor Author

Fedosin commented Dec 11, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Dec 14, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Dec 16, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Dec 16, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Dec 21, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Dec 21, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Dec 21, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Dec 21, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Dec 22, 2020

/retest

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 2, 2021

/test pj-rehearse

1 similar comment
@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 3, 2021

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 7, 2021

Blocked by #14516

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 7, 2021

/test pj-rehearse

1 similar comment
@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 8, 2021

/test pj-rehearse

@openshift-merge-robot
Copy link
Contributor

@Fedosin: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/openstack-cinder-csi-driver-operator/master/e2e-openstack-csi e22384c30e53a70be76d016c5aa140684cf0ecc4 link /test pj-rehearse
ci/prow/pj-rehearse 26123b6315762cc41297480528e558155c1f8a06 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 20, 2021

/test pj-rehearse

3 similar comments
@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 22, 2021

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Jan 26, 2021

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Feb 4, 2021

/test pj-rehearse

@mandre
Copy link
Member

mandre commented Feb 17, 2021

@Fedosin this PR needs a rebase.

@Fedosin Fedosin changed the title Add Cinder CSI Driver e2e job to the operator Add CSI step registry workflow for OpenStack Mar 15, 2021
@Fedosin
Copy link
Contributor Author

Fedosin commented Mar 15, 2021

/test ci-operator-config

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fedosin
To complete the pull request process, please assign jsafrane after the PR has been reviewed.
You can assign the PR to them by writing /assign @jsafrane in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Fedosin
Copy link
Contributor Author

Fedosin commented Apr 9, 2021

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented May 20, 2021

/test pj-rehearse

@Fedosin Fedosin mentioned this pull request May 20, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 20, 2021 •
edited

@Fedosin: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/openstack-cinder-csi-driver-operator/master/e2e-openstack-csi 26123b6315762cc41297480528e558155c1f8a06 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Fedosin
Copy link
Contributor Author

Fedosin commented Jun 1, 2021

/test pj-rehearse

pierreprinetti
pierreprinetti reviewed Jun 8, 2021
View reviewed changes
...tep-registry/storage/conf/csi-openstack-cinder/storage-conf-csi-openstack-cinder-commands.sh

# For debugging
echo "Using ${SHARED_DIR}/${TEST_CSI_DRIVER_MANIFEST}:"
cat ${SHARED_DIR}/${TEST_CSI_DRIVER_MANIFEST}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this contain any secrets?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like no. This is the manifest file:
https://github.com/openshift/openstack-cinder-csi-driver-operator/blob/master/test/e2e/manifest.yaml

@pierreprinetti
Copy link
Member

Looks good! I just have a question around the debug-printf

mandre
mandre reviewed Jun 8, 2021
View reviewed changes
Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2021
@pierreprinetti
Copy link
Member

/assign jsafrane

@jsafrane
Copy link
Contributor

/approve
The changes look good, however, I don't see workflow openshift-e2e-openstack-csi used anywhere, I expect a subsequent PR that actually uses it...

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, jsafrane, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2021
@mandre
Copy link
Member

mandre commented Jun 14, 2021

The changes look good, however, I don't see workflow openshift-e2e-openstack-csi used anywhere, I expect a subsequent PR that actually uses it...

Correct, we forgot to mention nothing currently calls the workflow, sorry for the confusion. This is being worked on and expect a follow up PR soon.

@Fedosin
Copy link
Contributor Author

Fedosin commented Jun 15, 2021

/retest

@openshift-merge-robot openshift-merge-robot merged commit 96134cd into openshift:master Jun 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@Fedosin: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openstack-cinder-csi-driver-operator-master.yaml using file ci-operator/config/openshift/openstack-cinder-csi-driver-operator/openshift-openstack-cinder-csi-driver-operator-master.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/openstack/csi/OWNERS
    • key openshift-e2e-openstack-csi-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/openstack/csi/openshift-e2e-openstack-csi-workflow.metadata.json
    • key openshift-e2e-openstack-csi-workflow.yaml using file ci-operator/step-registry/openshift/e2e/openstack/csi/openshift-e2e-openstack-csi-workflow.yaml
    • key OWNERS using file ci-operator/step-registry/storage/conf/csi-openstack-cinder/OWNERS
    • key storage-conf-csi-openstack-cinder-commands.sh using file ci-operator/step-registry/storage/conf/csi-openstack-cinder/storage-conf-csi-openstack-cinder-commands.sh
    • key storage-conf-csi-openstack-cinder-ref.metadata.json using file ci-operator/step-registry/storage/conf/csi-openstack-cinder/storage-conf-csi-openstack-cinder-ref.metadata.json
    • key storage-conf-csi-openstack-cinder-ref.yaml using file ci-operator/step-registry/storage/conf/csi-openstack-cinder/storage-conf-csi-openstack-cinder-ref.yaml

In response to this:

This patch registers a new step registry workflow for running CSI tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre left review comments

@pierreprinetti pierreprinetti pierreprinetti left review comments

@huffmanca huffmanca Awaiting requested review from huffmanca

@iamemilio iamemilio Awaiting requested review from iamemilio

Assignees

@mandre mandre

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
6 participants
@Fedosin @openshift-merge-robot @mandre @openshift-ci-robot @pierreprinetti @jsafrane