[CVP-1588] Set default baseDomain variable inside for ipi stage in step-registry

[samvarankashyap]

$subject,
These changes help up overriding the baseDomain variable inside the config template of ipi stage.

[samvarankashyap]

@dirgim PTAL

[dirgim]

Maybe changing this to something like A fully-qualified domain or subdomain name. The base domain of the cloud provider is used for setting baseDomain variable of the install configuration of the cluster.

[samvarankashyap]

Done

[dirgim]

/cc @petr-muller @stevekuznetsov

[wking]

/retitle [CVP-1588] Set default baseDomain variable inside for ipi stage in step-registry

[wking]

Looks reasonable to me, but I'd like to see at least a few green rehearsals.

[wking]

Has some green now.

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samvarankashyap, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ci-operator/step-registry/ipi/OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@samvarankashyap: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/installer/master/e2e-aws-proxy	b5d5eb1	link	/test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/master/e2e-ovn-step-registry	b5d5eb1	link	/test pj-rehearse
ci/rehearse/openshift/cluster-logging-operator/master/e2e-operator	b5d5eb1	link	/test pj-rehearse
ci/rehearse/openshift/aws-ebs-csi-driver/master/e2e-aws-csi	b5d5eb1	link	/test pj-rehearse
ci/rehearse/openshift/cluster-samples-operator/master/e2e-aws-jenkins	b5d5eb1	link	/test pj-rehearse
ci/rehearse/openshift/oc/release-4.2/e2e-cmd	b5d5eb1	link	/test pj-rehearse
ci/rehearse/openshift/cluster-etcd-operator/master/e2e-agnostic	b5d5eb1	link	/test pj-rehearse
ci/rehearse/cri-o/cri-o/master/e2e-agnostic	b5d5eb1	link	/test pj-rehearse
ci/prow/pj-rehearse	b5d5eb1	link	/test pj-rehearse
ci/rehearse/openshift/insights-operator/release-4.2/insights-operator-e2e-tests	b5d5eb1	link	/test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@samvarankashyap: Updated the following 2 configmaps:

• step-registry configmap in namespace ci at cluster api.ci using the following files:
  • key ipi-conf-aws-commands.sh using file ci-operator/step-registry/ipi/conf/aws/ipi-conf-aws-commands.sh
  • key ipi-conf-aws-ref.yaml using file ci-operator/step-registry/ipi/conf/aws/ipi-conf-aws-ref.yaml
• step-registry configmap in namespace ci at cluster app.ci using the following files:
  • key ipi-conf-aws-commands.sh using file ci-operator/step-registry/ipi/conf/aws/ipi-conf-aws-commands.sh
  • key ipi-conf-aws-ref.yaml using file ci-operator/step-registry/ipi/conf/aws/ipi-conf-aws-ref.yaml

In response to this:

$subject,
These changes help up overriding the baseDomain variable inside the config template of ipi stage.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.