Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1920445: gcp-ovn-upgrade doesn't run ovn #15254

Merged
merged 1 commit into from Jan 27, 2021
Merged

Bug 1920445: gcp-ovn-upgrade doesn't run ovn #15254

merged 1 commit into from Jan 27, 2021

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Jan 26, 2021

Creates a new step workflow for ovn-upgrades.

/cc @dcbw

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jan 26, 2021
@openshift-ci-robot
Copy link
Contributor

@squeed: This pull request references Bugzilla bug 1920445, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1920445: gcp-ovn-upgrade doesn't run ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 26, 2021
@squeed squeed mentioned this pull request Jan 26, 2021
Closed
@squeed
Copy link
Contributor Author

squeed commented Jan 26, 2021

/cc @danielmellado

alexanderConstantinescu
alexanderConstantinescu reviewed Jan 26, 2021
View reviewed changes
...tor/step-registry/openshift/upgrade/gcp/ovn/openshift-upgrade-gcp-ovn-workflow.metadata.json Outdated
"squeed"
],
"reviewers": [
"alexanderconstantinescu",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/alexanderconstantinescu/alexanderConstantinescu/g

also

s/jacobtanenbaum/JacobTanenbaum/g

here and in OWNERS

though given how little I know about CI orchestration / configuration, I am not sure I should be a reviewer...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teams are responsible for maintaining their own CI bits, so yes, everyone should be here.

This is a pretty old list though. It should be synced to https://github.com/openshift/ovn-kubernetes/blob/master/OWNERS

@danielmellado
Copy link
Contributor

/lgtm , besides alex's nit name changes. It seems that this might also need some cleanup due to some duplicated names on the ci-operator-registry.

@squeed
Copy link
Contributor Author

squeed commented Jan 26, 2021

yeah, looking in to the duplicate issues

danwinship
danwinship reviewed Jan 26, 2021
View reviewed changes
...openshift/cluster-network-operator/openshift-cluster-network-operator-master-presubmits.yaml Show resolved Hide resolved
...hift/cluster-network-operator/openshift-cluster-network-operator-release-4.8-presubmits.yaml Show resolved Hide resolved
...tor/step-registry/openshift/upgrade/gcp/ovn/openshift-upgrade-gcp-ovn-workflow.metadata.json Outdated
"squeed"
],
"reviewers": [
"alexanderconstantinescu",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teams are responsible for maintaining their own CI bits, so yes, everyone should be here.

This is a pretty old list though. It should be synced to https://github.com/openshift/ovn-kubernetes/blob/master/OWNERS

ci-operator/step-registry/openshift/upgrade/gcp/ovn/openshift-upgrade-gcp-ovn-workflow.yaml Outdated Show resolved Hide resolved
@squeed
Copy link
Contributor Author

squeed commented Jan 26, 2021

okay, updated.

@danwinship all the jobs are consistent from 4.7 onwards: always_run: true, optional: true.

OWNERS is same as downstream ovn-k

@openshift-ci-robot openshift-ci-robot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. and removed do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jan 26, 2021
@dcbw
Copy link
Contributor

dcbw commented Jan 26, 2021

/retest

@squeed
Copy link
Contributor Author

squeed commented Jan 27, 2021

all green but we got a conflict. bah.

@squeed
Copy link
Contributor Author

squeed commented Jan 27, 2021

OK, rebased.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2021

@squeed: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-network-operator/master/e2e-gcp-ovn-upgrade fff1009 link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/release-4.7/e2e-gcp-ovn-upgrade fff1009 link /test pj-rehearse
ci/prow/pj-rehearse fff1009 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@squeed
Copy link
Contributor Author

squeed commented Jan 27, 2021

rehearse failures seem irrelevant
this needs to go in ASAP as it blocks 4.7

@squeed
Copy link
Contributor Author

squeed commented Jan 27, 2021

/retest

@squeed
Copy link
Contributor Author

squeed commented Jan 27, 2021

(also, note that release-4.8 e2e-gcp-ovn-upgrade succeeded, so it's clearly working)

@dcbw
Copy link
Contributor

dcbw commented Jan 27, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2021
vrutkovs
vrutkovs approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, dcbw, squeed, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2021
@openshift-merge-robot openshift-merge-robot merged commit 5ea1b32 into openshift:master Jan 27, 2021
@openshift-ci-robot
Copy link
Contributor

@squeed: All pull requests linked via external trackers have merged:

Bugzilla bug 1920445 has been moved to the MODIFIED state.

In response to this:

Bug 1920445: gcp-ovn-upgrade doesn't run ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@squeed: Updated the following 11 configmaps:

  • job-config-4.8 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cluster-network-operator-release-4.8-periodics.yaml using file ``
    • key openshift-cluster-network-operator-release-4.8-presubmits.yaml using file ci-operator/jobs/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.8-presubmits.yaml
  • ci-operator-4.8-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-network-operator-release-4.8.yaml using file ci-operator/config/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.8.yaml
  • job-config-4.7 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cluster-network-operator-release-4.7-periodics.yaml using file ``
    • key openshift-cluster-network-operator-release-4.7-presubmits.yaml using file ci-operator/jobs/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.7-presubmits.yaml
  • job-config-4.7 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-network-operator-release-4.7-periodics.yaml using file ``
    • key openshift-cluster-network-operator-release-4.7-presubmits.yaml using file ci-operator/jobs/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.7-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-network-operator-master-periodics.yaml using file ``
    • key openshift-cluster-network-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-network-operator/openshift-cluster-network-operator-master-presubmits.yaml
  • job-config-4.8 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-network-operator-release-4.8-periodics.yaml using file ``
    • key openshift-cluster-network-operator-release-4.8-presubmits.yaml using file ci-operator/jobs/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.8-presubmits.yaml
  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/openshift/upgrade/gcp/ovn/OWNERS
    • key openshift-upgrade-gcp-ovn-workflow.metadata.json using file ci-operator/step-registry/openshift/upgrade/gcp/ovn/openshift-upgrade-gcp-ovn-workflow.metadata.json
    • key openshift-upgrade-gcp-ovn-workflow.yaml using file ci-operator/step-registry/openshift/upgrade/gcp/ovn/openshift-upgrade-gcp-ovn-workflow.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/openshift/upgrade/gcp/ovn/OWNERS
    • key openshift-upgrade-gcp-ovn-workflow.metadata.json using file ci-operator/step-registry/openshift/upgrade/gcp/ovn/openshift-upgrade-gcp-ovn-workflow.metadata.json
    • key openshift-upgrade-gcp-ovn-workflow.yaml using file ci-operator/step-registry/openshift/upgrade/gcp/ovn/openshift-upgrade-gcp-ovn-workflow.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-network-operator-master.yaml using file ci-operator/config/openshift/cluster-network-operator/openshift-cluster-network-operator-master.yaml
  • ci-operator-4.7-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-network-operator-release-4.7.yaml using file ci-operator/config/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.7.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cluster-network-operator-master-periodics.yaml using file ``
    • key openshift-cluster-network-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-network-operator/openshift-cluster-network-operator-master-presubmits.yaml

In response to this:

Creates a new step workflow for ovn-upgrades.

/cc @dcbw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jluhrsen jluhrsen mentioned this pull request Mar 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship left review comments

@danielmellado danielmellado danielmellado left review comments

@alexanderConstantinescu alexanderConstantinescu alexanderConstantinescu left review comments

@vrutkovs vrutkovs vrutkovs approved these changes

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@vrutkovs vrutkovs

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
8 participants
@squeed @openshift-ci-robot @danielmellado @dcbw @danwinship @vrutkovs @alexanderConstantinescu @openshift-merge-robot