Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - single node serial workflow #16290

Closed
wants to merge 1 commit into from

Conversation

omertuc
Copy link
Contributor

@omertuc omertuc commented Feb 25, 2021

(Previously was called WIP - single node serial and upgrade workflows but upgrade flow was moved to this PR)

Please ignore this for now.

(This change isn't really currently specific to the MCO, I just chose MCO arbitrarily because it had an existing openshift-e2e-aws-serial job I wanted to copy)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2021
@omertuc
Copy link
Contributor Author

omertuc commented Mar 1, 2021

/test pj-rehearse

4 similar comments
@omertuc
Copy link
Contributor Author

omertuc commented Mar 1, 2021

/test pj-rehearse

@omertuc
Copy link
Contributor Author

omertuc commented Mar 1, 2021

/test pj-rehearse

@omertuc
Copy link
Contributor Author

omertuc commented Mar 1, 2021

/test pj-rehearse

@omertuc
Copy link
Contributor Author

omertuc commented Mar 1, 2021

/test pj-rehearse

@omertuc omertuc force-pushed the sno-serial-upgrade branch 2 times, most recently from 24a1909 to 52aa919 Compare April 6, 2021 08:42
@vrutkovs
Copy link
Member

vrutkovs commented Apr 7, 2021

Reference: https://issues.redhat.com/browse/OTA-379

@vrutkovs vrutkovs mentioned this pull request Apr 7, 2021
2 tasks
@omertuc omertuc changed the title WIP - single node serial and upgrade workflows WIP - single node serial workflow Apr 7, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omertuc
To complete the pull request process, please assign yuqi-zhang after the PR has been reviewed.
You can assign the PR to them by writing /assign @yuqi-zhang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ingvagabund
Copy link
Member

@omertuc can you please rebase the PR to get the latest failing tests?

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2021
@ingvagabund
Copy link
Member

ingvagabund commented Apr 19, 2021

[BeforeEach] PodTopologySpread Filtering
  k8s.io/kubernetes@v1.20.0/test/e2e/scheduling/predicates.go:788
STEP: Trying to get 2 available nodes which can run pod

ci/rehearse/openshift/machine-config-operator/master/e2e-aws-single-node-serial is running tests from openshift-4.7 branch, not the master branch.

The BeforeEach in the master branch is expected to be reported at line 720.

@omertuc
Copy link
Contributor Author

omertuc commented Apr 19, 2021

[BeforeEach] PodTopologySpread Filtering
  k8s.io/kubernetes@v1.20.0/test/e2e/scheduling/predicates.go:788
STEP: Trying to get 2 available nodes which can run pod

ci/rehearse/openshift/machine-config-operator/master/e2e-aws-single-node-serial is running tests from openshift-4.7 branch, not the master branch.

The BeforeEach in the master branch is expected to be reported at line 720.

Odd, I'll look into it. Nice catch.

EDIT: Not sure what's causing this, I'm not doing anything special other than changing the TEST_SUITE. Tried rebasing again.

@omertuc
Copy link
Contributor Author

omertuc commented Apr 19, 2021

/retest

since openshift/cluster-monitoring-operator#1122 was merged

@openshift-ci-robot
Copy link
Contributor

@omertuc: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test ci-secret-bootstrap-config-validation
  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build01-dry
  • /test build02-dry
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-generator-config
  • /test ci-testgrid-allow-list
  • /test config
  • /test core-dry
  • /test core-valid
  • /test correctly-sharded-config
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test ordered-prow-config
  • /test owners
  • /test pj-rehearse
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test vsphere-dry
  • /test pylint
  • /test yamllint

Use /test all to run the following jobs:

  • pull-ci-openshift-release-ci-secret-bootstrap-config-validation
  • pull-ci-openshift-release-master-app-ci-config-dry
  • pull-ci-openshift-release-master-boskos-config
  • pull-ci-openshift-release-master-boskos-config-generation
  • pull-ci-openshift-release-master-build01-dry
  • pull-ci-openshift-release-master-build02-dry
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-config-metadata
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-ci-secret-generator-config
  • pull-ci-openshift-release-master-config
  • pull-ci-openshift-release-master-core-dry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-generated-config
  • pull-ci-openshift-release-master-generated-dashboards
  • pull-ci-openshift-release-master-ordered-prow-config
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-pj-rehearse
  • pull-ci-openshift-release-master-prow-config
  • pull-ci-openshift-release-master-prow-config-filenames
  • pull-ci-openshift-release-master-prow-config-semantics
  • pull-ci-openshift-release-master-release-config
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-master-secret-generator-config-valid
  • pull-ci-openshift-release-master-services-valid
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-master-vsphere-dry
  • pull-ci-openshift-release-yamllint

In response to this:

/retest since openshift/cluster-monitoring-operator#1122 was merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@omertuc
Copy link
Contributor Author

omertuc commented Apr 19, 2021

/retest

@ingvagabund
Copy link
Member

openshift/origin#26054 needs to merge first

@ingvagabund
Copy link
Member

ingvagabund commented May 12, 2021

@omertuc https://bugzilla.redhat.com/show_bug.cgi?id=1934085#c8 for the sig-scheduling tests. Some are still failing but the underlying reason is different. image-registry needs to create only a single instance of the pod instead of two. The issue is tracked in https://issues.redhat.com/browse/IR-181.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2021
@ingvagabund
Copy link
Member

@omertuc can you rebase the PR? To see the latest failing tests (if any)?

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2021
@omertuc
Copy link
Contributor Author

omertuc commented Jun 30, 2021

/retest

1 similar comment
@omertuc
Copy link
Contributor Author

omertuc commented Jun 30, 2021

/retest

@omertuc
Copy link
Contributor Author

omertuc commented Jun 30, 2021

@omertuc
Copy link
Contributor Author

omertuc commented Jun 30, 2021

/retest

secretName: result-aggregator
trigger: (?m)^/test( | .* )e2e-aws-single-node-serial,?($|\s.*)
- agent: kubernetes
always_run: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you change the contents of the next test to always_run:true?

can you clean this up so that you add your stuff with a completely new entry beginning with a new -agent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just bad rebase, didn't mean to. Should be better now

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 30, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omertuc
To complete the pull request process, please ask for approval from kikisdeliveryservice after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Jun 30, 2021

looks good, @omertuc

a little confused, do you want this e2e in this repo? initial message seems to say it's a test. ping me if/when you want approval & remove WIP. 😄

@omertuc
Copy link
Contributor Author

omertuc commented Jun 30, 2021

looks good, @omertuc

a little confused, do you want this e2e in this repo? initial message seems to say it's a test. ping me if/when you want approval & remove WIP. 😄

It is just a WIP test, just didn't want to leave the ci-operator/jobs file messed up

@romfreiman
Copy link

@omertuc so lets add the serial job to the test grid of sno 4.9?

@omertuc
Copy link
Contributor Author

omertuc commented Jul 1, 2021

@omertuc so lets add the serial job to the test grid of sno 4.9?

@romfreiman
kubernetes/test-infra#22757
#19878

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2021

@omertuc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-upgrade-single-node 52aa919e11ff12cfde1e287e096828b39103df84 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-upgrade 2d654f74d8752a449daa860a928a5038e756cb84 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-single-node-serial 28371e7 link /test pj-rehearse
ci/prow/pj-rehearse 28371e7 link /test pj-rehearse
ci/build-farm/build04-dry 28371e7 link true /test build04-dry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2021

@omertuc: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2021
@omertuc
Copy link
Contributor Author

omertuc commented Nov 24, 2021

Obsoleted by #19878 , closing

@omertuc omertuc closed this Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
6 participants