-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - single node serial workflow #16290
Conversation
4163c4b
to
ce913b7
Compare
/test pj-rehearse |
4 similar comments
/test pj-rehearse |
/test pj-rehearse |
/test pj-rehearse |
/test pj-rehearse |
24a1909
to
52aa919
Compare
...p-registry/openshift/upgrade/aws/single-node/openshift-upgrade-aws-single-node-workflow.yaml
Outdated
Show resolved
Hide resolved
Reference: https://issues.redhat.com/browse/OTA-379 |
52aa919
to
2c1e10d
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omertuc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@omertuc can you please rebase the PR to get the latest failing tests? |
2c1e10d
to
1fbac2a
Compare
The |
Odd, I'll look into it. Nice catch. EDIT: Not sure what's causing this, I'm not doing anything special other than changing the TEST_SUITE. Tried rebasing again. |
1fbac2a
to
bb6d1dd
Compare
/retest since openshift/cluster-monitoring-operator#1122 was merged |
@omertuc: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
openshift/origin#26054 needs to merge first |
@omertuc https://bugzilla.redhat.com/show_bug.cgi?id=1934085#c8 for the sig-scheduling tests. Some are still failing but the underlying reason is different. |
@omertuc can you rebase the PR? To see the latest failing tests (if any)? |
bb6d1dd
to
2d654f7
Compare
/retest |
1 similar comment
/retest |
|
/retest |
secretName: result-aggregator | ||
trigger: (?m)^/test( | .* )e2e-aws-single-node-serial,?($|\s.*) | ||
- agent: kubernetes | ||
always_run: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you change the contents of the next test to always_run:true?
can you clean this up so that you add your stuff with a completely new entry beginning with a new -agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just bad rebase, didn't mean to. Should be better now
2d654f7
to
28371e7
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omertuc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
looks good, @omertuc a little confused, do you want this e2e in this repo? initial message seems to say it's a test. ping me if/when you want approval & remove WIP. 😄 |
It is just a WIP test, just didn't want to leave the ci-operator/jobs file messed up |
@omertuc so lets add the serial job to the test grid of sno 4.9? |
|
@omertuc: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@omertuc: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Obsoleted by #19878 , closing |
(Previously was called
WIP - single node serial and upgrade workflows
but upgrade flow was moved to this PR)Please ignore this for now.
(This change isn't really currently specific to the MCO, I just chose MCO arbitrarily because it had an existing openshift-e2e-aws-serial job I wanted to copy)