Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-4869 add an assisted operator installation workflow #17425

Merged
merged 1 commit into from
Apr 21, 2021
Merged

MGMT-4869 add an assisted operator installation workflow #17425

merged 1 commit into from
Apr 21, 2021

Conversation

osherdp
Copy link
Contributor

@osherdp osherdp commented Apr 5, 2021

/hold
/cc @osherdp

@openshift-ci-robot
Copy link
Contributor

@osherdp: GitHub didn't allow me to request PR reviews from the following users: osherdp.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/hold
/cc @osherdp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 5, 2021
@openshift-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@osherdp
Copy link
Contributor Author

osherdp commented Apr 5, 2021

/test pj-rehearse

@osherdp
Copy link
Contributor Author

osherdp commented Apr 5, 2021

/test pj-rehearse

@osherdp
Copy link
Contributor Author

osherdp commented Apr 5, 2021

/test pj-rehearse

@osherdp
Copy link
Contributor Author

osherdp commented Apr 5, 2021

/test pj-rehearse

@osherdp
Copy link
Contributor Author

osherdp commented Apr 5, 2021

/test pj-rehearse

@osherdp
Copy link
Contributor Author

osherdp commented Apr 5, 2021

/test pj-rehearse

@osherdp
Copy link
Contributor Author

osherdp commented Apr 5, 2021

/test pj-rehearse

1 similar comment
@osherdp
Copy link
Contributor Author

osherdp commented Apr 5, 2021

/test pj-rehearse

@osherdp
Copy link
Contributor Author

osherdp commented Apr 6, 2021

/test pj-rehearse

1 similar comment
@osherdp
Copy link
Contributor Author

osherdp commented Apr 6, 2021

/test pj-rehearse

@osherdp
Copy link
Contributor Author

osherdp commented Apr 6, 2021

/test pj-rehearse

2 similar comments
@osherdp
Copy link
Contributor Author

osherdp commented Apr 6, 2021

/test pj-rehearse

@osherdp
Copy link
Contributor Author

osherdp commented Apr 7, 2021

/test pj-rehearse

@osherdp
Copy link
Contributor Author

osherdp commented Apr 7, 2021

/test pj-rehearse

@osherdp
Copy link
Contributor Author

osherdp commented Apr 11, 2021

/test pj-rehearse

@osherdp
Copy link
Contributor Author

osherdp commented Apr 19, 2021

/test pj-rehearse

@osherdp
Copy link
Contributor Author

osherdp commented Apr 20, 2021

/test pj-rehearse

@osherdp osherdp marked this pull request as ready for review April 20, 2021 07:21
YuviGold
YuviGold reviewed Apr 20, 2021
View reviewed changes
...step-registry/baremetalds/assisted/operator/lso/baremetalds-assisted-operator-lso-chain.yaml Outdated Show resolved Hide resolved
...ator/step-registry/baremetalds/assisted/operator/baremetalds-assisted-operator-workflow.yaml Outdated Show resolved Hide resolved
...ssisted/operator/lso/create-disks/baremetalds-assisted-operator-lso-create-disks-commands.sh Outdated Show resolved Hide resolved
...s/assisted/operator/lso/create-disks/baremetalds-assisted-operator-lso-create-disks-ref.yaml Outdated Show resolved Hide resolved
...baremetalds/assisted/operator/lso/install/baremetalds-assisted-operator-lso-install-ref.yaml Outdated Show resolved Hide resolved
...ep-registry/baremetalds/assisted/operator/setup/baremetalds-assisted-operator-setup-ref.yaml Outdated Show resolved Hide resolved
...emetalds/assisted/operator/lso/install/baremetalds-assisted-operator-lso-install-commands.sh Show resolved Hide resolved
...registry/baremetalds/assisted/operator/setup/baremetalds-assisted-operator-setup-commands.sh Outdated Show resolved Hide resolved
...registry/baremetalds/assisted/operator/setup/baremetalds-assisted-operator-setup-commands.sh Outdated Show resolved Hide resolved
...registry/baremetalds/assisted/operator/setup/baremetalds-assisted-operator-setup-commands.sh Outdated Show resolved Hide resolved
@osherdp
Copy link
Contributor Author

osherdp commented Apr 20, 2021

/retest

@osherdp osherdp force-pushed the build/assisted-operator branch 2 times, most recently from e811c2f to 85bb7f9 Compare April 20, 2021 15:46
@osherdp osherdp changed the title WIP add an assisted operator installation workflow MGMT-4869 add an assisted operator installation workflow Apr 20, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2021
@osherdp
Copy link
Contributor Author

osherdp commented Apr 20, 2021

/retest

1 similar comment
@osherdp
Copy link
Contributor Author

osherdp commented Apr 20, 2021

/retest

@osherdp osherdp force-pushed the build/assisted-operator branch 3 times, most recently from d526514 to 672f3a1 Compare April 21, 2021 08:17
@YuviGold
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osherdp, YuviGold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@osherdp
Copy link
Contributor Author

osherdp commented Apr 21, 2021

/unhold
before @YuviGold changes him mind :)

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2021
@openshift-merge-robot openshift-merge-robot merged commit 67148f8 into openshift:master Apr 21, 2021
@openshift-ci-robot
Copy link
Contributor

@osherdp: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-assisted-service-master.yaml using file ci-operator/config/openshift/assisted-service/openshift-assisted-service-master.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-assisted-service-master-presubmits.yaml using file ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-master-presubmits.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/baremetalds/assisted/operator/OWNERS
    • key baremetalds-assisted-operator-workflow.metadata.json using file ci-operator/step-registry/baremetalds/assisted/operator/baremetalds-assisted-operator-workflow.metadata.json
    • key baremetalds-assisted-operator-workflow.yaml using file ci-operator/step-registry/baremetalds/assisted/operator/baremetalds-assisted-operator-workflow.yaml
    • key OWNERS using file ci-operator/step-registry/baremetalds/assisted/operator/lso/OWNERS
    • key baremetalds-assisted-operator-lso-chain.metadata.json using file ci-operator/step-registry/baremetalds/assisted/operator/lso/baremetalds-assisted-operator-lso-chain.metadata.json
    • key baremetalds-assisted-operator-lso-chain.yaml using file ci-operator/step-registry/baremetalds/assisted/operator/lso/baremetalds-assisted-operator-lso-chain.yaml
    • key OWNERS using file ci-operator/step-registry/baremetalds/assisted/operator/lso/create-disks/OWNERS
    • key baremetalds-assisted-operator-lso-create-disks-commands.sh using file ci-operator/step-registry/baremetalds/assisted/operator/lso/create-disks/baremetalds-assisted-operator-lso-create-disks-commands.sh
    • key baremetalds-assisted-operator-lso-create-disks-ref.metadata.json using file ci-operator/step-registry/baremetalds/assisted/operator/lso/create-disks/baremetalds-assisted-operator-lso-create-disks-ref.metadata.json
    • key baremetalds-assisted-operator-lso-create-disks-ref.yaml using file ci-operator/step-registry/baremetalds/assisted/operator/lso/create-disks/baremetalds-assisted-operator-lso-create-disks-ref.yaml
    • key OWNERS using file ci-operator/step-registry/baremetalds/assisted/operator/lso/install/OWNERS
    • key baremetalds-assisted-operator-lso-install-commands.sh using file ci-operator/step-registry/baremetalds/assisted/operator/lso/install/baremetalds-assisted-operator-lso-install-commands.sh
    • key baremetalds-assisted-operator-lso-install-ref.metadata.json using file ci-operator/step-registry/baremetalds/assisted/operator/lso/install/baremetalds-assisted-operator-lso-install-ref.metadata.json
    • key baremetalds-assisted-operator-lso-install-ref.yaml using file ci-operator/step-registry/baremetalds/assisted/operator/lso/install/baremetalds-assisted-operator-lso-install-ref.yaml
    • key OWNERS using file ci-operator/step-registry/baremetalds/assisted/operator/setup/OWNERS
    • key baremetalds-assisted-operator-setup-commands.sh using file ci-operator/step-registry/baremetalds/assisted/operator/setup/baremetalds-assisted-operator-setup-commands.sh
    • key baremetalds-assisted-operator-setup-ref.metadata.json using file ci-operator/step-registry/baremetalds/assisted/operator/setup/baremetalds-assisted-operator-setup-ref.metadata.json
    • key baremetalds-assisted-operator-setup-ref.yaml using file ci-operator/step-registry/baremetalds/assisted/operator/setup/baremetalds-assisted-operator-setup-ref.yaml

In response to this:

/hold
/cc @osherdp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lranjbar lranjbar lranjbar left review comments

@YuviGold YuviGold YuviGold left review comments

Assignees

@YuviGold YuviGold

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
5 participants
@osherdp @openshift-ci-robot @YuviGold @lranjbar @openshift-merge-robot