Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openshift-apiserver: add verify-deps job #19983

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

stlaz
Copy link
Member

@stlaz stlaz commented Jul 7, 2021

@openshift-ci openshift-ci bot requested review from soltysh and sttts July 7, 2021 11:23
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021
@stlaz
Copy link
Member Author

stlaz commented Jul 8, 2021

waiting for openshift/openshift-apiserver#226 to merge as that PR should fix the vendor

@atiratree
Copy link
Member

/retest

@sttts
Copy link
Contributor

sttts commented Jul 14, 2021

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, stlaz, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit 2f55cc7 into openshift:master Jul 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

@stlaz: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openshift-apiserver-master.yaml using file ci-operator/config/openshift/openshift-apiserver/openshift-openshift-apiserver-master.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openshift-apiserver-master-presubmits.yaml using file ci-operator/jobs/openshift/openshift-apiserver/openshift-openshift-apiserver-master-presubmits.yaml

In response to this:

/cc @sttts @soltysh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
5 participants