Bug 1990916: ci-operator/step-registry/ipi/install/install: Default OPENSHIFT_INSTALL_PRESERVE_BOOTSTRAP to empty #20978
Conversation
openshift-ci
bot
added
the
bugzilla/severity-unspecified
|
@wking: This pull request references Bugzilla bug 1990916, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/invalid-bug
openshift-ci
bot
added
the
approved
|
@wking: This pull request references Bugzilla bug 1990916, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ALL_PRESERVE_BOOTSTRAP to empty c421970 (Preserve bootstrap node on single-node installations, 2021-07-26, openshift#20592) started setting the environment variable for all calls. It defaulted to 'false', apparently assuming that that meant "keep on deleting the bootstrap resources". But the installer actually treats any non-empty value as "please preserve" [1]. This should avoid situations like [2,3], where the 'false' default lead the installer to say [4,5]: time="2021-08-05T21:44:40Z" level=warning msg="OPENSHIFT_INSTALL_PRESERVE_BOOTSTRAP is set, not destroying bootstrap resources. Warning: this should only be used for debugging purposes, and poses a risk to cluster stability." which broke ingress on [4]: level=error msg=Cluster operator ingress Degraded is True with IngressDegraded: The "default" ingress controller reports Degraded=True: DegradedConditions: One or more other status conditions indicate a degraded state: LoadBalancerReady=False (SyncLoadBalancerFailed: The service-controller component is reporting SyncLoadBalancerFailed events like: Error syncing load balancer: failed to ensure load balancer: EnsureBackendPoolDeleted: failed to parse the VMAS ID : getAvailabilitySetNameByID: failed to parse the VMAS ID which make everything that's ingress-dependent (auth, console, ...) sad. [1]: https://github.com/openshift/installer/blob/6d778f911e79afad8ba2ff4301eda5b5cf4d8e9e/cmd/openshift-install/create.go#L133 [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1949267#c3 [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1990916 [4]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.9-e2e-azure/1423392049742221312 [5]: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.9-e2e-azure/1423392049742221312/artifacts/e2e-azure/ipi-install-install/artifacts/.openshift_install.log
wking
force-pushed
the
unset-preserve-bootstrap-on-false
branch
from
b909290
to
9a5d667
Compare
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/severity-high
|
@wking: This pull request references Bugzilla bug 1990916, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (liyao@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: osherdp, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: All pull requests linked via external trackers have merged: Bugzilla bug 1990916 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking sorry for that |
c421970 (#20592) started setting the environment variable for all calls. It defaulted to
false, apparently assuming that that meant "keep on deleting the bootstrap resources". But the installer actually treats any non-empty value as "please preserve".This should avoid situations like [this]]3, where the
falsedefault lead the installer to say:which broke ingress on:
which make everything that's ingress-dependent (auth, console, ...) sad.