Test custom machine-os-content image in machine-config-operator@mcbs #24225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
|
I think I understand the hack here. Clever! But let's target this against the mcbs branch file where we're focusing this effort. For now we are not trying to land code in |
petr-muller
force-pushed
the
moc-experiment
branch
from
ed9875e
to
610adcd
Compare
|
@petr-muller: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
petr-muller
force-pushed
the
moc-experiment
branch
from
610adcd
to
344333a
Compare
petr-muller
commented
Dec 2, 2021
...perator/config/openshift/machine-config-operator/openshift-machine-config-operator-mcbs.yaml
Show resolved
Hide resolved
1. Import the custom image 2. "build" the machine-os-content from the custom image 3. Such "built" image gets picked up by the `include_built_images: true`-configured `latest` release that gets installed for testing 4. Make sure that `machine-os-content` will not be promoted (presubmits should forbid that but to be safe).
petr-muller
force-pushed
the
moc-experiment
branch
from
344333a
to
c96ce97
Compare
|
/retitle Test custom machine-os-content image in machine-config-operator@mcbs |
openshift-ci
bot
changed the title
|
For clarity, this replaces #24222 |
|
Hmm, I think the override isn't working: Versus: |
|
It looks like you are inspecting the |
|
Ahh, got it. OK indeed, the target image looks right: However, as a side effect of this hack it has a different digested /approve And thanks for doing this! |
^^^ from the config. |
This was referenced Dec 2, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think there is even blacker magic in ci-operator that would help with that ( |
|
@petr-muller: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cgwalters
added a commit
to cgwalters/machine-config-operator
that referenced
this pull request
Dec 6, 2021
This is *mainly* to validate that openshift/release#24225 worked. But, this code may be useful as a sanity check going forward. See also coreos/rpm-ostree#3251 (I also may try to expose e.g. `ex-container` as a feature flag that we can query instead of version-parsing)
cheesesashimi
pushed a commit
to cheesesashimi/machine-config-operator
that referenced
this pull request
Feb 22, 2022
This is *mainly* to validate that openshift/release#24225 worked. But, this code may be useful as a sanity check going forward. See also coreos/rpm-ostree#3251 (I also may try to expose e.g. `ex-container` as a feature flag that we can query instead of version-parsing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @cgwalters