WINC-607: [upi-vsphere] Add support for Windows VM in platform=none workflow #24911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test pj-rehearse |
|
/test pj-rehearse |
|
/cc @openshift/openshift-team-windows-containers |
|
/test pj-rehearse |
|
/test yamllint |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test pj-rehearse |
|
/test pj-rehearse |
jrvaldes
force-pushed
the
winc-607
branch
2 times, most recently
from
4846057
to
34bf45f
Compare
jrvaldes
changed the title
jrvaldes
force-pushed
the
winc-607
branch
3 times, most recently
from
b28f988
to
9035829
Compare
|
/test pj-rehearse |
|
@jrvaldes: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/approve |
|
Held to ensure everyone is okay with this |
|
/lgtm |
From Cluster and OS Pre-Requisites Platform none (BYOH) support starts at 4.8+.
|
I might be mixing releases up. If we are sure that |
|
/lgtm |
|
/assign @patrickdillon |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes, mansikulkarni96, rvanderp3, saifshaikh48, sebsoto, selansen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@jrvaldes: Updated the following 11 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
platform-none-vsphere-e2e-operatortest configuration to include a Windows VM (BYOH use case).Follow-up to #22371