Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINC-607: Require platform=none job in master presubmits #26581

Merged
merged 1 commit into from Mar 1, 2022
Merged

WINC-607: Require platform=none job in master presubmits #26581

merged 1 commit into from Mar 1, 2022

Conversation

jrvaldes
Copy link
Contributor

@jrvaldes jrvaldes commented Feb 25, 2022 •
edited

This PR sets the platform=none job to always run, following the
approach introduced in 19f53ec .

This change targets master, release-4.11 and release-4.12 branches.

@jrvaldes
Copy link
Contributor Author

/hold

Merge after openshift/windows-machine-config-operator#896

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2022
@jrvaldes jrvaldes changed the title wmco: Always run platform=none job in presubmits WINC-607: Always run platform=none job in presubmits Feb 25, 2022
@jrvaldes
wmco: Require platform=none job master presubmits
e0963b9 
This commit sets the platform=none job to always run, following the
approach introduced in 19f53ec

This change targets master, release-4.11 and release-4.12 branches.
@jrvaldes jrvaldes force-pushed the winc-607-platform-none-vsphere-e2e-operator-test-mandatory branch from 87cc7db to e0963b9 Compare February 25, 2022 21:09
@jrvaldes jrvaldes changed the title WINC-607: Always run platform=none job in presubmits WINC-607: Always run platform=none job in master presubmits Feb 25, 2022
@jrvaldes jrvaldes changed the title WINC-607: Always run platform=none job in master presubmits WINC-607: Require platform=none job in master presubmits Feb 25, 2022
@jrvaldes
Copy link
Contributor Author

/hold cancel

openshift/windows-machine-config-operator#896 has merge

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2022
@mansikulkarni96
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2022
@selansen
Copy link

selansen commented Mar 1, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, mansikulkarni96, selansen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2022
@openshift-merge-robot openshift-merge-robot merged commit 37adec8 into openshift:master Mar 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2022

@jrvaldes: Updated the following 3 configmaps:

  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master-presubmits.yaml
  • job-config-4.11 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.11-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.11-presubmits.yaml
  • job-config-4.12 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.12-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.12-presubmits.yaml

In response to this:

This PR sets the platform=none job to always run, following the
approach introduced in 19f53ec .

This change targets master, release-4.11 and release-4.12 branches.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2022

@jrvaldes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

@selansen selansen Awaiting requested review from selansen

Assignees

@mansikulkarni96 mansikulkarni96

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
4 participants
@jrvaldes @mansikulkarni96 @selansen @openshift-merge-robot