Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e-telco5g #27334

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Conversation

yuvalk
Copy link
Contributor

@yuvalk yuvalk commented Mar 28, 2022

trying to understand why job is still failing on PULL_BASE_REF

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 28, 2022
@yuvalk
Copy link
Contributor Author

yuvalk commented Mar 28, 2022

/retest

1 similar comment
@yuvalk
Copy link
Contributor Author

yuvalk commented Mar 28, 2022

/retest

@yuvalk yuvalk changed the title WIP: add debug info fix e2e-telco5g Apr 4, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2022
@yuvalk
Copy link
Contributor Author

yuvalk commented Apr 4, 2022

/unhold

@yuvalk
Copy link
Contributor Author

yuvalk commented Apr 4, 2022

@sshnaidm please review

@@ -18,6 +18,7 @@ fi
echo "************ telco5g gather-pao commands ************"

pao_mg_tag="4.10" # pao must-gather does not have 'latest' tag - setting 4.10 as a workaround for now.
PULL_BASE_REF=${PULL_BASE_REF:-master"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PULL_BASE_REF=${PULL_BASE_REF:-master"}
PULL_BASE_REF=${PULL_BASE_REF:-"master"}

@sshnaidm
Copy link
Contributor

sshnaidm commented Apr 4, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sshnaidm, yuvalk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuvalk
Copy link
Contributor Author

yuvalk commented Apr 4, 2022

/retest
missing cli image isnt caused by us

@openshift-merge-robot openshift-merge-robot merged commit ebb1ff5 into openshift:master Apr 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2022

@yuvalk: Updated the step-registry configmap in namespace ci at cluster app.ci using the following files:

  • key telco-bastion-setup-commands.sh using file ci-operator/step-registry/telco-bastion/setup/telco-bastion-setup-commands.sh
  • key telco5g-gather-pao-commands.sh using file ci-operator/step-registry/telco5g/gather-pao/telco5g-gather-pao-commands.sh

In response to this:

trying to understand why job is still failing on PULL_BASE_REF

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2022

@yuvalk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yuvalk
Copy link
Contributor Author

yuvalk commented Apr 4, 2022

/test pj-rehearse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
3 participants