Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD-469: add webhook image to csi-driver-shared-resource ci configuration #27887

Merged
merged 1 commit into from Apr 19, 2022

Conversation

jkhelil
Copy link
Contributor

@jkhelil jkhelil commented Apr 15, 2022

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2022
@@ -15,16 +15,19 @@ binary_build_commands: make build
build_root:
from_repository: true
images:
- dockerfile_path: Dockerfile
- dockerfile_path: images/Dockerfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah @jkhelil you should copy what we do for jenkins

see

- context_dir: "2"
dockerfile_path: Dockerfile.rhel8

you should have something like

- context_dir: "images"
  dockerfile_path: Dockerfile

and the same for must gather and webhook images, but point to their respective Dockerfiles with dockerfile_path

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@gabemontero
Copy link
Contributor

bit of a "chicken or egg" situation here .... the rehearsals here will not pass until openshift/csi-driver-shared-resource#92 merges, but that PR will not pass its images job until this one does

so we'll have to merge this even though the rehearsals fail

that said, after you make the changes for my comments @jkhelil you will need to run make openshift-image-mirror-mappings and then store those changes in a separate commit; also not, to get approval for those mirror mapping changes we'll have to pull in additional approvers outside our team.

@jkhelil
Copy link
Contributor Author

jkhelil commented Apr 19, 2022

bit of a "chicken or egg" situation here .... the rehearsals here will not pass until openshift/csi-driver-shared-resource#92 merges, but that PR will not pass its images job until this one does

so we'll have to merge this even though the rehearsals fail

that said, after you make the changes for my comments @jkhelil you will need to run make openshift-image-mirror-mappings and then store those changes in a separate commit; also not, to get approval for those mirror mapping changes we'll have to pull in additional approvers outside our team.

done

@gabemontero
Copy link
Contributor

gabemontero commented Apr 19, 2022

/retitle BUILD-469: add webhook image to csi-driver-shared-resource ci configuration

@openshift-ci openshift-ci bot changed the title WIP add webhook image to csi-driver-shared-resource ci configuration BUILD-469: add webhook image to csi-driver-shared-resource ci configuration Apr 19, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 19, 2022
@gabemontero
Copy link
Contributor

/lgtm

/assign @bparees

for approve of mirror update for our new webhook image here

note #27887 (comment) on rehearsal failures .... once actual repo changes merge we should be OK

@gabemontero
Copy link
Contributor

/assign @gabemontero

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2022
@bparees
Copy link
Contributor

bparees commented Apr 19, 2022

/approve

@gabemontero
Copy link
Contributor

/approve

thanks @bparees

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero, jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 19, 2022

@jkhelil: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/csi-driver-shared-resource/master/images 0334600 link unknown /test pj-rehearse
ci/rehearse/openshift/csi-driver-shared-resource/master/e2e-aws-csi-driver 0334600 link unknown /test pj-rehearse
ci/rehearse/openshift/csi-driver-shared-resource/master/e2e-aws-csi-driver-disruptive 0334600 link unknown /test pj-rehearse
ci/prow/pj-rehearse 0334600 link false /test pj-rehearse
ci/rehearse/openshift/csi-driver-shared-resource/master/e2e-aws-csi-driver-no-refreshresource 0334600 link unknown /test pj-rehearse
ci/rehearse/openshift/csi-driver-shared-resource/master/e2e-aws-csi-driver-slow 0334600 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b9c4035 into openshift:master Apr 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 19, 2022

@jkhelil: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-csi-driver-shared-resource-master.yaml using file ci-operator/config/openshift/csi-driver-shared-resource/openshift-csi-driver-shared-resource-master.yaml
  • image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:
    • key mapping_origin_4_11 using file core-services/image-mirroring/openshift/mapping_origin_4_11

In response to this:

referes to https://issues.redhat.com/browse/BUILD-469
@gabemontero PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
4 participants