New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUILD-469: add webhook image to csi-driver-shared-resource ci configuration #27887
Conversation
@@ -15,16 +15,19 @@ binary_build_commands: make build | |||
build_root: | |||
from_repository: true | |||
images: | |||
- dockerfile_path: Dockerfile | |||
- dockerfile_path: images/Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah @jkhelil you should copy what we do for jenkins
see
release/ci-operator/config/openshift/jenkins/openshift-jenkins-master.yaml
Lines 17 to 18 in 667722e
- context_dir: "2" | |
dockerfile_path: Dockerfile.rhel8 |
you should have something like
- context_dir: "images"
dockerfile_path: Dockerfile
and the same for must gather and webhook images, but point to their respective Dockerfiles with dockerfile_path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
bit of a "chicken or egg" situation here .... the rehearsals here will not pass until openshift/csi-driver-shared-resource#92 merges, but that PR will not pass its images job until this one does so we'll have to merge this even though the rehearsals fail that said, after you make the changes for my comments @jkhelil you will need to run |
done |
/retitle BUILD-469: add webhook image to csi-driver-shared-resource ci configuration |
/lgtm /assign @bparees for approve of mirror update for our new webhook image here note #27887 (comment) on rehearsal failures .... once actual repo changes merge we should be OK |
/assign @gabemontero |
/approve |
thanks @bparees |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, gabemontero, jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jkhelil: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@jkhelil: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
referes to https://issues.redhat.com/browse/BUILD-469
@gabemontero PTAL