Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-operator/config/openshift/installer/openshift-installer-master.yaml: Set containers_image_openpgp #3078

Closed
wants to merge 1 commit into from
Closed

ci-operator/config/openshift/installer/openshift-installer-master.yaml: Set containers_image_openpgp #3078

wants to merge 1 commit into from

Conversation

wking
Copy link
Member

@wking wking commented Mar 12, 2019

To avoid:

2019/03/12 16:18:40 Executing test unit
vendor/github.com/containers/image/pkg/blobinfocache/boltdb.go:9:2: cannot find package "github.com/boltdb/bolt" in any of:
  /go/src/github.com/openshift/installer/vendor/github.com/boltdb/bolt (vendor tree)
  /usr/local/go/src/github.com/boltdb/bolt (from $GOROOT)
  /go/src/github.com/boltdb/bolt (from $GOPATH)

and similar. CC @abhinavdahiya

@wking
ci-operator/config/openshift/installer/openshift-installer-master.yam…
ac9ee56 
…l: Set containers_image_openpgp

To avoid [1]:

  2019/03/12 16:18:40 Executing test unit
  vendor/github.com/containers/image/pkg/blobinfocache/boltdb.go:9:2: cannot find package "github.com/boltdb/bolt" in any of:
    /go/src/github.com/openshift/installer/vendor/github.com/boltdb/bolt (vendor tree)
    /usr/local/go/src/github.com/boltdb/bolt (from $GOROOT)
    /go/src/github.com/boltdb/bolt (from $GOPATH)

and similar.

[1]: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/1286/pull-ci-openshift-installer-master-unit/3190/build-log.txt
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2019
@abhinavdahiya
Copy link
Contributor

Would users of installer run tests without that tag?

@wking
Copy link
Member Author

wking commented Mar 12, 2019 •
edited
Loading

Would users of installer run tests without that tag?

If they wanted to have the installer create and sign new images? But I don't think that's very likely ;). The gpgme backend is only needed for signing, golang.org/x/crypto/openpgp is sufficient for verification (which is all I expect the installer to ever need).

@wking
Copy link
Member Author

wking commented Mar 12, 2019

images:

error: unable to upload the new image manifest: Head https://storage.googleapis.com/openshift-gce-devel-origin-ci-registry/docker/registry/v2/blobs/sha256/7d/7dc08a453700c3231957968049f8dfcb74c918a2f4af88cd7bdb7a678b197e0e/data?Expires=1552421558&GoogleAccessId=api-ci%40openshift-ci-infra.iam.gserviceaccount.com&Signature=LfMEQt4GiDcrRro7Z7mflkvEFULnYTY8tFEbOTjwWhbQMZX7mPX8nvnA52abNPPgkdzZKLdQl8fpmEqUEA2yjqnom2WrD%2FZLXzl9OPSN7%2FagjLLiqW0hv20XOM%2BKm6OmvL1cIN7WxbNCQiS%2FRoy1cAHWaTiGy%2FvgyG750Supkia8csjREC2goIYz8WBTcNDKoa9ayjPa4996meDJrBKgO8GqCSo2jM5LRhv%2BEOHTaThKuBmvzxv8pLGwrL3hYTbIlJXoZZ4P93CH0L6%2F7mOYO0VO3dMIfr9W8ZhS4hgSZh1%2FkBPzHrWmaoB4fWgVmaMe23LIGFa4IXJ6dH28Yw9XGg%3D%3D: read tcp 172.16.39.205:42686->74.125.141.128:443: read: connection reset by peer
2019/03/12 19:52:39 Container release in pod release-latest failed, exit code 1, reason Error

/retest

@wking
Copy link
Member Author

wking commented Mar 12, 2019

All green :).

@abhinavdahiya
Copy link
Contributor

Would users of installer run tests without that tag?

If they wanted to have the installer create and sign new images? But I don't think that's very likely ;). The gpgme backend is only needed for signing, golang.org/x/crypto/openpgp is sufficient for verification (which is all I expect the installer to ever need).

does that mean if we were to merge openshift/installer#1286
any go vet / go test will fail if we do not include that tag?

@wking
Copy link
Member Author

wking commented Mar 12, 2019

does that mean if we were to merge openshift/installer#1286 any go vet / go test will fail if we do not include that tag?

Yes, but I'd rather not include these in the installer's hack/* scripts because they're currently unopinionated wrappers around tools for containerization. Would you rather me put the opinions there?

@abhinavdahiya
Copy link
Contributor

does that mean if we were to merge openshift/installer#1286 any go vet / go test will fail if we do not include that tag?

Yes, but I'd rather not include these in the installer's hack/* scripts because they're currently unopinionated wrappers around tools for containerization. Would you rather me put the opinions there?

for example, we place all libvirt code behind libvirt tag. But that doesn't mean we don't vendor all that is required when libvirt tag is used.
how is this different from that?

@wking
Copy link
Member Author

wking commented Mar 13, 2019

for example, we place all libvirt code behind libvirt tag. But that doesn't mean we don't vendor all that is required when libvirt tag is used.

Unless you expect the installer to create signatures for new images (which I don't), we won't need gpgme. The openpgp library I'm enabling with this tag is all we need for verifying signatures. The libvirt libraries, on the other hand, have a valid (if occasional) installer use case.

@flaper87
Copy link
Contributor

/unassign

@flaper87
Copy link
Contributor

@abhinavdahiya @wking @crawford o/ folks! Can one of you please remove me from the assignees?

flaper87
flaper87 suggested changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@flaper87 flaper87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just setting request for change :)

@openshift-ci-robot
Copy link
Contributor

@flaper87: changing LGTM is restricted to collaborators

In response to this:

Just setting request for change :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/prow-config ac9ee56 link /test prow-config
ci/prow/step-registry-shellcheck ac9ee56 link /test step-registry-shellcheck
ci/prow/ci-operator-config ac9ee56 link /test ci-operator-config

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member Author

wking commented Apr 29, 2020

Doesn't seem to be much demand for this.

/close

@openshift-ci-robot
Copy link
Contributor

@wking: Closed this PR.

In response to this:

Doesn't seem to be much demand for this.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the installer-containers_image_openpgp branch April 29, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaper87 flaper87 flaper87 requested changes

@crawford crawford Awaiting requested review from crawford

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@wking @openshift-ci-robot @abhinavdahiya @flaper87