Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WINC-813: Add optional Windows e2e GCP jobs #31260

Merged
merged 2 commits into from Aug 11, 2022
Merged

WINC-813: Add optional Windows e2e GCP jobs #31260

merged 2 commits into from Aug 11, 2022

Conversation

sebsoto
Copy link
Contributor

@sebsoto sebsoto commented Aug 11, 2022

Adds optional GCP jobs that can be triggered to run on WMCO PRs

@sebsoto
Add Windows GCP e2e jobs
f24f8aa 
Adds config to master and release-4.12 branches.
Jobs generated with `make update`.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2022
@sebsoto
Copy link
Contributor Author

sebsoto commented Aug 11, 2022

/approve cancel

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2022
@sebsoto
Prevent Windows GCP job from running automatically
e0c7295 
* Sets job to optional, so it will not block merges.
* Removes the triggers for automatically running the job against WMCO
  PRs. This still allows for it to be manually triggered on PRs.

This commit should be reverted when the job is consistently able to
pass.
saifshaikh48
saifshaikh48 reviewed Aug 11, 2022
View reviewed changes
Copy link
Contributor

@saifshaikh48 saifshaikh48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for getting this setup @sebsoto

...ows-machine-config-operator/openshift-windows-machine-config-operator-master-presubmits.yaml
secret:
secretName: ci-pull-credentials
- name: cluster-profile
projected:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about projected volumes 💯

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2022
aravindhp
aravindhp approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @sebsoto

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, saifshaikh48

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2022
@openshift-merge-robot openshift-merge-robot merged commit ea8b388 into openshift:master Aug 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2022

@sebsoto: Updated the following 4 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-master.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml
  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.12.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.12.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master-presubmits.yaml
  • job-config-4.12 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-release-4.12-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-release-4.12-presubmits.yaml

In response to this:

Adds optional GCP jobs that can be triggered to run on WMCO PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2022

@sebsoto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/windows-machine-config-operator/master/gcp-e2e-operator e0c7295 link unknown /test pj-rehearse
ci/rehearse/openshift/windows-machine-config-operator/release-4.12/gcp-e2e-operator e0c7295 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saifshaikh48 saifshaikh48 saifshaikh48 left review comments

@aravindhp aravindhp aravindhp approved these changes

@mansikulkarni96 mansikulkarni96 Awaiting requested review from mansikulkarni96

Assignees

@aravindhp aravindhp

@saifshaikh48 saifshaikh48

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
4 participants
@sebsoto @aravindhp @saifshaikh48 @openshift-merge-robot