Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSSM maistra sharded config before creating jobs #31435

Merged
merged 1 commit into from Aug 19, 2022

Conversation

yxun
Copy link
Contributor

@yxun yxun commented Aug 17, 2022

Signed-off-by: Yuanlin yuanlin.xu@redhat.com

Signed-off-by: Yuanlin <yuanlin.xu@redhat.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2022

Hi @yxun. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yxun
Copy link
Contributor Author

yxun commented Aug 19, 2022

Could I have a review of this PR ?
The _plugins.yaml file is shared by all teams and is reordered from make update commands.
If this PR can be merged, it will help avoid conflicts when I create ci-operator config and jobs in the other PR.

Reason of change:

  • Adopt the ci/prow/correctly-sharded-config test result
  • Onboard existing OSSM maistra branch names before creating OSSM maistra ci operator config and jobs

Thanks,

@yxun
Copy link
Contributor Author

yxun commented Aug 19, 2022

This PR is related to #31484
It helps unblock the PR 31484
ci/prow/correctly-sharded-config presubmit test. Thanks,

@smg247
Copy link
Member

smg247 commented Aug 19, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smg247, yxun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2022

@yxun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d77f382 into openshift:master Aug 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 19, 2022

@yxun: Updated the plugins configmap in namespace ci at cluster app.ci using the following files:

  • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml

In response to this:

Signed-off-by: Yuanlin yuanlin.xu@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yxun yxun deleted the maistra-ci branch September 28, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
3 participants