Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WINC-823] wmco/wmcb: Add CI jobs for community 4.11 #31749

Merged
merged 3 commits into from Aug 31, 2022

Conversation

alinaryan
Copy link
Contributor

wmco/wmcb: Add configs for community-4.11
wmco/wmcb: conditionally skip CI jobs for community-4.11
core-services: onboard community-4.11 branch

Added the config file and ran 'make update'
to generate the new job. Edited the job to
leverage regexes to skip CI jobs for PRs
that exclusively change files in paths:
- starting with 'docs/'
- ending with '.md'
- whose basename matches any of
 - '.gitignore'
 - 'OWNERS'
 - 'PROJECT'
 - 'LICENSE'

Signed-off-by: Alina Ryan <aliryan@redhat.com>
- registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.18-openshift-4.11
to: windows-machine-config-operator-test
releases:
initial:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,72 @@
base_images:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding .github to the commit message. As per openshift-windows-machine-config-operator-community-4.11__okd.yaml line #60

Added the config file and ran 'make update'
to generate the new job. Edited the job to
leverage regexes to skip CI jobs for PRs
that exclusively change files in paths:
- starting with 'docs/'
- ending with '.md'
- whose basename matches any of
 - '.gitignore'
 - '.github'
 - 'OWNERS'
 - 'PROJECT'
 - 'LICENSE'

Signed-off-by: Alina Ryan <aliryan@redhat.com>
Signed-off-by: Alina Ryan <aliryan@redhat.com>
@jrvaldes
Copy link
Contributor

/retest-required

1 similar comment
@alinaryan
Copy link
Contributor Author

/retest-required

@alinaryan
Copy link
Contributor Author

/test pj-rehearse

1 similar comment
@alinaryan
Copy link
Contributor Author

/test pj-rehearse

@alinaryan
Copy link
Contributor Author

/test pj-rehearse

2 similar comments
@alinaryan
Copy link
Contributor Author

/test pj-rehearse

@alinaryan
Copy link
Contributor Author

/test pj-rehearse

Copy link
Contributor

@saifshaikh48 saifshaikh48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

one comment, not a showstopper though

pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-openshift-windows-machine-config-bootstrapper-community-4.11-okd-build
rerun_command: /test okd-build
skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit since this is WMCB config:

Consider using the updated regex introduced here 66a6b2d and update the commit message. Applies throughout the commit

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2022
@sebsoto
Copy link
Contributor

sebsoto commented Aug 31, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alinaryan, saifshaikh48, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2022

@alinaryan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/pj-rehearse 72358ad link false /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8517203 into openshift:master Aug 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2022

@alinaryan: Updated the following 3 configmaps:

  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-bootstrapper-community-4.11__okd.yaml using file ci-operator/config/openshift/windows-machine-config-bootstrapper/openshift-windows-machine-config-bootstrapper-community-4.11__okd.yaml
    • key openshift-windows-machine-config-operator-community-4.11__okd.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-community-4.11__okd.yaml
  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-bootstrapper-community-4.11-postsubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-bootstrapper/openshift-windows-machine-config-bootstrapper-community-4.11-postsubmits.yaml
    • key openshift-windows-machine-config-bootstrapper-community-4.11-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-bootstrapper/openshift-windows-machine-config-bootstrapper-community-4.11-presubmits.yaml
    • key openshift-windows-machine-config-operator-community-4.11-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-community-4.11-presubmits.yaml
  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-windows-machine-config-bootstrapper-_pluginconfig.yaml using file core-services/prow/02_config/openshift/windows-machine-config-bootstrapper/_pluginconfig.yaml
    • key core-services-prow-02_config-openshift-windows-machine-config-operator-_pluginconfig.yaml using file core-services/prow/02_config/openshift/windows-machine-config-operator/_pluginconfig.yaml

In response to this:

wmco/wmcb: Add configs for community-4.11
wmco/wmcb: conditionally skip CI jobs for community-4.11
core-services: onboard community-4.11 branch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alinaryan alinaryan changed the title wmco/wmcb: Add CI jobs for community 4.11 [WINC-823] wmco/wmcb: Add CI jobs for community 4.11 Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
5 participants