New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WINC-823] wmco/wmcb: Add CI jobs for community 4.11 #31749
[WINC-823] wmco/wmcb: Add CI jobs for community 4.11 #31749
Conversation
Added the config file and ran 'make update' to generate the new job. Edited the job to leverage regexes to skip CI jobs for PRs that exclusively change files in paths: - starting with 'docs/' - ending with '.md' - whose basename matches any of - '.gitignore' - 'OWNERS' - 'PROJECT' - 'LICENSE' Signed-off-by: Alina Ryan <aliryan@redhat.com>
- registry.ci.openshift.org/ocp/builder:rhel-8-golang-1.18-openshift-4.11 | ||
to: windows-machine-config-operator-test | ||
releases: | ||
initial: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,72 @@ | |||
base_images: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding .github
to the commit message. As per openshift-windows-machine-config-operator-community-4.11__okd.yaml line #60
Added the config file and ran 'make update' to generate the new job. Edited the job to leverage regexes to skip CI jobs for PRs that exclusively change files in paths: - starting with 'docs/' - ending with '.md' - whose basename matches any of - '.gitignore' - '.github' - 'OWNERS' - 'PROJECT' - 'LICENSE' Signed-off-by: Alina Ryan <aliryan@redhat.com>
Signed-off-by: Alina Ryan <aliryan@redhat.com>
f42c71e
to
72358ad
Compare
/retest-required |
1 similar comment
/retest-required |
/test pj-rehearse |
1 similar comment
/test pj-rehearse |
/test pj-rehearse |
2 similar comments
/test pj-rehearse |
/test pj-rehearse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
one comment, not a showstopper though
pj-rehearse.openshift.io/can-be-rehearsed: "true" | ||
name: pull-ci-openshift-windows-machine-config-bootstrapper-community-4.11-okd-build | ||
rerun_command: /test okd-build | ||
skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit since this is WMCB config:
Consider using the updated regex introduced here 66a6b2d and update the commit message. Applies throughout the commit
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alinaryan, saifshaikh48, sebsoto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alinaryan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@alinaryan: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wmco/wmcb: Add configs for community-4.11
wmco/wmcb: conditionally skip CI jobs for community-4.11
core-services: onboard community-4.11 branch