Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCO: Move extracted gcp credentials requests to shared directory #32264

Closed
wants to merge 1 commit into from
Closed

CCO: Move extracted gcp credentials requests to shared directory #32264

wants to merge 1 commit into from

Conversation

akhil-rane
Copy link
Contributor

ccoctl gcp delete commmand now requires credentials requests inorder
to successfully remove the previously created infrastucture. Moving the
extracted credentials requests manifests in the provision stage to a shared
folder so that they can then be used during deprovision stage.

x-ref: https://issues.redhat.com/browse/CCO-242

@akhil-rane
Move extracted gcp credentials requests to shared directory
96cfd95 
`ccoctl gcp delete` commmand now requires credentials requests inorder
to successfully remove the previously created infrastucture. Moving
the extracted credentials requests manifests in the provision stage
to a shared folder so that they can then be used during deprovision
stage.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akhil-rane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2022
@akhil-rane
Copy link
Contributor Author

/hold

wait for #cloud-credential-operator/pull/489 to merge

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@akhil-rane
Copy link
Contributor Author

/test ci/rehearse/openshift/cloud-credential-operator/master/e2e-gcp-manual-oidc

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

@akhil-rane: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build-clusters
  • /test build01-dry
  • /test build02-dry
  • /test build03-dry
  • /test build04-dry
  • /test build05-dry
  • /test check-gh-automation
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-bootstrap-config-validation
  • /test ci-testgrid-allow-list
  • /test config
  • /test core-valid
  • /test correctly-sharded-config
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test hive-dry
  • /test jira-lifecycle-config
  • /test openshift-image-mirror-mappings
  • /test ordered-prow-config
  • /test owners
  • /test pj-rehearse-blocking
  • /test pr-reminder-config
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test pylint
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test sync-rover-groups
  • /test yamllint

The following commands are available to trigger optional jobs:

  • /test arm01-dry
  • /test pj-rehearse
  • /test pj-rehearse-max
  • /test pj-rehearse-more
  • /test vsphere-dry

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-release-master-build-clusters
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-pj-rehearse
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-openshift-image-mirror-mappings
  • pull-ci-openshift-release-yamllint

In response to this:

/test ci/rehearse/openshift/cloud-credential-operator/master/e2e-gcp-manual-oidc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abutcher
Copy link
Member

/test ci/rehearse/openshift/cloud-credential-operator/master/e2e-gcp-manual-oidc

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2022

@abutcher: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build-clusters
  • /test build01-dry
  • /test build02-dry
  • /test build03-dry
  • /test build04-dry
  • /test build05-dry
  • /test check-gh-automation
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-bootstrap-config-validation
  • /test ci-testgrid-allow-list
  • /test config
  • /test core-valid
  • /test correctly-sharded-config
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test hive-dry
  • /test jira-lifecycle-config
  • /test openshift-image-mirror-mappings
  • /test ordered-prow-config
  • /test owners
  • /test pj-rehearse-blocking
  • /test pr-reminder-config
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test pylint
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test sync-rover-groups
  • /test yamllint

The following commands are available to trigger optional jobs:

  • /test arm01-dry
  • /test pj-rehearse
  • /test pj-rehearse-max
  • /test pj-rehearse-more
  • /test vsphere-dry

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-release-master-build-clusters
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-pj-rehearse
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-openshift-image-mirror-mappings
  • pull-ci-openshift-release-yamllint

In response to this:

/test ci/rehearse/openshift/cloud-credential-operator/master/e2e-gcp-manual-oidc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abutcher
Copy link
Member

/retest

@akhil-rane akhil-rane changed the title Move extracted gcp credentials requests to shared directory CCO: Move extracted gcp credentials requests to shared directory Sep 21, 2022
@abutcher
Copy link
Member

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022

@akhil-rane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.12-nightly-4.12-upgrade-from-stable-4.11-gcp-ipi-cco-manual-workload-identity-p1 96cfd95 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-e2e-gcp-ipi-cco-manual-workload-identity-p1 96cfd95 link unknown /test pj-rehearse
ci/rehearse/openshift/cloud-credential-operator/master/e2e-gcp-manual-oidc 96cfd95 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.11-gcp-ipi-cco-manual-workload-identity-p1 96cfd95 link unknown /test pj-rehearse
ci/prow/pj-rehearse 96cfd95 link false /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abutcher abutcher mentioned this pull request Oct 24, 2022
Merged
@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2022
@openshift-merge-robot
Copy link
Contributor

@akhil-rane: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 16, 2022
@abutcher
Copy link
Member

Superseded by #33402
/close

@openshift-ci openshift-ci bot closed this Nov 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2022

@abutcher: Closed this PR.

In response to this:

Superseded by #33402
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

@smg247 smg247 Awaiting requested review from smg247

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
4 participants
@akhil-rane @abutcher @openshift-bot @openshift-merge-robot