Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run monitor as part of the resource watch observer #33760

Merged

Conversation

xueqzhan
Copy link
Contributor

@xueqzhan xueqzhan commented Nov 4, 2022

@openshift-ci-robot
Copy link
Contributor

@xueqzhan: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-master-e2e-gcp-builds openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-master-e2e-gcp-disruptive openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-master-e2e-gcp-image-ecosystem openshift/origin presubmit Registry content changed
pull-ci-openshift-openshift-apiserver-master-e2e-aws-ovn-cmd openshift/openshift-apiserver presubmit Registry content changed
pull-ci-openshift-machine-api-operator-master-e2e-nutanix openshift/machine-api-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-master-e2e-ovn-hybrid-step-registry openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-master-e2e-ovn-ipsec-step-registry openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-master-e2e-azure-ovn-dualstack openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-master-e2e-gcp-ovn-upgrade openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-priv-cloud-provider-gcp-master-e2e-gcp-ccm openshift-priv/cloud-provider-gcp presubmit Registry content changed
pull-ci-openshift-priv-cloud-provider-gcp-master-e2e-gcp-ccm-install openshift-priv/cloud-provider-gcp presubmit Registry content changed
pull-ci-openshift-priv-cloud-provider-gcp-master-e2e-gcp-ccm-ovn openshift-priv/cloud-provider-gcp presubmit Registry content changed
pull-ci-openshift-priv-cloud-network-config-controller-master-e2e-aws-ovn-serial openshift-priv/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-priv-cloud-network-config-controller-master-e2e-aws-serial openshift-priv/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-priv-cloud-network-config-controller-master-e2e-azure-ovn openshift-priv/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-priv-cloud-network-config-controller-master-e2e-gcp-ovn openshift-priv/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-priv-cloud-network-config-controller-master-e2e-openstack-sdn-serial-e2e-only openshift-priv/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-priv-cloud-network-config-controller-master-e2e-openstack-ovn-serial-e2e-only openshift-priv/cloud-network-config-controller presubmit Registry content changed
pull-ci-openshift-cluster-samples-operator-master-okd-e2e-aws-builds openshift/cluster-samples-operator presubmit Registry content changed
pull-ci-openshift-cluster-samples-operator-master-okd-e2e-aws-image-ecosystem openshift/cluster-samples-operator presubmit Registry content changed
pull-ci-openshift-cluster-samples-operator-master-okd-e2e-aws-jenkins openshift/cluster-samples-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-disruptive openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-workers-rhel8 openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-master-e2e-gcp-single-node openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-master-e2e-vsphere openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-master-e2e-azure-ovn-upgrade openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-master-e2e-ovirt-upgrade openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-master-e2e-vsphere-upgrade openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-cluster-openshift-controller-manager-operator-master-openshift-e2e-aws-builds-techpreview openshift/cluster-openshift-controller-manager-operator presubmit Registry content changed
pull-ci-openshift-priv-cloud-credential-operator-master-e2e-aws-manual-oidc openshift-priv/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-priv-cloud-credential-operator-master-e2e-gcp-manual-oidc openshift-priv/cloud-credential-operator presubmit Registry content changed
pull-ci-openshift-priv-csi-driver-manila-operator-master-e2e-openstack-csi openshift-priv/csi-driver-manila-operator presubmit Registry content changed
pull-ci-openshift-priv-cluster-storage-operator-master-e2e-azure-file-csi openshift-priv/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-priv-kubernetes-master-e2e-gcp openshift-priv/kubernetes presubmit Registry content changed

A total of 159 jobs were affected by this change. The above listing is non-exhaustive and limited to 35 jobs

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals

@xueqzhan
Copy link
Contributor Author

xueqzhan commented Nov 4, 2022

/pj-rehearse

@dgoodwin
Copy link
Contributor

dgoodwin commented Nov 4, 2022

/lgtm
/hold

Feel free to release hold when you're happy with the rehersal results. Thanks for fixing the trap as well!

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2022
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Nov 4, 2022
@xueqzhan
Copy link
Contributor Author

xueqzhan commented Nov 4, 2022

/pj-rehearse

@xueqzhan
Copy link
Contributor Author

xueqzhan commented Nov 4, 2022

/test pj-rehearse

@xueqzhan
Copy link
Contributor Author

xueqzhan commented Nov 4, 2022

/test pj-rehearse

@openshift-ci-robot
Copy link
Contributor

Failed to create rehearsal jobs

@xueqzhan
Copy link
Contributor Author

xueqzhan commented Nov 7, 2022

/test pj-rehearse

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2022

@xueqzhan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift-kni/cnf-features-deploy/master/e2e-gcp-ovn 2b3131cce52a5ab34dde703797cbe93059d59fb7 link unknown /test pj-rehearse
ci/rehearse/openshift/sdn/master/e2e-gcp-sdn 6c9e59e223a7f37e18e5afb93e0b52889b3987b6 link unknown /test pj-rehearse
ci/rehearse/openshift/cloud-credential-operator/master/e2e-aws-manual-oidc 2b3131cce52a5ab34dde703797cbe93059d59fb7 link unknown /test pj-rehearse
ci/rehearse/openshift/csi-external-provisioner/master/e2e-aws-csi 2b3131cce52a5ab34dde703797cbe93059d59fb7 link unknown /test pj-rehearse
ci/rehearse/openshift/cloud-credential-operator/master/e2e-gcp-manual-oidc 2b3131cce52a5ab34dde703797cbe93059d59fb7 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/master/e2e-aws-ccm-install 2b3131cce52a5ab34dde703797cbe93059d59fb7 link unknown /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-gcp-ovn-shared-vpc 3c23fdda17a0691984b0c826b2c383f6a2d1d732 link unknown /test pj-rehearse
ci/rehearse/openshift/machine-api-provider-ibmcloud/main/e2e-ibmcloud 2b3131cce52a5ab34dde703797cbe93059d59fb7 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/master/e2e-azure-ccm-install 2b3131cce52a5ab34dde703797cbe93059d59fb7 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/master/e2e-azure-ovn-dualstack 6c9e59e223a7f37e18e5afb93e0b52889b3987b6 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-logging-operator/release-5.2/e2e 6c9e59e223a7f37e18e5afb93e0b52889b3987b6 link unknown /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-gcp-upi-xpn 3c23fdda17a0691984b0c826b2c383f6a2d1d732 link unknown /test pj-rehearse
ci/rehearse/openshift/alibaba-disk-csi-driver-operator/master/e2e-alibabacloud-disk-csi 2b3131cce52a5ab34dde703797cbe93059d59fb7 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/master/e2e-gcp-ccm-install 2b3131cce52a5ab34dde703797cbe93059d59fb7 link unknown /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-ovn-workers-rhel8 2b3131cce52a5ab34dde703797cbe93059d59fb7 link unknown /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws-upi-proxy 3c23fdda17a0691984b0c826b2c383f6a2d1d732 link unknown /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-gcp-single-node 2b3131cce52a5ab34dde703797cbe93059d59fb7 link unknown /test pj-rehearse
ci/rehearse/openshift/sdn/master/e2e-aws-sdn-upgrade 6c9e59e223a7f37e18e5afb93e0b52889b3987b6 link unknown /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-workers-rhel8 2b3131cce52a5ab34dde703797cbe93059d59fb7 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/master/e2e-vsphere-ccm 2b3131cce52a5ab34dde703797cbe93059d59fb7 link unknown /test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-openstack-upi 3c23fdda17a0691984b0c826b2c383f6a2d1d732 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-kube-apiserver-operator/master/e2e-aws-serial 6c9e59e223a7f37e18e5afb93e0b52889b3987b6 link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-cloud-controller-manager-operator/master/e2e-vsphere-ccm-install 2b3131cce52a5ab34dde703797cbe93059d59fb7 link unknown /test pj-rehearse
ci/prow/pj-rehearse 6242c2e04dc7a5010c3977142494e1cdca0cf2fe link false /test pj-rehearse
ci/rehearse/openshift/csi-external-attacher/release-4.7/e2e-ovirt 6242c2e04dc7a5010c3977142494e1cdca0cf2fe link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-samples-operator/master/okd-scos-e2e-aws-jenkins 6242c2e04dc7a5010c3977142494e1cdca0cf2fe link unknown /test pj-rehearse
ci/rehearse/openshift/kubernetes/master/4.11-upgrade-from-stable-4.10-e2e-aws-ovn-upgrade 6242c2e04dc7a5010c3977142494e1cdca0cf2fe link unknown /test pj-rehearse
ci/rehearse/openshift/cluster-kube-apiserver-operator/master/e2e-gcp-operator-single-node 6242c2e04dc7a5010c3977142494e1cdca0cf2fe link unknown /test pj-rehearse
ci/rehearse/openshift/cloud-provider-openstack/release-4.11/e2e-openstack-ccm-install 6242c2e04dc7a5010c3977142494e1cdca0cf2fe link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stbenjam
Copy link
Member

stbenjam commented Nov 8, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, stbenjam, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xueqzhan
Copy link
Contributor Author

xueqzhan commented Nov 8, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit 866aad1 into openshift:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
5 participants