Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPVE-166 - reenable stalld for realtime config #33937

Merged
merged 1 commit into from Dec 6, 2022
Merged

OCPVE-166 - reenable stalld for realtime config #33937

merged 1 commit into from Dec 6, 2022

Conversation

jeff-roche
Copy link
Contributor

stalld is now in coreos so reenable it for realtime

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2022
@openshift-ci-robot
Copy link
Contributor

@jeff-roche: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-master-nightly-4.6-e2e-gcp-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-gcp-ovn-rt-upgrade N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jeff-roche
Copy link
Contributor Author

/pj-rehearse

@jeff-roche jeff-roche changed the title [WIP] reenable stalld for realtime config [WIP] OCPVE-166 - reenable stalld for realtime config Nov 10, 2022
@bear-redhat
Copy link
Contributor

/pj-rehearse

@jeff-roche jeff-roche changed the title [WIP] OCPVE-166 - reenable stalld for realtime config OCPVE-166 - reenable stalld for realtime config Nov 22, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2022
@jeff-roche
Copy link
Contributor Author

@dinhxuanvu @nmars This should be good to go now

dinhxuanvu
dinhxuanvu reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2022
@jeff-roche
Copy link
Contributor Author

/assign @yanirq

@yanirq
Copy link
Contributor

yanirq commented Nov 22, 2022

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2022
@eggfoobar
Copy link
Contributor

/hold

Sorry for the late add, thinking we might need to make a small change here to help out the 4.10 -> 4.11 periodics. We should expose turning off stalld for now so we don't fail those jobs for the time being.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 22, 2022
@jeff-roche
Copy link
Contributor Author

/pj-rehearse refresh
/pj-rehearse more

1 similar comment
@jeff-roche
Copy link
Contributor Author

/pj-rehearse refresh
/pj-rehearse more

@openshift-ci-robot
Copy link
Contributor

@jeff-roche: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-gcp-ovn-rt-upgrade N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.11-e2e-gcp-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.10-upgrade-from-stable-4.9-e2e-gcp-ovn-rt-upgrade N/A periodic Registry content changed

@eggfoobar
Copy link
Contributor

Looking good, the script seems to be correctly applying the config. Let's do one more rehearsal to see it succeed, seems the current error is not related.

/pj-rehearse more

@jeff-roche
Copy link
Contributor Author

I'm not sure why e2e-gcp-ovt-rt-upgrade is failing. It keeps complaining about an image not being available which these changes should have an effect on

@jeff-roche
Copy link
Contributor Author

/pj-rehearse more

@jeff-roche
Copy link
Contributor Author

/pj-rehearse refresh
/pj-rehearse more

@openshift-ci-robot
Copy link
Contributor

@jeff-roche: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-master-ci-4.10-upgrade-from-stable-4.9-e2e-gcp-ovn-rt-upgrade N/A periodic Ci-operator config changed
periodic-ci-openshift-release-master-nightly-4.9-e2e-gcp-rt N/A periodic Registry content changed

@jeff-roche
Copy link
Contributor Author

/pj-rehearse more

@jeff-roche
reenable stalld now that it is in coreos
93929f4 
opening up realtime cpu usage

allow optionally disabling stalld via env

Updated the bash and configured 4.10 upgrade to 4.11 to disable stalld

fixed a bash syntax error and added some output to the if statement

swapping to 4.9 to 4.10 from 4.10 to 4.11
@jeff-roche
Copy link
Contributor Author

Squashed all the commits, 4.12 -> 4.13 upgrade should be fixed

/unhold

/pj-rehearse more

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2022

@jeff-roche: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.9-e2e-gcp-rt 93929f4 link unknown /pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yanirq
Copy link
Contributor

yanirq commented Nov 30, 2022

/approve

@eggfoobar
Copy link
Contributor

/lgtm
/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Nov 30, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2022
@yanirq
Copy link
Contributor

yanirq commented Dec 1, 2022

/approve

@jeff-roche
Copy link
Contributor Author

jeff-roche commented Dec 1, 2022 •
edited

/assign @stbenjam

@stbenjam
Copy link
Member

stbenjam commented Dec 6, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, eggfoobar, jeff-roche, stbenjam, yanirq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2022
@openshift-merge-robot openshift-merge-robot merged commit 97d838f into openshift:master Dec 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2022

@jeff-roche: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-release-master__ci-4.10-upgrade-from-stable-4.9.yaml using file ci-operator/config/openshift/release/openshift-release-master__ci-4.10-upgrade-from-stable-4.9.yaml

In response to this:

stalld is now in coreos so reenable it for realtime

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeff-roche jeff-roche deleted the reenable_stalld branch December 6, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhxuanvu dinhxuanvu dinhxuanvu left review comments

@nmars nmars Awaiting requested review from nmars

Assignees

@stbenjam stbenjam

@dinhxuanvu dinhxuanvu

@eggfoobar eggfoobar

@yanirq yanirq

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
8 participants
@jeff-roche @openshift-ci-robot @bear-redhat @yanirq @eggfoobar @stbenjam @dinhxuanvu @openshift-merge-robot