Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AGENT-350: Collect journal logs and publish them as artifacts #34586

Merged
merged 3 commits into from Dec 9, 2022
Merged

AGENT-350: Collect journal logs and publish them as artifacts #34586

merged 3 commits into from Dec 9, 2022

Conversation

pawanpinjarkar
Copy link
Contributor

Signed-off-by: Pawan Pinjarkar ppinjark@redhat.com

@openshift-ci-robot
Copy link
Contributor

@pawanpinjarkar: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-priv-installer-master-e2e-agent-compact-ipv4 openshift-priv/installer presubmit Registry content changed
pull-ci-openshift-priv-installer-master-e2e-agent-mce openshift-priv/installer presubmit Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@pawanpinjarkar
Copy link
Contributor Author

/hold for openshift-metal3/dev-scripts#1486

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 6, 2022
@pawanpinjarkar
Copy link
Contributor Author

/cc @andfasano @bfournie @zaneb

@zaneb
Copy link
Member

zaneb commented Dec 7, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2022
@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse

@zaneb
Copy link
Member

zaneb commented Dec 8, 2022

Looks like it needs make registry-metadata
/approve

@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse

@zaneb
Copy link
Member

zaneb commented Dec 8, 2022

/pj-rehearse refresh

@openshift-ci-robot
Copy link
Contributor

@zaneb: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-master-e2e-agent-compact-ipv4 openshift/installer presubmit Registry content changed
pull-ci-openshift-installer-master-e2e-agent-mce openshift/installer presubmit Registry content changed

@zaneb
Copy link
Member

zaneb commented Dec 8, 2022

/pj-rehearse auto-ack

@pawanpinjarkar
Copy link
Contributor Author

/hold for openshift-metal3/dev-scripts#1488 and openshift/installer#6683

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2022
@pawanpinjarkar
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2022
@pawanpinjarkar
AGENT-350: Collect journal logs and publish them as artifacts
e382011 
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
@pawanpinjarkar
Rename files and paths
4692e07 
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
@pawanpinjarkar
Copy host specific agent gather tar files
41a8389 
Signed-off-by: Pawan Pinjarkar <ppinjark@redhat.com>
@pawanpinjarkar
Copy link
Contributor Author

/pj-rehearse auto-ack

@zaneb
Copy link
Member

zaneb commented Dec 9, 2022

Artifacts were not generated because the cluster installed successfully (thus no hosts were left running the agent ISO), but at least we know it doesn't regress anything, and in principle it should help if something fails prior to the reboots.
/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 9, 2022
@bfournie
Copy link
Contributor

bfournie commented Dec 9, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie, pawanpinjarkar, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2022

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift-priv/assisted-service/master/e2e-agent-compact f4d835ac6593a999ce6487f99709a2b9593c55dc link unknown /pj-rehearse pull-ci-openshift-priv-assisted-service-master-e2e-agent-compact
ci/rehearse/openshift-priv/installer/master/e2e-agent-compact-ipv4 f4d835ac6593a999ce6487f99709a2b9593c55dc link unknown /pj-rehearse pull-ci-openshift-priv-installer-master-e2e-agent-compact-ipv4
ci/rehearse/openshift-priv/installer/master/e2e-agent-mce f4d835ac6593a999ce6487f99709a2b9593c55dc link unknown /pj-rehearse pull-ci-openshift-priv-installer-master-e2e-agent-mce
ci/rehearse/openshift/installer/master/e2e-agent-mce 41a8389 link unknown /pj-rehearse pull-ci-openshift-installer-master-e2e-agent-mce

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f556c4c into openshift:master Dec 9, 2022
@smg247
Copy link
Member

smg247 commented Dec 16, 2022

/pj-rehearse refresh

@openshift-ci-robot
Copy link
Contributor

@smg247: no rehearsable tests are affected by this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andfasano andfasano andfasano left review comments

@bear-redhat bear-redhat Awaiting requested review from bear-redhat

@smg247 smg247 Awaiting requested review from smg247

@bfournie bfournie Awaiting requested review from bfournie

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@bfournie bfournie

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
7 participants
@pawanpinjarkar @openshift-ci-robot @zaneb @bfournie @smg247 @andfasano @openshift-merge-robot