Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy aws-upi job replaced w/ step-registry job; removed from testcase analysis #34926

Conversation

DennisPeriquet
Copy link
Contributor

@DennisPeriquet DennisPeriquet commented Dec 19, 2022

TRT-743

  • In release-controller, we replace the legacy (based on templates) aws-upi jobs with those that use step-registry.
  • Not enough job runs for the aws-upi job causes that case to fail in the testcase analysis job, so we remove it.
  • Manually remove the two legacy jobs from their corresponding jobs yaml files; since the jobs are removed, their allowlist entries are no longer relevant.

Generated files (via make release-controllers:

  • core-services/release-controller/_releases/priv/release-ocp-4.12.json
  • core-services/release-controller/_releases/priv/release-ocp-4.13.json

@xueqzhan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2022
@stbenjam
Copy link
Member

stbenjam commented Jan 3, 2023

/lgtm

@stbenjam
Copy link
Member

stbenjam commented Jan 3, 2023

/approve

@smg247
Copy link
Member

smg247 commented Jan 3, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, smg247, stbenjam, xueqzhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023
@DennisPeriquet
Copy link
Contributor Author

/rehearsals-ack

@DennisPeriquet
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 4, 2023
@openshift-ci-robot
Copy link
Contributor

@DennisPeriquet: no rehearsable tests are affected by this change

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2023

@DennisPeriquet: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 78eef9b into openshift:master Jan 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 4, 2023

@DennisPeriquet: Updated the following 2 configmaps:

  • job-config-4.12 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-release-4.12-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.12-periodics.yaml
  • job-config-4.13 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-release-4.13-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.13-periodics.yaml

In response to this:

TRT-743

  • In release-controller, we replace the legacy (based on templates) aws-upi jobs with those that use step-registry.
  • Not enough job runs for the aws-upi job causes that case to fail in the testcase analysis job, so we remove it.
  • Manually remove the two legacy jobs from their corresponding jobs yaml files; since the jobs are removed, their allowlist entries are no longer relevant.

Generated files (via make release-controllers:

  • core-services/release-controller/_releases/priv/release-ocp-4.12.json
  • core-services/release-controller/_releases/priv/release-ocp-4.13.json

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
6 participants