Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new tests on the notebooks for supporting UBI9 for ODH notebooks repository. #34935

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Add new tests on the notebooks for supporting UBI9 for ODH notebooks repository. #34935

merged 1 commit into from
Jan 16, 2023

Conversation

atheo89
Copy link
Contributor

@atheo89 atheo89 commented Dec 20, 2022

Add new tests on the notebooks for supporting UBI9 for the ODH notebooks repository.

This PR should be merge prior to opendatahub-io/notebooks#30

@openshift-ci-robot
Copy link
Contributor

@atheo89: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-notebooks-main-notebook-base-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Presubmit changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-datascience-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Presubmit changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-minimal-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Presubmit changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-pytorch-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Presubmit changed
pull-ci-opendatahub-io-notebooks-main-images opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-base-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-ds-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-minimal-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-tf-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-datascience-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-minimal-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-jupyter-pytorch-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebooks-e2e-tests opendatahub-io/notebooks presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@atheo89 atheo89 mentioned this pull request Dec 20, 2022
Merged
3 tasks
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 26, 2022
@atheo89 atheo89 force-pushed the add-tests-for-ubi9-notebooks branch from f20d3d6 to f4b08b9 Compare January 9, 2023 12:08
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2023
@atheo89 atheo89 force-pushed the add-tests-for-ubi9-notebooks branch from f4b08b9 to 4d599d2 Compare January 9, 2023 12:15
@atheo89 atheo89 force-pushed the add-tests-for-ubi9-notebooks branch from 4d599d2 to 4df8f31 Compare January 12, 2023 15:54
VaishnaviHire
VaishnaviHire reviewed Jan 12, 2023
View reviewed changes
Copy link
Contributor

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atheo89
Copy link
Contributor Author

atheo89 commented Jan 13, 2023

/rehearsals-ack

@atheo89
Copy link
Contributor Author

atheo89 commented Jan 13, 2023

Hi @bear-redhat, can you help us to merge the PR? It seems that the /rehearsals-ack can not get assigned as a label in order to fulfill the tide test. Thank you in advance.

@droslean
Copy link
Member

/rehearsals-ack

2 similar comments
@droslean
Copy link
Member

/rehearsals-ack

@droslean
Copy link
Member

/rehearsals-ack

@droslean
Copy link
Member

/rehearse ack

@droslean
Copy link
Member

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2023

@atheo89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1d47e62 into openshift:master Jan 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2023

@atheo89: Updated the following 3 configmaps:

  • job-config-master-postsubmits configmap in namespace ci at cluster app.ci using the following files:
    • key opendatahub-io-notebooks-main-postsubmits.yaml using file ci-operator/jobs/opendatahub-io/notebooks/opendatahub-io-notebooks-main-postsubmits.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key opendatahub-io-notebooks-main-presubmits.yaml using file ci-operator/jobs/opendatahub-io/notebooks/opendatahub-io-notebooks-main-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key opendatahub-io-notebooks-main.yaml using file ci-operator/config/opendatahub-io/notebooks/opendatahub-io-notebooks-main.yaml

In response to this:

Add new tests on the notebooks for supporting UBI9 for the ODH notebooks repository.

This PR should be merge prior to opendatahub-io/notebooks#30

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaishnaviHire VaishnaviHire VaishnaviHire left review comments

@bear-redhat bear-redhat Awaiting requested review from bear-redhat

Assignees

@VaishnaviHire VaishnaviHire

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
5 participants
@atheo89 @openshift-ci-robot @droslean @VaishnaviHire @openshift-merge-robot