Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -ovn- to cluster-control-plane-machine-set-operator #35181

Merged
merged 1 commit into from Jan 19, 2023

Conversation

jluhrsen
Copy link
Contributor

@jluhrsen jluhrsen commented Jan 5, 2023

this will fix some flakes that are checking that the job name contains the string of the underlying CNI, which is ovn by default in 4.12+

found with this one-liner:
❯ w3m -dump -cols 200
"https://search.ci.openshift.org/?maxAge=96h&type=junit&search=job+name.*does+not+have+network+type+in+name.*expected.*ovn" | sed -n 's/^([^ ]*) .failures match./\1/p' | sort | rg cluster-control-plane-machine-set-operator

pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-serial pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-upgrade pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-serial pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-upgrade

Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Jan 5, 2023

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jluhrsen: the following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-ovn-serial openshift/cluster-control-plane-machine-set-operator presubmit Presubmit changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-ovn-upgrade openshift/cluster-control-plane-machine-set-operator presubmit Presubmit changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-ovn-serial openshift/cluster-control-plane-machine-set-operator presubmit Presubmit changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-ovn-upgrade openshift/cluster-control-plane-machine-set-operator presubmit Presubmit changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.13-e2e-aws-ovn-serial openshift/cluster-control-plane-machine-set-operator presubmit Presubmit changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.13-e2e-aws-ovn-upgrade openshift/cluster-control-plane-machine-set-operator presubmit Presubmit changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.14-e2e-aws-ovn-serial openshift/cluster-control-plane-machine-set-operator presubmit Presubmit changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.14-e2e-aws-ovn-upgrade openshift/cluster-control-plane-machine-set-operator presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2023

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-control-plane-machine-set-operator/release-4.13/e2e-aws-ovn-upgrade 873df73a021b89fa0ca9f515369086a9fe799f60 link unknown /pj-rehearse pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.13-e2e-aws-ovn-upgrade
ci/rehearse/openshift/cluster-control-plane-machine-set-operator/main/e2e-aws-ovn-serial 873df73a021b89fa0ca9f515369086a9fe799f60 link unknown /pj-rehearse pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-ovn-serial
ci/rehearse/openshift/cluster-control-plane-machine-set-operator/release-4.13/e2e-aws-ovn-serial 873df73a021b89fa0ca9f515369086a9fe799f60 link unknown /pj-rehearse pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.13-e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Jan 6, 2023

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Jan 6, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 6, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2023
@jluhrsen
Copy link
Contributor Author

@odvarkadaniel , can you PTAL at this?

this will fix some flakes that are checking that the job name
contains the string of the underlying CNI, which is ovn
by default in 4.12+

found with this one-liner:
❯ w3m -dump -cols 200
"https://search.ci.openshift.org/?maxAge=96h&type=junit&search=job+name.*does+not+have+network+type+in+name.*expected.*ovn"
| sed -n 's/^\([^ ]*\) .*failures match.*/\1/p' | sort | rg
cluster-control-plane-machine-set-operator

pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-serial
pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-upgrade
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-serial
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-upgrade

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jluhrsen

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, jluhrsen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2023
@openshift-merge-robot openshift-merge-robot merged commit d388b41 into openshift:master Jan 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2023

@jluhrsen: Updated the following 8 configmaps:

  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-control-plane-machine-set-operator-release-4.13.yaml using file ci-operator/config/openshift/cluster-control-plane-machine-set-operator/openshift-cluster-control-plane-machine-set-operator-release-4.13.yaml
  • ci-operator-4.14-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-control-plane-machine-set-operator-release-4.14.yaml using file ci-operator/config/openshift/cluster-control-plane-machine-set-operator/openshift-cluster-control-plane-machine-set-operator-release-4.14.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-control-plane-machine-set-operator-main-presubmits.yaml using file ci-operator/jobs/openshift/cluster-control-plane-machine-set-operator/openshift-cluster-control-plane-machine-set-operator-main-presubmits.yaml
  • job-config-4.12 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-control-plane-machine-set-operator-release-4.12-presubmits.yaml using file ci-operator/jobs/openshift/cluster-control-plane-machine-set-operator/openshift-cluster-control-plane-machine-set-operator-release-4.12-presubmits.yaml
  • job-config-4.13 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-control-plane-machine-set-operator-release-4.13-presubmits.yaml using file ci-operator/jobs/openshift/cluster-control-plane-machine-set-operator/openshift-cluster-control-plane-machine-set-operator-release-4.13-presubmits.yaml
  • job-config-4.14 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-control-plane-machine-set-operator-release-4.14-presubmits.yaml using file ci-operator/jobs/openshift/cluster-control-plane-machine-set-operator/openshift-cluster-control-plane-machine-set-operator-release-4.14-presubmits.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-control-plane-machine-set-operator-main.yaml using file ci-operator/config/openshift/cluster-control-plane-machine-set-operator/openshift-cluster-control-plane-machine-set-operator-main.yaml
  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-control-plane-machine-set-operator-release-4.12.yaml using file ci-operator/config/openshift/cluster-control-plane-machine-set-operator/openshift-cluster-control-plane-machine-set-operator-release-4.12.yaml

In response to this:

this will fix some flakes that are checking that the job name contains the string of the underlying CNI, which is ovn by default in 4.12+

found with this one-liner:
❯ w3m -dump -cols 200
"https://search.ci.openshift.org/?maxAge=96h&type=junit&search=job+name.*does+not+have+network+type+in+name.*expected.*ovn" | sed -n 's/^([^ ]*) .failures match./\1/p' | sort | rg cluster-control-plane-machine-set-operator

pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-serial pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-upgrade pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-serial pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-upgrade

Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gpuckett-redhat pushed a commit to gpuckett-redhat/release that referenced this pull request Jan 26, 2023
)

this will fix some flakes that are checking that the job name
contains the string of the underlying CNI, which is ovn
by default in 4.12+

found with this one-liner:
❯ w3m -dump -cols 200
"https://search.ci.openshift.org/?maxAge=96h&type=junit&search=job+name.*does+not+have+network+type+in+name.*expected.*ovn"
| sed -n 's/^\([^ ]*\) .*failures match.*/\1/p' | sort | rg
cluster-control-plane-machine-set-operator

pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-serial
pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-upgrade
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-serial
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-upgrade

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen jluhrsen deleted the ovn-4-ccpmso branch May 3, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants