New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add -ovn- to cluster-control-plane-machine-set-operator #35181
Conversation
/pj-rehearse |
@jluhrsen: the following rehearsable tests have been affected by this change:
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
@jluhrsen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/pj-rehearse ack |
873df73
to
019cabb
Compare
@odvarkadaniel , can you PTAL at this? |
this will fix some flakes that are checking that the job name contains the string of the underlying CNI, which is ovn by default in 4.12+ found with this one-liner: ❯ w3m -dump -cols 200 "https://search.ci.openshift.org/?maxAge=96h&type=junit&search=job+name.*does+not+have+network+type+in+name.*expected.*ovn" | sed -n 's/^\([^ ]*\) .*failures match.*/\1/p' | sort | rg cluster-control-plane-machine-set-operator pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-serial pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-upgrade pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-serial pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-upgrade Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
019cabb
to
d55ab9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jluhrsen
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo, jluhrsen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jluhrsen: Updated the following 8 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
) this will fix some flakes that are checking that the job name contains the string of the underlying CNI, which is ovn by default in 4.12+ found with this one-liner: ❯ w3m -dump -cols 200 "https://search.ci.openshift.org/?maxAge=96h&type=junit&search=job+name.*does+not+have+network+type+in+name.*expected.*ovn" | sed -n 's/^\([^ ]*\) .*failures match.*/\1/p' | sort | rg cluster-control-plane-machine-set-operator pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-serial pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-upgrade pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-serial pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-upgrade Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com> Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
this will fix some flakes that are checking that the job name contains the string of the underlying CNI, which is ovn by default in 4.12+
found with this one-liner:
❯ w3m -dump -cols 200
"https://search.ci.openshift.org/?maxAge=96h&type=junit&search=job+name.*does+not+have+network+type+in+name.*expected.*ovn" | sed -n 's/^([^ ]*) .failures match./\1/p' | sort | rg cluster-control-plane-machine-set-operator
pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-serial pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-upgrade pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-serial pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-upgrade
Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com