Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openstack: Fail the job if destroy cluster fails #3527

Merged
merged 1 commit into from
Apr 26, 2019
Merged

openstack: Fail the job if destroy cluster fails #3527

merged 1 commit into from
Apr 26, 2019

Conversation

trown
Copy link

@trown trown commented Apr 18, 2019

We do not want to merge code that breaks destroy. As such,
check the exit code from destroy cluster, and fail the job if it
is nozero.

openstack: Fail the job if cluster delete fails
aaa22f1 
We do not want to merge code that breaks cluster delete. As such,
check the exit code from cluster delete, and fail the job if it
is nozero.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2019
@trown
Copy link
Author

trown commented Apr 18, 2019

/retest

1 similar comment
@trown
Copy link
Author

trown commented Apr 18, 2019

/retest

@tomassedovic
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2019
@tomassedovic
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomassedovic, trown

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2019
@openshift-merge-robot openshift-merge-robot merged commit 7557a2a into openshift:master Apr 26, 2019
@openshift-ci-robot
Copy link
Contributor

@trown: Updated the following 2 configmaps:

  • prow-job-cluster-launch-installer-openstack-e2e configmap in namespace ci using the following files:
    • key cluster-launch-installer-openstack-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-openstack-e2e.yaml
  • prow-job-cluster-launch-installer-openstack-e2e configmap in namespace ci-stg using the following files:
    • key cluster-launch-installer-openstack-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-openstack-e2e.yaml

In response to this:

We do not want to merge code that breaks destroy. As such,
check the exit code from destroy cluster, and fail the job if it
is nozero.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaper87 flaper87 Awaiting requested review from flaper87

@russellb russellb Awaiting requested review from russellb

Assignees

@tomassedovic tomassedovic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@trown @tomassedovic @openshift-ci-robot @openshift-merge-robot