Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPCLOUD-1737: cluster-control-plane-machine-set: configure presubmits and periodics for 4.12/4.13 #35325

Merged
merged 3 commits into from
Jan 17, 2023
Merged

OCPCLOUD-1737: cluster-control-plane-machine-set: configure presubmits and periodics for 4.12/4.13 #35325

merged 3 commits into from
Jan 17, 2023

Conversation

damdo
Copy link
Member

@damdo damdo commented Jan 12, 2023 •
edited

This PR configures:

  • e2e presubmits 4.12
  • e2e periodics for 4.12 and 4.13

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@openshift-ci-robot
Copy link
Contributor

@damdo: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-periodic-pre openshift/cluster-control-plane-machine-set-operator presubmit Presubmit changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-ovn openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-ovn-etcd-scaling openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-serial openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-upgrade openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-azure-ovn-etcd-scaling openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-gcp-ovn-etcd-scaling openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-vsphere-ovn-etcd-scaling openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-fmt openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-generate openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-images openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-lint openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-unit openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-vendor openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-vet openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.13-e2e-azure-periodic N/A periodic Periodic changed
periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-arm-periodic N/A periodic Periodic changed
periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.13-e2e-aws-arm-periodic N/A periodic Periodic changed
periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.12-e2e-aws-periodic N/A periodic Periodic changed
periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.13-e2e-gcp-periodic N/A periodic Periodic changed
periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.13-e2e-aws-periodic N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@damdo damdo force-pushed the cluster-control-plane-machine-set-enable-periodics branch from 550f3c9 to 3c9a47d Compare January 17, 2023 11:09
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023
@damdo damdo force-pushed the cluster-control-plane-machine-set-enable-periodics branch from 3c9a47d to 10f97ba Compare January 17, 2023 11:15
@damdo damdo changed the title OCPCLOUD-1737: cluster-control-plane-machine-set: configure periodics to be release informing OCPCLOUD-1737: cluster-control-plane-machine-set: configure presubmits and periodics for 4.12/4.13 Jan 17, 2023
@damdo damdo force-pushed the cluster-control-plane-machine-set-enable-periodics branch from 10f97ba to e708b9a Compare January 17, 2023 11:30
@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo damdo marked this pull request as ready for review January 17, 2023 11:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2023
@JoelSpeed
Copy link
Contributor

/pj-rehearse ack

We know these tests will fail initially, but we want to be able to test the E2E backport, so need to have this merged before the E2Es merge

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2023

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0d87631 into openshift:master Jan 17, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2023

@damdo: Updated the following 4 configmaps:

  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-control-plane-machine-set-operator-release-4.12.yaml using file ci-operator/config/openshift/cluster-control-plane-machine-set-operator/openshift-cluster-control-plane-machine-set-operator-release-4.12.yaml
  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-control-plane-machine-set-operator-release-4.13.yaml using file ci-operator/config/openshift/cluster-control-plane-machine-set-operator/openshift-cluster-control-plane-machine-set-operator-release-4.13.yaml
  • job-config-4.12 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-control-plane-machine-set-operator-release-4.12-periodics.yaml using file ci-operator/jobs/openshift/cluster-control-plane-machine-set-operator/openshift-cluster-control-plane-machine-set-operator-release-4.12-periodics.yaml
    • key openshift-cluster-control-plane-machine-set-operator-release-4.12-presubmits.yaml using file ci-operator/jobs/openshift/cluster-control-plane-machine-set-operator/openshift-cluster-control-plane-machine-set-operator-release-4.12-presubmits.yaml
  • job-config-4.13 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-control-plane-machine-set-operator-release-4.13-periodics.yaml using file ci-operator/jobs/openshift/cluster-control-plane-machine-set-operator/openshift-cluster-control-plane-machine-set-operator-release-4.13-periodics.yaml

In response to this:

This PR configures:

  • e2e presubmits 4.12
  • e2e periodics for 4.12 and 4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@Fedosin Fedosin Awaiting requested review from Fedosin

@odvarkadaniel odvarkadaniel Awaiting requested review from odvarkadaniel

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
4 participants
@damdo @openshift-ci-robot @JoelSpeed @openshift-merge-robot