-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shiftstack/periodic/az: skip LB tests #35699
shiftstack/periodic/az: skip LB tests #35699
Conversation
@EmilienM: the
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.12-e2e-openstack-az periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az |
@EmilienM should the test be skipped if there is no floating ip network configured? |
@@ -87,6 +87,7 @@ tests: | |||
steps: | |||
cluster_profile: openstack-vh-mecha-az0 | |||
env: | |||
OPENSTACK_TEST_SKIPS: Amphora |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amphora is not the correct keyword IMO, on the disconnected envs these tests will fail with OVN too [1]. Now using "OVN" as a keyword is probably too broad. I'd consider using this instead [2].
[1] https://github.com/openshift/openstack-test/blob/4b44bac5b9c49948a640eb783ed1eedc2384852d/test/extended/openstack/loadbalancers.go#L81
[2] https://github.com/openshift/openstack-test/blob/4b44bac5b9c49948a640eb783ed1eedc2384852d/test/extended/openstack/loadbalancers.go#L37
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openstack][lb]
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would work for me.
ad0e961
to
52e01d6
Compare
/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.12-e2e-openstack-az periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az |
52e01d6
to
4e77e09
Compare
/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.12-e2e-openstack-az periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az |
/lgtm |
4e77e09
to
b29cda5
Compare
/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.12-e2e-openstack-az periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az |
Skip the LB tests in AZ job because of OSASINFRA-3079.
b29cda5
to
139dc98
Compare
/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.12-e2e-openstack-az periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az |
It worked! Tests were skipped. @dulek please review again. Thanks |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a task to revert this commit once OSASINFRA-3079 is fixed?
LGTM otherwise.
I added it to the task itself. I don't think we need a Jira card for this PR. However https://issues.redhat.com/browse/OSASINFRA-3079 is for fixing the tests & revert this PR. Is that ok? |
/pj-rehearse ack |
@EmilienM: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/pj-rehearse skip |
@EmilienM: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Skip the Amphora tests in AZ job because of OSASINFRA-3079.