Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shiftstack/periodic/az: skip LB tests #35699

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

EmilienM
Copy link
Member

@EmilienM EmilienM commented Jan 25, 2023

Skip the Amphora tests in AZ job because of OSASINFRA-3079.

@openshift-ci-robot
Copy link
Contributor

@EmilienM: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.12-e2e-openstack-az N/A periodic Ci-operator config changed
periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2023
@EmilienM
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.12-e2e-openstack-az periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az

@MaysaMacedo
Copy link
Contributor

@EmilienM should the test be skipped if there is no floating ip network configured?
are the tests failure related to the PR changes?

@@ -87,6 +87,7 @@ tests:
steps:
cluster_profile: openstack-vh-mecha-az0
env:
OPENSTACK_TEST_SKIPS: Amphora
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amphora is not the correct keyword IMO, on the disconnected envs these tests will fail with OVN too [1]. Now using "OVN" as a keyword is probably too broad. I'd consider using this instead [2].

[1] https://github.com/openshift/openstack-test/blob/4b44bac5b9c49948a640eb783ed1eedc2384852d/test/extended/openstack/loadbalancers.go#L81
[2] https://github.com/openshift/openstack-test/blob/4b44bac5b9c49948a640eb783ed1eedc2384852d/test/extended/openstack/loadbalancers.go#L37

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openstack][lb] ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would work for me.

@EmilienM
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.12-e2e-openstack-az periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az

@EmilienM
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.12-e2e-openstack-az periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az

@dulek
Copy link
Contributor

dulek commented Jan 26, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023
@EmilienM
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.12-e2e-openstack-az periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2023
Skip the LB tests in AZ job because of OSASINFRA-3079.
@EmilienM
Copy link
Member Author

/pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.12-e2e-openstack-az periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az

@EmilienM
Copy link
Member Author

It worked! Tests were skipped.

@dulek please review again. Thanks

@dulek
Copy link
Contributor

dulek commented Jan 27, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a task to revert this commit once OSASINFRA-3079 is fixed?
LGTM otherwise.

@EmilienM
Copy link
Member Author

Can we have a task to revert this commit once OSASINFRA-3079 is fixed? LGTM otherwise.

I added it to the task itself. I don't think we need a Jira card for this PR. However https://issues.redhat.com/browse/OSASINFRA-3079 is for fixing the tests & revert this PR. Is that ok?

@EmilienM
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.12-e2e-openstack-az 139dc98 link unknown /pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.12-e2e-openstack-az
ci/rehearse/periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az 139dc98 link unknown /pj-rehearse periodic-ci-shiftstack-shiftstack-ci-main-periodic-4.13-e2e-openstack-az

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EmilienM
Copy link
Member Author

/pj-rehearse skip

@openshift-merge-robot openshift-merge-robot merged commit 5d719ef into openshift:master Jan 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023

@EmilienM: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key shiftstack-shiftstack-ci-main__periodic-4.12.yaml using file ci-operator/config/shiftstack/shiftstack-ci/shiftstack-shiftstack-ci-main__periodic-4.12.yaml
  • key shiftstack-shiftstack-ci-main__periodic-4.13.yaml using file ci-operator/config/shiftstack/shiftstack-ci/shiftstack-shiftstack-ci-main__periodic-4.13.yaml

In response to this:

Skip the Amphora tests in AZ job because of OSASINFRA-3079.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM EmilienM deleted the osp-az-skip-lb branch January 27, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
6 participants