-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix makefile compatibility with podman for mac #35997
Fix makefile compatibility with podman for mac #35997
Conversation
@cblecker: no rehearsable tests are affected by this change |
I would create two commits in this PR: one for |
fca0015
to
d0e1ee8
Compare
@danilo-gemoli Updated per your suggestions |
d0e1ee8
to
48f0282
Compare
48f0282
to
ca559f1
Compare
/lgtm |
@cblecker: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bbguimaraes, cblecker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Seting the SELinux mount label when running on podman for macOS make the run fails with an error. So we don't set it. Similar to openshift/release#35997
containers/podman#13631 (comment)
We don't want/need to set the SELinux mount label when running on podman for macOS. Also, when we pull images, make sure we pull them for linux/amd64