Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix makefile compatibility with podman for mac #35997

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented Feb 3, 2023

containers/podman#13631 (comment)

We don't want/need to set the SELinux mount label when running on podman for macOS. Also, when we pull images, make sure we pull them for linux/amd64

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 3, 2023
@openshift-ci-robot
Copy link
Contributor

@cblecker: no rehearsable tests are affected by this change

Makefile Outdated Show resolved Hide resolved
@danilo-gemoli
Copy link
Contributor

I would create two commits in this PR: one for --platform linux/amd64 and the other for :z

@cblecker
Copy link
Member Author

cblecker commented Feb 3, 2023

@danilo-gemoli Updated per your suggestions

@bbguimaraes
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023

@cblecker: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit d52a664 into openshift:master Feb 7, 2023
@cblecker cblecker deleted the make-podman-mac branch February 7, 2023 16:13
andreadecorte added a commit to andreadecorte/managed-cluster-config that referenced this pull request Nov 23, 2023
Seting the SELinux mount label when running on podman for macOS make the run fails with an error.
So we don't set it.
Similar to openshift/release#35997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
5 participants