Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable p & z assisted installer builds #36060

Merged
merged 14 commits into from Feb 28, 2023
Merged

enable p & z assisted installer builds #36060

merged 14 commits into from Feb 28, 2023

Conversation

jacobemery
Copy link
Contributor

Add Power (ppc64le) and Z (s390x) to enable the Assisted Installer to deploy OCP onto these architectures.

The following Assisted Installer components are required to run on the target architecture and are built using the scripts changed in this PR:

  • assisted-installer
  • assisted-installer-controller
  • assisted-installer-agent

Strategy: OCPPLAN-8327
Epic: MULTIARCH-2889
Sub-task: MGMT-13560

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2023

Hi @jacobemery. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jacobemery
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 6, 2023
@openshift-ci-robot
Copy link
Contributor

@jacobemery: no rehearsable tests are affected by this change

@jacobemery
Merge branch 'openshift:master' into p/z-enablement
a21ca3f
@jacobemery
Change to presubmit
f8a5400 
Change publish-multi-arch-images postsubmit boolean to false so that CI infrastructure tests are rehearsed.

Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Copy link
Contributor Author

/pj-rehearse

@jacobemery
Copy link
Contributor Author

/pj-rehearse

@jacobemery
Copy link
Contributor Author

jacobemery commented Feb 9, 2023 •
edited

@droslean @smg247 I believe this is ready to test, could one of you confirm?

Context: https://issues.redhat.com/browse/MGMT-13560

@osherdp
Copy link
Contributor

osherdp commented Feb 12, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 12, 2023
@osherdp
Copy link
Contributor

osherdp commented Feb 12, 2023

@droslean @smg247 I believe this is ready to test, could one of you confirm?

Context: https://issues.redhat.com/browse/MGMT-13560

no, their not required for the review. prow sometimes assigns people from admins of the CI system
/uncc droslean smg247
/cc @osherdp @ori-amizur

@openshift-ci openshift-ci bot requested review from ori-amizur and osherdp and removed request for smg247 and droslean February 12, 2023 07:41
osherdp
osherdp suggested changes Feb 12, 2023
View reviewed changes
...nfig/openshift/assisted-installer-agent/openshift-assisted-installer-agent-master__edge.yaml Outdated
@@ -74,7 +74,7 @@ test_binary_build_commands: |
mkdir /.cache && chmod 775 -R /.cache ${GOPATH}
tests:
- as: publish-multi-arch-images
postsubmit: true
postsubmit: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be aware those are temporary changes just to enable testing in this PR. so it should not be merged

ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-master__edge.yaml Outdated
@@ -73,7 +73,7 @@ test_binary_build_commands: |
tests:
- as: publish-multi-arch-images
cluster: build03
postsubmit: true
postsubmit: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@osherdp
Copy link
Contributor

osherdp commented Feb 12, 2023

/hold (to make sure temporary changes don't get in by mistake)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2023
@osherdp
Copy link
Contributor

osherdp commented Feb 12, 2023

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@osherdp: no rehearsable tests are affected by this change

@osherdp
Copy link
Contributor

osherdp commented Feb 12, 2023

@jacobemery you may need to do make update and push the changes so it can auto-generate job definition changes

@jacobemery
Copy link
Contributor Author

jacobemery commented Feb 27, 2023 •
edited

do make update and push the changes so it can auto-generate job definition changes

Done! @osherdp

@mkumatag

@jacobemery
Copy link
Contributor Author

@ori-amizur @osherdp Looks like all tests passed!

@osherdp
Copy link
Contributor

osherdp commented Feb 27, 2023

/pj-rehearse

@osherdp
Copy link
Contributor

osherdp commented Feb 27, 2023

@ori-amizur @osherdp Looks like all tests passed!

it shouldn't really, and you can see the rehearses fail because quay.io/centos/centos:stream8 doesn't support s390x
now let's try to only add ppc64le and make sure the rehearse jobs are passing. afterwards we can revert the jobs types back from presubmit to postsubmit (and regenerate the code using make update)

@jacobemery
Merge branch 'openshift:master' into p/z-enablement
cdf6f0d
@jacobemery
remove s390x
690ad52 
Because s390x is not available for CentOS Stream 8, s390x must be removed upstream for now.

https://issues.redhat.com/browse/MGMT-13814

Signed-off-by: Jacob Emery <jacob.emery@ibm.com>
@jacobemery
Copy link
Contributor Author

it shouldn't really, and you can see the rehearses fail because quay.io/centos/centos:stream8 doesn't support s390x now let's try to only add ppc64le

Ah, you're right... Done ^

@jacobemery
Copy link
Contributor Author

/pj-rehearse

@jacobemery
Copy link
Contributor Author

make sure the rehearse jobs are passing. afterwards we can revert the jobs types back from presubmit to postsubmit (and regenerate the code using make update)

@osherdp Looks like rehearse tests passed, good to do the above now?

@osherdp
Copy link
Contributor

osherdp commented Feb 28, 2023

make sure the rehearse jobs are passing. afterwards we can revert the jobs types back from presubmit to postsubmit (and regenerate the code using make update)

@osherdp Looks like rehearse tests passed, good to do the above now?

Yes, good to go!

@jacobemery
Copy link
Contributor Author

Yes, good to go!

Done!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@jacobemery: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@osherdp
Copy link
Contributor

osherdp commented Feb 28, 2023

/unhold
/pj-rehearse ack

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobemery, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@openshift-merge-robot openshift-merge-robot merged commit a6e57ff into openshift:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osherdp osherdp osherdp approved these changes

@ori-amizur ori-amizur Awaiting requested review from ori-amizur

Assignees

@osherdp osherdp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
4 participants
@jacobemery @openshift-ci-robot @osherdp @openshift-merge-robot