Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cert-Manager: Use stable channel for openshifit/cert-manager-operator e2e #36256

Merged

Conversation

swghosh
Copy link
Member

@swghosh swghosh commented Feb 10, 2023

Change the env var OO_CHANNEL for openshift/cert-manager-operator e2e-operator test.

Signed-off-by: Swarup Ghosh swghosh@redhat.com

Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@swghosh
Copy link
Member Author

swghosh commented Feb 10, 2023

/cc @thejasn

@openshift-ci openshift-ci bot requested a review from thejasn February 10, 2023 11:02
@openshift-ci-robot
Copy link
Contributor

@swghosh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cert-manager-operator-master-e2e-operator openshift/cert-manager-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested a review from stlaz February 10, 2023 11:02
@thejasn
Copy link
Contributor

thejasn commented Feb 10, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 10, 2023
@swghosh swghosh changed the title Use stable channel for openshifit/cert-manager-operator e2e Cert-Manager: Use stable channel for openshifit/cert-manager-operator e2e Feb 10, 2023
@swghosh swghosh changed the title Cert-Manager: Use stable channel for openshifit/cert-manager-operator e2e CFE-694: Cert-Manager: Use stable channel for openshifit/cert-manager-operator e2e Feb 10, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 10, 2023

@swghosh: This pull request references CFE-694 which is a valid jira issue.

In response to this:

Change the env var OO_CHANNEL for openshift/cert-manager-operator e2e-operator test.

Signed-off-by: Swarup Ghosh swghosh@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 10, 2023
@swghosh swghosh changed the title CFE-694: Cert-Manager: Use stable channel for openshifit/cert-manager-operator e2e Cert-Manager: Use stable channel for openshifit/cert-manager-operator e2e Feb 10, 2023
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 10, 2023
@openshift-ci-robot
Copy link
Contributor

@swghosh: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Change the env var OO_CHANNEL for openshift/cert-manager-operator e2e-operator test.

Signed-off-by: Swarup Ghosh swghosh@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thejasn
Copy link
Contributor

thejasn commented Feb 13, 2023

/lgtm

@thejasn
Copy link
Contributor

thejasn commented Feb 13, 2023

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swghosh, thejasn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

@swghosh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 681f9cf into openshift:master Feb 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2023

@swghosh: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-cert-manager-operator-master.yaml using file ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master.yaml

In response to this:

Change the env var OO_CHANNEL for openshift/cert-manager-operator e2e-operator test.

Signed-off-by: Swarup Ghosh swghosh@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants