Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Go 1.19 builders for the Submariner addon #36750

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

skitt
Copy link
Member

@skitt skitt commented Feb 27, 2023

No description provided.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@skitt: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-submariner-addon-release-2.8-build stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.8-images stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.8-integration stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.8-sonarcloud stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.8-unit stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.8-verify stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.3-build stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.3-images stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.3-integration stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.3-sonarcloud stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.3-unit stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.3-verify stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.3-verify-deps stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-main-build stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-main-golangci-lint stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-main-images stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-main-integration stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-main-sonarcloud stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-main-unit stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-main-verify stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.7-build stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.7-images stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.7-integration stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.7-sonarcloud stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.7-unit stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.7-verify stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.5-build stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.5-images stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.5-integration stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.5-sonarcloud stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.5-unit stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.5-verify stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.5-verify-deps stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.6-build stolostron/submariner-addon presubmit Ci-operator config changed
pull-ci-stolostron-submariner-addon-release-2.6-images stolostron/submariner-addon presubmit Ci-operator config changed

A total of 47 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@skitt
Copy link
Member Author

skitt commented Feb 27, 2023

/pj-rehearse pull-ci-stolostron-submariner-addon-main-build
/pj-rehearse pull-ci-stolostron-submariner-addon-main-images
/pj-rehearse pull-ci-stolostron-submariner-addon-main-integration
/pj-rehearse pull-ci-stolostron-submariner-addon-main-unit
/pj-rehearse pull-ci-stolostron-submariner-addon-main-verify
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.3-build
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.3-images
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.3-integration
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.3-unit
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.3-verify
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.4-build
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.4-images
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.4-integration
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.4-unit
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.4-verify
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.5-build
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.5-images
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.5-integration
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.5-unit
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.5-verify
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.6-build
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.6-images
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.6-integration
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.6-unit
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.6-verify
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.7-build
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.7-images
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.7-integration
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.7-unit
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.7-verify
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.8-build
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.8-images
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.8-integration
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.8-unit
/pj-rehearse pull-ci-stolostron-submariner-addon-release-2.8-verify

@skitt
Copy link
Member Author

skitt commented Feb 27, 2023

/pj-rehearse pull-ci-stolostron-submariner-addon-main-images pull-ci-stolostron-submariner-addon-main-integration pull-ci-stolostron-submariner-addon-main-unit pull-ci-stolostron-submariner-addon-main-verify pull-ci-stolostron-submariner-addon-release-2.3-build pull-ci-stolostron-submariner-addon-release-2.3-images pull-ci-stolostron-submariner-addon-release-2.3-integration pull-ci-stolostron-submariner-addon-release-2.3-unit pull-ci-stolostron-submariner-addon-release-2.3-verify pull-ci-stolostron-submariner-addon-release-2.4-build pull-ci-stolostron-submariner-addon-release-2.4-images pull-ci-stolostron-submariner-addon-release-2.4-integration pull-ci-stolostron-submariner-addon-release-2.4-unit pull-ci-stolostron-submariner-addon-release-2.4-verify pull-ci-stolostron-submariner-addon-release-2.5-build pull-ci-stolostron-submariner-addon-release-2.5-images pull-ci-stolostron-submariner-addon-release-2.5-integration pull-ci-stolostron-submariner-addon-release-2.5-unit pull-ci-stolostron-submariner-addon-release-2.5-verify pull-ci-stolostron-submariner-addon-release-2.6-build pull-ci-stolostron-submariner-addon-release-2.6-images pull-ci-stolostron-submariner-addon-release-2.6-integration pull-ci-stolostron-submariner-addon-release-2.6-unit pull-ci-stolostron-submariner-addon-release-2.6-verify pull-ci-stolostron-submariner-addon-release-2.7-build pull-ci-stolostron-submariner-addon-release-2.7-images pull-ci-stolostron-submariner-addon-release-2.7-integration pull-ci-stolostron-submariner-addon-release-2.7-unit pull-ci-stolostron-submariner-addon-release-2.7-verify pull-ci-stolostron-submariner-addon-release-2.8-build pull-ci-stolostron-submariner-addon-release-2.8-images pull-ci-stolostron-submariner-addon-release-2.8-integration pull-ci-stolostron-submariner-addon-release-2.8-unit pull-ci-stolostron-submariner-addon-release-2.8-verify

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2023

@skitt: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/stolostron/submariner-addon/release-2.4/verify cebd24d link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.4-verify
ci/rehearse/stolostron/submariner-addon/release-2.5/verify cebd24d link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.5-verify
ci/rehearse/stolostron/submariner-addon/main/verify cebd24d link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-main-verify
ci/rehearse/stolostron/submariner-addon/release-2.7/verify cebd24d link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.7-verify
ci/rehearse/stolostron/submariner-addon/release-2.3/verify cebd24d link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.3-verify
ci/rehearse/stolostron/submariner-addon/release-2.8/verify cebd24d link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.8-verify
ci/rehearse/stolostron/submariner-addon/release-2.6/verify cebd24d link unknown /pj-rehearse pull-ci-stolostron-submariner-addon-release-2.6-verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@skitt
Copy link
Member Author

skitt commented Feb 27, 2023

/pj-rehearse ack

The verify jobs are failing because formatting changed in Go 1.19. We’ll need to fix the branches up after this is merged, we can’t handle it ahead of time.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 27, 2023
@skitt
Copy link
Member Author

skitt commented Feb 27, 2023

/cc @sridhargaddam @tpantelis

@sridhargaddam
Copy link

/cc @sridhargaddam @tpantelis

Jobs are failing, but we trust you'll fix it in follow up PRs 👍

@sridhargaddam
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@sridhargaddam
Copy link

/approve

@tpantelis
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skitt, sridhargaddam, tpantelis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

@skitt: Updated the following 4 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key stolostron-submariner-addon-main.yaml using file ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-main.yaml
  • ci-operator-2.x-configs configmap in namespace ci at cluster app.ci using the following files:
    • key stolostron-submariner-addon-release-2.3.yaml using file ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.3.yaml
    • key stolostron-submariner-addon-release-2.4.yaml using file ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.4.yaml
    • key stolostron-submariner-addon-release-2.5.yaml using file ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.5.yaml
    • key stolostron-submariner-addon-release-2.6.yaml using file ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.6.yaml
    • key stolostron-submariner-addon-release-2.7.yaml using file ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.7.yaml
    • key stolostron-submariner-addon-release-2.8.yaml using file ci-operator/config/stolostron/submariner-addon/stolostron-submariner-addon-release-2.8.yaml
  • job-config-master-postsubmits configmap in namespace ci at cluster app.ci using the following files:
    • key stolostron-submariner-addon-main-postsubmits.yaml using file ci-operator/jobs/stolostron/submariner-addon/stolostron-submariner-addon-main-postsubmits.yaml
  • job-config-2.x configmap in namespace ci at cluster app.ci using the following files:
    • key stolostron-submariner-addon-release-2.2-postsubmits.yaml using file ci-operator/jobs/stolostron/submariner-addon/stolostron-submariner-addon-release-2.2-postsubmits.yaml
    • key stolostron-submariner-addon-release-2.3-postsubmits.yaml using file ci-operator/jobs/stolostron/submariner-addon/stolostron-submariner-addon-release-2.3-postsubmits.yaml
    • key stolostron-submariner-addon-release-2.4-postsubmits.yaml using file ci-operator/jobs/stolostron/submariner-addon/stolostron-submariner-addon-release-2.4-postsubmits.yaml
    • key stolostron-submariner-addon-release-2.5-postsubmits.yaml using file ci-operator/jobs/stolostron/submariner-addon/stolostron-submariner-addon-release-2.5-postsubmits.yaml
    • key stolostron-submariner-addon-release-2.6-postsubmits.yaml using file ci-operator/jobs/stolostron/submariner-addon/stolostron-submariner-addon-release-2.6-postsubmits.yaml
    • key stolostron-submariner-addon-release-2.7-postsubmits.yaml using file ci-operator/jobs/stolostron/submariner-addon/stolostron-submariner-addon-release-2.7-postsubmits.yaml
    • key stolostron-submariner-addon-release-2.8-postsubmits.yaml using file ci-operator/jobs/stolostron/submariner-addon/stolostron-submariner-addon-release-2.8-postsubmits.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skitt skitt deleted the submariner-go1.19 branch February 28, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
5 participants