Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new job to expand clusterNetwork CIDR #36775

Merged

Conversation

jluhrsen
Copy link
Contributor

No description provided.

@jluhrsen
Copy link
Contributor Author

/hold
/pj-rehearse

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2023
@openshift-ci openshift-ci bot requested review from abhat and dcbw February 28, 2023 00:46
@jluhrsen
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jluhrsen: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.14-e2e-aws-ovn-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.13-e2e-aws-ovn-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.12-e2e-aws-ovn-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.11-e2e-aws-ovn-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.10-e2e-aws-ovn-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.9-e2e-aws-ovn-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-aws-ovn-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.7-e2e-aws-ovn-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.6-e2e-aws-ovn-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-master-e2e-vsphere-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.14-e2e-vsphere-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.13-e2e-vsphere-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.12-e2e-vsphere-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.11-e2e-vsphere-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.10-e2e-vsphere-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.9-e2e-vsphere-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-vsphere-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.7-e2e-vsphere-windows openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.1-e2e-aws openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-local-gateway openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.14-e2e-aws-ovn-local-gateway openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.14-e2e-aws-ovn openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.13-e2e-aws-ovn-local-gateway openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.13-e2e-aws-ovn openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.12-e2e-aws-ovn-local-gateway openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.12-e2e-aws-ovn openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.11-e2e-aws-ovn-local-gateway openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.11-e2e-aws-ovn openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.10-e2e-aws-ovn-local-gateway openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.10-e2e-aws-ovn openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.9-e2e-aws-ovn-local-gateway openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.9-e2e-aws-ovn openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.8-e2e-aws-ovn-local-gateway openshift/ovn-kubernetes presubmit Registry content changed

A total of 9779 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jluhrsen
Copy link
Contributor Author

/pj-rehearse

@jluhrsen
Copy link
Contributor Author

@openshift-ci-robot
Copy link
Contributor

@jluhrsen, pj-rehearse: failed to create rehearsal jobs ERROR: 'failed to ensure imagestreamtags in cluster build03: failed waiting for imagestreamtag openshift/knative-v0.26.0:knative-eventing-src to appear: timed out waiting for the condition'. If the problem persists, please contact Test Platform.

@openshift-ci-robot
Copy link
Contributor

@jluhrsen, pj-rehearse: failed to create rehearsal jobs ERROR: 'failed to ensure imagestreamtags in cluster build03: failed waiting for imagestreamtag openshift/knative-v0.14.1:knative-serving-src to appear: timed out waiting for the condition'. If the problem persists, please contact Test Platform.

@openshift-ci-robot
Copy link
Contributor

@jluhrsen, pj-rehearse: failed to create rehearsal jobs ERROR: 'failed to ensure imagestreamtags in cluster build01: failed waiting for imagestreamtag openshift/knative-v0.20.0:knative-eventing-src to appear: timed out waiting for the condition'. If the problem persists, please contact Test Platform.

@jluhrsen
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jluhrsen, pj-rehearse: failed to create rehearsal jobs ERROR: 'failed to ensure imagestreamtags in cluster build01: failed waiting for imagestreamtag openshift/knative-v0.24.0:knative-eventing-src to appear: timed out waiting for the condition'. If the problem persists, please contact Test Platform.

@jluhrsen
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@jluhrsen, pj-rehearse: failed to create rehearsal jobs ERROR: 'failed to ensure imagestreamtags in cluster build01: failed waiting for imagestreamtag logging/5.1:logging-kibana6 to appear: timed out waiting for the condition'. If the problem persists, please contact Test Platform.

@jluhrsen
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-clusternetwork-cidr-expansion

@jluhrsen
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-clusternetwork-cidr-expansion

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Mar 1, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-clusternetwork-cidr-expansion

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Mar 1, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-clusternetwork-cidr-expansion

3 similar comments
@jluhrsen
Copy link
Contributor Author

jluhrsen commented Mar 2, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-clusternetwork-cidr-expansion

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Mar 2, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-clusternetwork-cidr-expansion

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Mar 2, 2023

/pj-rehearse pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-clusternetwork-cidr-expansion

Copy link

@flavio-fernandes flavio-fernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2023
@flavio-fernandes
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2023
@jluhrsen
Copy link
Contributor Author

/assign @deads2k
/assign @vrutkovs

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2023
@jluhrsen
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-cluster-network-operator-release-4.13-e2e-aws-ovn-clusternetwork-cidr-expansion

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/stolostron/rbac-query-proxy/release-2.3/test-e2e 329bcda4d0f40edd03aaff7429b6596fbad2bbd7 link unknown /pj-rehearse pull-ci-stolostron-rbac-query-proxy-release-2.3-test-e2e
ci/rehearse/redhat-developer/gitops-operator/master/v4.9-kuttl-parallel cde2041dabd361bad1b414d0c3569db3c0349f1c link unknown /pj-rehearse pull-ci-redhat-developer-gitops-operator-master-v4.9-kuttl-parallel
ci/rehearse/openshift/csi-external-provisioner/release-4.13/e2e-aws-csi 329bcda4d0f40edd03aaff7429b6596fbad2bbd7 link unknown /pj-rehearse pull-ci-openshift-csi-external-provisioner-release-4.13-e2e-aws-csi
ci/rehearse/openshift/csi-external-provisioner/release-4.14/e2e-aws-csi 329bcda4d0f40edd03aaff7429b6596fbad2bbd7 link unknown /pj-rehearse pull-ci-openshift-csi-external-provisioner-release-4.14-e2e-aws-csi
ci/rehearse/openshift/okd-machine-os/release-4.13/e2e-aws-ovn 329bcda4d0f40edd03aaff7429b6596fbad2bbd7 link unknown /pj-rehearse pull-ci-openshift-okd-machine-os-release-4.13-e2e-aws-ovn
ci/rehearse/openshift/okd-machine-os/release-4.14/e2e-aws-ovn 329bcda4d0f40edd03aaff7429b6596fbad2bbd7 link unknown /pj-rehearse pull-ci-openshift-okd-machine-os-release-4.14-e2e-aws-ovn
ci/rehearse/redhat-developer/gitops-operator/master/v4.9-kuttl-sequential cde2041dabd361bad1b414d0c3569db3c0349f1c link unknown /pj-rehearse pull-ci-redhat-developer-gitops-operator-master-v4.9-kuttl-sequential
ci/rehearse/openshift/baremetal-runtimecfg/release-4.11/e2e-openstack 4a17821019c007e1cb284afa69dbbc61a36a071e link unknown /pj-rehearse pull-ci-openshift-baremetal-runtimecfg-release-4.11-e2e-openstack
ci/rehearse/openshift/baremetal-runtimecfg/release-4.13/e2e-openstack 4a17821019c007e1cb284afa69dbbc61a36a071e link unknown /pj-rehearse pull-ci-openshift-baremetal-runtimecfg-release-4.13-e2e-openstack
ci/rehearse/openshift/baremetal-runtimecfg/master/e2e-openstack 4a17821019c007e1cb284afa69dbbc61a36a071e link unknown /pj-rehearse pull-ci-openshift-baremetal-runtimecfg-master-e2e-openstack
ci/rehearse/openshift/windows-machine-config-bootstrapper/release-4.13/e2e-wmcb 1361ac68bc03522e7fa688a9962638cf74666a79 link unknown /pj-rehearse pull-ci-openshift-windows-machine-config-bootstrapper-release-4.13-e2e-wmcb
ci/rehearse/periodic-ci-che-incubator-che-test-harness-master-performance-tests 1361ac68bc03522e7fa688a9962638cf74666a79 link unknown /pj-rehearse periodic-ci-che-incubator-che-test-harness-master-performance-tests
ci/rehearse/periodic-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-clusternetwork-cidr-expansion 484a11bb8212cac54ec87a6dfc5987fbbbe8f792 link unknown /pj-rehearse periodic-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-clusternetwork-cidr-expansion

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

- this is periodic only running on Sat/Sun/Tue/Thur 3am PST for
  4.13+
- uses custom ClusterNetwork config (not openshift default) to
  bring up a cluster with only enough IP space for 8 nodes
- scales to 9 nodes and checks that 9th node cannot join due
  to exhausted IP space
- modifies the ClusterNetwork CIDR mask so that there are now
  more IPs available
- validates that the new node is assigned a subnet and
  in ready state
- runs standard e2e tests

- Also does a small refactor of the ovn-conf-custom-cidr
  workflow to take parameters instead of hardcoded values
  allowing other workflows to use it for their own purposes.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-cluster-network-operator-release-4.13-e2e-aws-ovn-clusternetwork-cidr-expansion

1 similar comment
@jluhrsen
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-cluster-network-operator-release-4.13-e2e-aws-ovn-clusternetwork-cidr-expansion

@vrutkovs
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavio-fernandes, jluhrsen, trozet, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5b52141 into openshift:master Mar 23, 2023
21 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2023

@jluhrsen: Updated the following 6 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-network-operator-master.yaml using file ci-operator/config/openshift/cluster-network-operator/openshift-cluster-network-operator-master.yaml
  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-network-operator-release-4.13.yaml using file ci-operator/config/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.13.yaml
  • ci-operator-4.14-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-network-operator-release-4.14.yaml using file ci-operator/config/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.14.yaml
  • job-config-master-periodics configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-network-operator-master-periodics.yaml using file ci-operator/jobs/openshift/cluster-network-operator/openshift-cluster-network-operator-master-periodics.yaml
  • job-config-4.13 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-network-operator-release-4.13-periodics.yaml using file ci-operator/jobs/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.13-periodics.yaml
  • job-config-4.14 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-network-operator-release-4.14-periodics.yaml using file ci-operator/jobs/openshift/cluster-network-operator/openshift-cluster-network-operator-release-4.14-periodics.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bmanzari pushed a commit to bmanzari/release that referenced this pull request Mar 30, 2023
- this is periodic only running on Sat/Sun/Tue/Thur 3am PST for
  4.13+
- uses custom ClusterNetwork config (not openshift default) to
  bring up a cluster with only enough IP space for 8 nodes
- scales to 9 nodes and checks that 9th node cannot join due
  to exhausted IP space
- modifies the ClusterNetwork CIDR mask so that there are now
  more IPs available
- validates that the new node is assigned a subnet and
  in ready state
- runs standard e2e tests

- Also does a small refactor of the ovn-conf-custom-cidr
  workflow to take parameters instead of hardcoded values
  allowing other workflows to use it for their own purposes.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen jluhrsen deleted the allow-cidr-expansion branch April 4, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
8 participants