Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPLAT-986: vSphere multi-zone upgrade workflow #37187

Merged

Conversation

rvanderp3
Copy link
Contributor

@rvanderp3 rvanderp3 commented Mar 10, 2023

Enabling vSphere mutli-zone workload and periodic per SPLAT-730

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2023
@openshift-ci-robot
Copy link
Contributor

@rvanderp3: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-release-master-nightly-4.14-upgrade-from-stable-4.13-e2e-vsphere-ovn-zones-upgrade N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rvanderp3
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.14-upgrade-from-stable-4.13-e2e-vsphere-ovn-zones-upgrade

@rvanderp3 rvanderp3 changed the title [wip] vSphere multi-zone upgrade workflow SPLAT-986: [wip] vSphere multi-zone upgrade workflow Mar 10, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 10, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 10, 2023

@rvanderp3: This pull request references SPLAT-986 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2023
@rvanderp3 rvanderp3 changed the title SPLAT-986: [wip] vSphere multi-zone upgrade workflow SPLAT-986: vSphere multi-zone upgrade workflow Mar 10, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 10, 2023

@rvanderp3: This pull request references SPLAT-986 which is a valid jira issue.

In response to this:

Enabling vSphere mutli-zone workload and periodic per SPLAT-730

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rvanderp3
Copy link
Contributor Author

/assign @jcpowermac

@jcpowermac
Copy link
Contributor

/lgtm
/approve
/pj-reherase ack

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2023
@rvanderp3
Copy link
Contributor Author

/hold
found an issue in the rehearsal about the job name

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2023
@rvanderp3
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.14-upgrade-from-stable-4.13-e2e-vsphere-ovn-zones-upgrade

@openshift-ci-robot
Copy link
Contributor

@rvanderp3: job(s): periodic-ci-openshift-release-master-nightly-4.14-upgrade-from-stable-4.13-e2e-vsphere-ovn-zones-upgrade either don't exist or were not found to be affected, and cannot be rehearsed

@rvanderp3
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.14-upgrade-from-stable-4.13-e2e-vsphere-zones-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 12, 2023

@rvanderp3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.14-upgrade-from-stable-4.13-e2e-vsphere-ovn-zones-upgrade 4fe4848aaf876ad30c89bc65f1275e998989d4f7 link unknown /pj-rehearse periodic-ci-openshift-release-master-nightly-4.14-upgrade-from-stable-4.13-e2e-vsphere-ovn-zones-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rvanderp3
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.14-upgrade-from-stable-4.13-e2e-vsphere-zones-upgrade

@rvanderp3
Copy link
Contributor Author

/assign @wking

@jcpowermac
Copy link
Contributor

/lgtm

@jcpowermac
Copy link
Contributor

/lgtm
/approve
/pj-reherase ack

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2023
@rvanderp3
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2023
@rvanderp3
Copy link
Contributor Author

/hold cancel

@rvanderp3
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 14, 2023
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Poking at the rehearsal, I see multiple data centers in a single vCenter:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/37187/rehearse-37187-periodic-ci-openshift-release-master-nightly-4.14-upgrade-from-stable-4.13-e2e-vsphere-zones-upgrade/1635080362419818496/artifacts/e2e-vsphere-zones-upgrade/gather-must-gather/artifacts/must-gather.tar | tar xOz quay-io-openshift-release-dev-ocp-v4-0-art-dev-sha256-6d68129c33361a4dbc1831ae87d25a338cc55fb8fd9c045bab498300735f7b95/cluster-scoped-resources/config.openshift.io/infrastructures/cluster.yaml | yaml2json | jq .spec.platformSpec.vsphere.vcenters
[
  {
    "datacenters": [
      "IBMCloud",
      "datacenter-2"
    ],
    "port": 443,
    "server": "ibmvcenter.vmc-ci.devcluster.openshift.com"
  }
]

And a successful update from 4.13 to 4.14:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/37187/rehearse-37187-periodic-ci-openshift-release-master-nightly-4.14-upgrade-from-stable-4.13-e2e-vsphere-zones-upgrade/1635080362419818496/artifacts/e2e-vsphere-zones-upgrade/gather-extra/artifacts/clusterversion.json | jq -r '.items[].status.history[] | .startedTime + " " + .completionTime + " " + .state + " " + .version'
2023-03-13T01:33:54Z 2023-03-13T02:36:49Z Completed 4.14.0-0.nightly-2023-03-08-194110
2023-03-13T01:00:25Z 2023-03-13T01:21:09Z Completed 4.13.0-ec.4

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, rvanderp3, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@openshift-merge-robot openshift-merge-robot merged commit 785990c into openshift:master Mar 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

@rvanderp3: Updated the following 2 configmaps:

  • job-config-master-periodics configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-periodics.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master__nightly-4.14-upgrade-from-stable-4.13.yaml using file ci-operator/config/openshift/release/openshift-release-master__nightly-4.14-upgrade-from-stable-4.13.yaml

In response to this:

Enabling vSphere mutli-zone workload and periodic per SPLAT-730

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bmanzari pushed a commit to bmanzari/release that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
5 participants