-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netobserv clusterbot #37301
Netobserv clusterbot #37301
Conversation
@memodi: no rehearsable tests are affected by this change |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: memodi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @jotak - could you PTAL and review? I am not sure if I have everything correct in this config. |
zz_generated_metadata: | ||
branch: main | ||
org: netobserv | ||
repo: network-observability-opeator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here
From the CI errors it seems you need to run |
bin: | ||
paths: | ||
- destination_dir: . | ||
source_path: /go/bin/network-observability-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you been able to test the build or not?
I'm not sure how these configs/steps all play together, but if the build command is make build
(as shown L14) and this dockerfile uses that build output, then the source should be something like ./bin/manager
In case it is useful, here's how the build definition was done previously: https://github.com/openshift/release/pull/35766/files#diff-df4f4f7896d9a6f03e1d041f559f8d1b076995b41b84ff5853eb619950b53da3L29-L32 (see file ci-operator/config/netobserv/network-observability-operator/netobserv-network-observability-operator-main.yaml
)
As you can see we also had to override a couple of go ENV variables, but maybe this isn't useful here, as the base image used for building is different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you been able to test the build or not?
No, I have not yet, wanted to create this first draft of config and have it pass by you to resolve any evident issues as you noted.
I'm not sure how these configs/steps all play together
I can't say I know them well either, trying to go through the documentation and use references from other operator configs.
as the base image used for building is different.
do you mean 9.1
in Dockerfile vs 9
in this config?
added feedback in commit: 1284cbd
@memodi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold |
our github repos already have the openshift bots enabled |
Issues in openshift/release go stale after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issue in openshift/release rot after 15d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
NETOBSERV-872 First version prow config for network observability operator intended to be used with cluster bot.