Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netobserv clusterbot #37301

Closed
wants to merge 5 commits into from
Closed

Conversation

memodi
Copy link
Contributor

@memodi memodi commented Mar 14, 2023

NETOBSERV-872 First version prow config for network observability operator intended to be used with cluster bot.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 14, 2023
@openshift-ci-robot
Copy link
Contributor

@memodi: no rehearsable tests are affected by this change

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: memodi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@memodi
Copy link
Contributor Author

memodi commented Mar 14, 2023

/cc @jotak - could you PTAL and review? I am not sure if I have everything correct in this config.

zz_generated_metadata:
branch: main
org: netobserv
repo: network-observability-opeator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here

@jotak
Copy link
Contributor

jotak commented Mar 15, 2023

From the CI errors it seems you need to run make jobs

bin:
paths:
- destination_dir: .
source_path: /go/bin/network-observability-operator
Copy link
Contributor

@jotak jotak Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you been able to test the build or not?
I'm not sure how these configs/steps all play together, but if the build command is make build (as shown L14) and this dockerfile uses that build output, then the source should be something like ./bin/manager

In case it is useful, here's how the build definition was done previously: https://github.com/openshift/release/pull/35766/files#diff-df4f4f7896d9a6f03e1d041f559f8d1b076995b41b84ff5853eb619950b53da3L29-L32 (see file ci-operator/config/netobserv/network-observability-operator/netobserv-network-observability-operator-main.yaml)
As you can see we also had to override a couple of go ENV variables, but maybe this isn't useful here, as the base image used for building is different.

Copy link
Contributor Author

@memodi memodi Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you been able to test the build or not?

No, I have not yet, wanted to create this first draft of config and have it pass by you to resolve any evident issues as you noted.

I'm not sure how these configs/steps all play together

I can't say I know them well either, trying to go through the documentation and use references from other operator configs.

as the base image used for building is different.

do you mean 9.1 in Dockerfile vs 9 in this config?

added feedback in commit: 1284cbd

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2023

@memodi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/prow-config-filenames 7178ddf link true /test prow-config-filenames
ci/prow/check-gh-automation 7178ddf link true /test check-gh-automation
ci/prow/config 7178ddf link true /test config
ci/prow/correctly-sharded-config 7178ddf link true /test correctly-sharded-config
ci/prow/owners 7178ddf link true /test owners

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@memodi
Copy link
Contributor Author

memodi commented Mar 15, 2023

/hold
@jotak - looks like I need to start over again since the PR you linked removed support for Prow by initializing new-repo, I would have revert my earlier commits and start at make new-repo. In the mean could you add robots and GH app into repos under netobserv org.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2023
@jotak
Copy link
Contributor

jotak commented Mar 22, 2023

our github repos already have the openshift bots enabled

@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2023
@openshift-bot
Copy link
Contributor

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 6, 2023
@memodi memodi closed this May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants