Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: set vsphere csi encryption storageclass chain #37476

Merged
merged 1 commit into from Mar 22, 2023
Merged

Add: set vsphere csi encryption storageclass chain #37476

merged 1 commit into from Mar 22, 2023

Conversation

Phaow
Copy link
Contributor

@Phaow Phaow commented Mar 20, 2023

Add: set vsphere csi encryption storageclass chain for vsphere encryption CI Integration tests.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2023
@openshift-ci-robot
Copy link
Contributor

@Phaow: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-vsphere-ipi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-stable-vsphere-ipi-p2-f7 N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from dobsonj and jinyunma March 20, 2023 10:08
@Phaow
Copy link
Contributor Author

Phaow commented Mar 20, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-stable-vsphere-ipi-p2-f7

@Phaow Phaow force-pushed the add-vsphere-encryption-ref branch from 738e3ea to 2050f5f Compare March 21, 2023 00:29
@Phaow
Copy link
Contributor Author

Phaow commented Mar 21, 2023

/pj-rehearse refresh

@openshift-ci-robot
Copy link
Contributor

@Phaow: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-stable-vsphere-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-vsphere-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-stable-4.12-upgrade-from-stable-4.11-vsphere-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-stable-vsphere-upi-p2-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-4.10-upgrade-from-eus-4.8-vsphere-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-ec-4.13-vsphere-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-vsphere-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-vsphere-8-upi-p2-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-vsphere-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.10-amd64-nightly-vsphere-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-vsphere-8-upi-p2-f7 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-vsphere-8-upi-p3-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-stable-4.12-vsphere-upi-p3-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.13-installer-rehearse-vsphere N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.11-vsphere-upi-p3-f28 N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Phaow
Copy link
Contributor Author

Phaow commented Mar 21, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-stable-4.12-vsphere-upi-p3-f28

1 similar comment
@Phaow
Copy link
Contributor Author

Phaow commented Mar 21, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-stable-4.12-vsphere-upi-p3-f28

@Phaow Phaow force-pushed the add-vsphere-encryption-ref branch from 2050f5f to 5476d97 Compare March 21, 2023 05:41
@Phaow Phaow changed the title [WIP] Add: set vsphere csi encryption storageclass chain Add: set vsphere csi encryption storageclass chain Mar 21, 2023
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

@Phaow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-stable-vsphere-ipi-p2-f7 738e3eae6110b93c9a875eacfe07524e89ef5531 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-stable-vsphere-ipi-p2-f7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Phaow
Copy link
Contributor Author

Phaow commented Mar 21, 2023

Hi @jsafrane @gnufied , add the chain for set vsphere csi encryption storageclass chain for vsphere encryption CI Integration tests. It could be added to workflow:cucushift-installer-rehearse-vsphere-upi-encrypt in #36677 cover the vsphere encryption CI Integration tests(All other sub components will use the default encryption sc run the automaition tests).I tested it by myself it works as expected. Could you please help take a look when you get a chance? Thanks in advance!
Test record

sh-4.4$ oc get sc
NAME                            PROVISIONER                    RECLAIMPOLICY   VOLUMEBINDINGMODE      ALLOWVOLUMEEXPANSION   AGE
thin                            kubernetes.io/vsphere-volume   Delete          Immediate              false                  166m
thin-csi                        csi.vsphere.vmware.com         Delete          WaitForFirstConsumer   true                   162m
thin-csi-encryption (default)   csi.vsphere.vmware.com         Delete          WaitForFirstConsumer   true                   139m
sh-4.4$ oc get sc/thin-csi-encryption -o yaml                    
allowVolumeExpansion: true
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"allowVolumeExpansion":true,"apiVersion":"storage.k8s.io/v1","kind":"StorageClass","metadata":{"annotations":{},"name":"thin-csi-encryption"},"parameters":{"datastoreurl":"ds:///vmfs/volumes/vsan:523ea352e875627d-b090c96b526bb79c/","storagepolicyname":"Management Storage policy - Encryption"},"provisioner":"csi.vsphere.vmware.com","reclaimPolicy":"Delete","volumeBindingMode":"WaitForFirstConsumer"}
    storageclass.kubernetes.io/is-default-class: "true"
  creationTimestamp: "2023-03-21T03:14:19Z"
  name: thin-csi-encryption
  resourceVersion: "39020"
  uid: 9ce04350-cbde-458e-bdff-85239eb21bf0
parameters:
  datastoreurl: ds:///vmfs/volumes/vsan:523ea352e875627d-b090c96b526bb79c/
  storagepolicyname: Management Storage policy - Encryption
provisioner: csi.vsphere.vmware.com
reclaimPolicy: Delete
volumeBindingMode: WaitForFirstConsumer

@Phaow
Copy link
Contributor Author

Phaow commented Mar 21, 2023

/assign @jsafrane @gnufied

@jsafrane
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, Phaow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Phaow
Copy link
Contributor Author

Phaow commented Mar 22, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 22, 2023
@openshift-merge-robot openshift-merge-robot merged commit bdddf22 into openshift:master Mar 22, 2023
bmanzari pushed a commit to bmanzari/release that referenced this pull request Mar 30, 2023
@Phaow @bmanzari
Add: vsphere csi encryption set chain (openshift#37476)
ae97177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobsonj dobsonj Awaiting requested review from dobsonj

@jinyunma jinyunma Awaiting requested review from jinyunma

Assignees

@gnufied gnufied

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
5 participants
@Phaow @openshift-ci-robot @jsafrane @gnufied @openshift-merge-robot