Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACM-4682] Onboarded analytics recommends component #37908

Merged
merged 6 commits into from
Mar 30, 2023
Merged

[ACM-4682] Onboarded analytics recommends component #37908

merged 6 commits into from
Mar 30, 2023

Conversation

dislbenn
Copy link
Contributor

Onboarding recommends repo to ACM 2.8.0 build.

@dislbenn
onboarded analytics recommends component
c4aa835 
Signed-off-by: Disaiah Bennett <dbennett@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@dislbenn: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-recommends-main-images stolostron/recommends presubmit Presubmit changed
pull-ci-stolostron-recommends-main-lint stolostron/recommends presubmit Presubmit changed
pull-ci-stolostron-recommends-main-pr-image-mirror stolostron/recommends presubmit Presubmit changed
pull-ci-stolostron-recommends-main-sonar-pre-submit stolostron/recommends presubmit Presubmit changed
pull-ci-stolostron-recommends-main-test-unit stolostron/recommends presubmit Presubmit changed
pull-ci-stolostron-recommends-release-2.8-images stolostron/recommends presubmit Presubmit changed
pull-ci-stolostron-recommends-release-2.8-lint stolostron/recommends presubmit Presubmit changed
pull-ci-stolostron-recommends-release-2.8-pr-image-mirror stolostron/recommends presubmit Presubmit changed
pull-ci-stolostron-recommends-release-2.8-sonar-pre-submit stolostron/recommends presubmit Presubmit changed
pull-ci-stolostron-recommends-release-2.8-test-unit stolostron/recommends presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dislbenn
added OWNERS file
6f1e3f0 
Signed-off-by: Disaiah Bennett <dbennett@redhat.com>
@dislbenn
Copy link
Contributor Author

/pj-rehearse

@dislbenn
updated makefile for sonar job
9e1ee33 
Signed-off-by: Disaiah Bennett <dbennett@redhat.com>
@dislbenn
Copy link
Contributor Author

/pj-rehearse

@dislbenn
updated image ref for recommends repo
ad31ae0 
Signed-off-by: Disaiah Bennett <dbennett@redhat.com>
@dislbenn
Copy link
Contributor Author

/pj-rehearse

@dislbenn
updated recommends repo config
a08c43a 
Signed-off-by: Disaiah Bennett <dbennett@redhat.com>
@dislbenn
Copy link
Contributor Author

/pj-rehearse

@dislbenn
updated recommends repo config
d9c10ed 
Signed-off-by: Disaiah Bennett <dbennett@redhat.com>
@dislbenn
Copy link
Contributor Author

/pj-rehearse

@dislbenn
Copy link
Contributor Author

dislbenn commented Mar 30, 2023 •
edited

The lint jobs will fail due to an incompatibility issue with the current go 1.20 version.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

@dislbenn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/stolostron/recommends/main/sonar-pre-submit d9c10ed link unknown /pj-rehearse pull-ci-stolostron-recommends-main-sonar-pre-submit
ci/rehearse/stolostron/recommends/release-2.8/lint d9c10ed link unknown /pj-rehearse pull-ci-stolostron-recommends-release-2.8-lint
ci/rehearse/stolostron/recommends/release-2.8/sonar-pre-submit d9c10ed link unknown /pj-rehearse pull-ci-stolostron-recommends-release-2.8-sonar-pre-submit
ci/rehearse/stolostron/recommends/main/lint d9c10ed link unknown /pj-rehearse pull-ci-stolostron-recommends-main-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dislbenn
Copy link
Contributor Author

/cc @gurnben

@openshift-ci openshift-ci bot requested a review from gurnben March 30, 2023 21:23
gurnben
gurnben approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@gurnben gurnben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, gurnben

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2023
@dislbenn
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 30, 2023
@openshift-merge-robot openshift-merge-robot merged commit 13982c1 into openshift:master Mar 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2023

@dislbenn: Updated the following 6 configmaps:

  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-stolostron-recommends-_prowconfig.yaml using file core-services/prow/02_config/stolostron/recommends/_prowconfig.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key stolostron-recommends-main.yaml using file ci-operator/config/stolostron/recommends/stolostron-recommends-main.yaml
  • ci-operator-2.x-configs configmap in namespace ci at cluster app.ci using the following files:
    • key stolostron-recommends-release-2.8.yaml using file ci-operator/config/stolostron/recommends/stolostron-recommends-release-2.8.yaml
  • job-config-master-postsubmits configmap in namespace ci at cluster app.ci using the following files:
    • key stolostron-recommends-main-postsubmits.yaml using file ci-operator/jobs/stolostron/recommends/stolostron-recommends-main-postsubmits.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key stolostron-recommends-main-presubmits.yaml using file ci-operator/jobs/stolostron/recommends/stolostron-recommends-main-presubmits.yaml
  • job-config-2.x configmap in namespace ci at cluster app.ci using the following files:
    • key stolostron-recommends-release-2.8-postsubmits.yaml using file ci-operator/jobs/stolostron/recommends/stolostron-recommends-release-2.8-postsubmits.yaml
    • key stolostron-recommends-release-2.8-presubmits.yaml using file ci-operator/jobs/stolostron/recommends/stolostron-recommends-release-2.8-presubmits.yaml

In response to this:

Onboarding recommends repo to ACM 2.8.0 build.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurnben gurnben gurnben approved these changes

@ray-harris ray-harris Awaiting requested review from ray-harris

@schmidtd schmidtd Awaiting requested review from schmidtd

Assignees

@gurnben gurnben

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
4 participants
@dislbenn @openshift-ci-robot @gurnben @openshift-merge-robot