Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSM-3716: Add maistra prometheus tests #38136

Merged
merged 1 commit into from
Apr 7, 2023
Merged

OSSM-3716: Add maistra prometheus tests #38136

merged 1 commit into from
Apr 7, 2023

Conversation

jwendell
Copy link
Member

@jwendell jwendell commented Apr 6, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 6, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 6, 2023 •
edited by openshift-ci bot

@jwendell: This pull request references OSSM-3716 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@jwendell: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-maistra-prometheus-maistra-2.1-unit-2-1 maistra/prometheus presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2023
@jwendell
Copy link
Member Author

jwendell commented Apr 6, 2023

/pj-rehearse

@jwendell
Copy link
Member Author

jwendell commented Apr 6, 2023

/pj-rehearse

@yxun
Copy link
Contributor

yxun commented Apr 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2023
@jwendell
Copy link
Member Author

jwendell commented Apr 7, 2023

/pj-rehearse

yxun
yxun reviewed Apr 7, 2023
View reviewed changes
ci-operator/config/maistra/prometheus/maistra-prometheus-maistra-2.1.yaml
resources:
'*':
limits:
memory: 8Gi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this memory limit. The default cluster node may not has 8Gi memory.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked previously. Other jobs have 8 and some even 16. Note that this is the limit, not the request.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, I don't know other difference.
You may fetch and merge recent master branch changes. And then run make update again.
I guess they have changed some infrastructure settings and old master branch code make update target need an update.

@jwendell
Copy link
Member Author

jwendell commented Apr 7, 2023

/pj-rehearse

yxun
yxun reviewed Apr 7, 2023
View reviewed changes
ci-operator/jobs/maistra/prometheus/maistra-prometheus-maistra-2.1-presubmits.yaml
branches:
- ^maistra-2\.1$
- ^maistra-2\.1-
cluster: build01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why make update generates cluster build01 ?
It looks like a small cluster. We may need to run make update again.

I had larger memory requests value in maistra/istio jobs and they are on cluster: build03 from my make update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did run make update. You are probably confusing requests with limits.

@yxun
Copy link
Contributor

yxun commented Apr 7, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 7, 2023
@jwendell
Copy link
Member Author

jwendell commented Apr 7, 2023

/pj-rehearse abort

@jwendell
Copy link
Member Author

jwendell commented Apr 7, 2023

/pj-rehearse reject

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 7, 2023
@yxun
Copy link
Contributor

yxun commented Apr 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwendell, yxun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jwendell
Copy link
Member Author

jwendell commented Apr 7, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2023

@jwendell: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/maistra/prometheus/maistra-2.1/unit-2-1 97f017d link unknown /pj-rehearse pull-ci-maistra-prometheus-maistra-2.1-unit-2-1

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 11e84d3 into openshift:master Apr 7, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 7, 2023

@jwendell: Updated the following 2 configmaps:

  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key maistra-prometheus-maistra-2.1-presubmits.yaml using file ci-operator/jobs/maistra/prometheus/maistra-prometheus-maistra-2.1-presubmits.yaml
  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key maistra-prometheus-maistra-2.1.yaml using file ci-operator/config/maistra/prometheus/maistra-prometheus-maistra-2.1.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxun yxun yxun left review comments

@danilo-gemoli danilo-gemoli Awaiting requested review from danilo-gemoli

@droslean droslean Awaiting requested review from droslean

Assignees

@yxun yxun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
4 participants
@jwendell @openshift-ci-robot @yxun @openshift-merge-robot