Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ossm-3607 split maistra istio integ jobs #38226

Merged
merged 4 commits into from
Apr 11, 2023

Conversation

yxun
Copy link
Contributor

@yxun yxun commented Apr 11, 2023

This PR splits the maistra istio integ job into six jobs. Each of them will claim a standby cluster and run servicemesh-istio-e2e-aws workflow and then execute an istio integ-suite-kind test target.

@openshift-ci openshift-ci bot requested review from FilipB and rcernich April 11, 2023 20:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2023
@openshift-ci-robot
Copy link
Contributor

@yxun: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-maistra-istio-maistra-2.4-maistra-istio-integ-aws-2-4 maistra/istio presubmit Ci-operator config changed
pull-ci-maistra-istio-maistra-2.3-maistra-istio-integ-aws-2-3 maistra/istio presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@yxun
Copy link
Contributor Author

yxun commented Apr 11, 2023

/pj-rehearse

@yxun
Copy link
Contributor Author

yxun commented Apr 11, 2023

/pj-rehearse abort

@yxun
Copy link
Contributor Author

yxun commented Apr 11, 2023

/pj-rehearse

@yxun
Copy link
Contributor Author

yxun commented Apr 11, 2023

/pj-rehearse more

Copy link
Member

@jwendell jwendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we remove the word kube from all jobs? It doesn't add any value.

no need to rehearse the jobs after this change.

@jwendell
Copy link
Member

/pj-rehearse refresh

@openshift-ci-robot
Copy link
Contributor

@jwendell: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-maistra-istio-maistra-2.3-integ-helm-2-3 maistra/istio presubmit Presubmit changed
pull-ci-maistra-istio-maistra-2.3-integ-pilot-2-3 maistra/istio presubmit Presubmit changed
pull-ci-maistra-istio-maistra-2.3-integ-security-2-3 maistra/istio presubmit Presubmit changed
pull-ci-maistra-istio-maistra-2.3-integ-servicemesh-2-3 maistra/istio presubmit Presubmit changed
pull-ci-maistra-istio-maistra-2.3-integ-servicemesh-multicluster-2-3 maistra/istio presubmit Presubmit changed
pull-ci-maistra-istio-maistra-2.3-integ-telemetry-2-3 maistra/istio presubmit Presubmit changed
pull-ci-maistra-istio-maistra-2.4-integ-helm-2-4 maistra/istio presubmit Presubmit changed
pull-ci-maistra-istio-maistra-2.4-integ-pilot-2-4 maistra/istio presubmit Presubmit changed
pull-ci-maistra-istio-maistra-2.4-integ-security-2-4 maistra/istio presubmit Presubmit changed
pull-ci-maistra-istio-maistra-2.4-integ-servicemesh-2-4 maistra/istio presubmit Presubmit changed
pull-ci-maistra-istio-maistra-2.4-integ-servicemesh-multicluster-2-4 maistra/istio presubmit Presubmit changed
pull-ci-maistra-istio-maistra-2.4-integ-telemetry-2-4 maistra/istio presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jwendell
Copy link
Member

/pj-rehearse auto-ack

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwendell, yxun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 11, 2023
@openshift-merge-robot openshift-merge-robot merged commit f17ec39 into openshift:master Apr 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

@yxun: Updated the following 2 configmaps:

  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key maistra-istio-maistra-2.3.yaml using file ci-operator/config/maistra/istio/maistra-istio-maistra-2.3.yaml
    • key maistra-istio-maistra-2.4.yaml using file ci-operator/config/maistra/istio/maistra-istio-maistra-2.4.yaml
  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key maistra-istio-maistra-2.3-presubmits.yaml using file ci-operator/jobs/maistra/istio/maistra-istio-maistra-2.3-presubmits.yaml
    • key maistra-istio-maistra-2.4-presubmits.yaml using file ci-operator/jobs/maistra/istio/maistra-istio-maistra-2.4-presubmits.yaml

In response to this:

This PR splits the maistra istio integ job into six jobs. Each of them will claim a standby cluster and run servicemesh-istio-e2e-aws workflow and then execute an istio integ-suite-kind test target.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yxun yxun deleted the maistra-test branch January 30, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants