Add nmstatectl for the unit tests #38290

[andfasano]

Some of the agent-based installer unit tests require the presence of nmstatectl, otherwise they will be skipped silently.

Note: this PR could be merged only after openshift/installer#7089

[openshift-ci-robot]

@andfasano: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-installer-master-unit	openshift/installer	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[andfasano]

/pj-rehearse

[andfasano]

/pj-rehearse

[andfasano]

/pj-rehearse

[andfasano]

/pj-rehearse pull-ci-openshift-installer-master-unit

[openshift-ci-robot]

@andfasano: This pull request references AGENT-598 which is a valid jira issue.

In response to this:

Some of the agent-based installer unit tests require the presence of nmstatectl, otherwise they will be skipped silently

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@andfasano: This pull request references AGENT-598 which is a valid jira issue.

In response to this:

Some of the agent-based installer unit tests require the presence of nmstatectl, otherwise they will be skipped silently.

Note: this PR could be merged only after openshift/installer#7089

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zaneb]

Please make the same changes to the release-4.14 branch config, so that we don't lose this config after branching.
Does the same issue apply to 4.13?

[andfasano]

Please make the same changes to the release-4.14 branch config, so that we don't lose this config after branching.

Isn't the CI bot copying it already from master -> 4.14?

Does the same issue apply to 4.13?

Good point, but it will require a backport of #38290 to 4.13 once landed (we could add it later eventually)

[andfasano]

/pj-rehearse

[andfasano]

/pj-rehearse pull-ci-openshift-installer-master-unit

[openshift-ci-robot]

@andfasano: This pull request references Jira Issue OCPBUGS-12869, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Some of the agent-based installer unit tests require the presence of nmstatectl, otherwise they will be skipped silently.

Note: this PR could be merged only after openshift/installer#7089

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andfasano]

/pj-rehearse ack

[bfournie]

/lgtm

[openshift-ci]

@andfasano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/installer/master/e2e-alibaba	21693a1	link	unknown	/pj-rehearse pull-ci-openshift-installer-master-e2e-alibaba
ci/rehearse/openshift/installer/master/e2e-aws-ovn-disruptive	21693a1	link	unknown	/pj-rehearse pull-ci-openshift-installer-master-e2e-aws-ovn-disruptive

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[patrickdillon]

/test ci/prow/yamllint
/approve

[openshift-ci]

@patrickdillon: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test app-ci-config-dry
• /test boskos-config
• /test boskos-config-generation
• /test build-clusters
• /test build01-dry
• /test build02-dry
• /test build03-dry
• /test build04-dry
• /test build05-dry
• /test check-gh-automation
• /test ci-operator-config
• /test ci-operator-config-metadata
• /test ci-operator-registry
• /test ci-secret-bootstrap-config-validation
• /test ci-testgrid-allow-list
• /test clusterimageset-validate
• /test config
• /test core-valid
• /test correctly-sharded-config
• /test deprecate-templates
• /test generated-config
• /test generated-dashboards
• /test hive-dry
• /test jira-lifecycle-config
• /test multi01-dry
• /test openshift-image-mirror-mappings
• /test ordered-prow-config
• /test owners
• /test pr-reminder-config
• /test prow-config
• /test prow-config-filenames
• /test prow-config-semantics
• /test pylint
• /test release-config
• /test release-controller-config
• /test secret-generator-config-valid
• /test services-valid
• /test step-registry-metadata
• /test step-registry-shellcheck
• /test supplemental-ci-images-mapping-files
• /test sync-rover-groups
• /test yamllint

The following commands are available to trigger optional jobs:

• /test arm01-dry
• /test vsphere-dry

Use /test all to run the following jobs that were automatically triggered:

• pull-ci-openshift-release-check-gh-automation
• pull-ci-openshift-release-master-build-clusters
• pull-ci-openshift-release-master-ci-operator-config
• pull-ci-openshift-release-master-ci-operator-config-metadata
• pull-ci-openshift-release-master-ci-operator-registry
• pull-ci-openshift-release-master-core-valid
• pull-ci-openshift-release-master-correctly-sharded-config
• pull-ci-openshift-release-master-deprecate-templates
• pull-ci-openshift-release-master-generated-config
• pull-ci-openshift-release-master-ordered-prow-config
• pull-ci-openshift-release-master-owners
• pull-ci-openshift-release-master-prow-config-filenames
• pull-ci-openshift-release-master-release-controller-config
• pull-ci-openshift-release-openshift-image-mirror-mappings
• pull-ci-openshift-release-yamllint

In response to this:

/test ci/prow/yamllint
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, bfournie, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/installer/OWNERS [patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[patrickdillon]

/retitle Add nmstatectl for the unit tests #38290

[openshift-ci-robot]

@andfasano: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Some of the agent-based installer unit tests require the presence of nmstatectl, otherwise they will be skipped silently.

Note: this PR could be merged only after openshift/installer#7089

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[patrickdillon]

/jira refresh

[openshift-ci-robot]

@patrickdillon: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[patrickdillon]

/test yamllint

[openshift-ci]

@andfasano: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

• key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml

In response to this:

Some of the agent-based installer unit tests require the presence of nmstatectl, otherwise they will be skipped silently.

Note: this PR could be merged only after openshift/installer#7089

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.