Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSM-3731: Add maistra api postsubmit jobs #38483

Closed
wants to merge 0 commits into from
Closed

OSSM-3731: Add maistra api postsubmit jobs #38483

wants to merge 0 commits into from

Conversation

leoieggli
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 19, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 19, 2023 •
edited by openshift-ci bot

@leoieggli: This pull request references OSSM-3731 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from rcernich and yxun April 19, 2023 04:28
@leoieggli
Copy link
Contributor Author

/pj-rehearse

@leoieggli
Copy link
Contributor Author

/retest

@leoieggli
Copy link
Contributor Author

/pj-rehearse pull-ci-maistra-api-maistra-2.3-api-update-istio-2.3

@leoieggli
Copy link
Contributor Author

/pj-rehearse pull-ci-maistra-api-maistra-2.4-api-update-istio-2.4

jwendell
jwendell suggested changes Apr 19, 2023
View reviewed changes
ci-operator/config/maistra/api/maistra-api-maistra-2.3.yaml Outdated
@@ -34,15 +34,14 @@ tests:
commands: |
./maistra/run-test-infra-script.sh ./tools/automator.sh \
-o maistra \
-f /creds-github/github-token \
-f /creds-github/token \
-r istio \
-c UPDATE_BRANCH=$AUTOMATOR_SHA bin/update_maistra_deps.sh \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the UPDATE_BRANCH variable:

-c bin/update_maistra_deps.sh

also for the 2.4 job below.

@leoieggli
Copy link
Contributor Author

/pj-rehearse pull-ci-maistra-api-maistra-2.3-api-update-istio-2.3

@leoieggli
Copy link
Contributor Author

/pj-rehearse pull-ci-maistra-api-maistra-2.4-api-update-istio-2.4

@leoieggli
Copy link
Contributor Author

/pj-rehearse pull-ci-maistra-api-maistra-2.3-api-update-istio-2.3 pull-ci-maistra-api-maistra-2.4-api-update-istio-2.4

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 19, 2023

@leoieggli: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/maistra/api/maistra-2.4/api-update-istio-2.4 ded987bfab0f904f774305bd69d00ad63b9af69c link unknown /pj-rehearse pull-ci-maistra-api-maistra-2.4-api-update-istio-2.4
ci/rehearse/maistra/api/maistra-2.3/api-update-istio-2.3 ded987bfab0f904f774305bd69d00ad63b9af69c link unknown /pj-rehearse pull-ci-maistra-api-maistra-2.3-api-update-istio-2.3

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@leoieggli leoieggli closed this Apr 24, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@leoieggli: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: leoieggli

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leoieggli leoieggli deleted the OSSM-3731-fix branch April 24, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwendell jwendell jwendell requested changes

@rcernich rcernich Awaiting requested review from rcernich

@yxun yxun Awaiting requested review from yxun

Assignees

@jwendell jwendell

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
3 participants
@leoieggli @openshift-ci-robot @jwendell