Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase mcp update timeout for tuned config #38717

Merged

Conversation

DennisPeriquet
Copy link
Contributor

@DennisPeriquet DennisPeriquet commented Apr 25, 2023

TRT-982

When waiting 30m for the tuned config to be applied, very often, the timeout is exceeded. This causes the test to summarily fail and contributes to 4.14 nightly payload failures. Increasing this timeout helps the tests pass; we can continue the investigation in the meantime.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@DennisPeriquet: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-machine-config-operator-master-e2e-gcp-ovn-rt-upgrade openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.15-e2e-gcp-ovn-rt-upgrade openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-machine-config-operator-release-4.14-e2e-gcp-ovn-rt-upgrade openshift/machine-config-operator presubmit Registry content changed
pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.15-e2e-gcp-ovn-rt-upgrade openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.14-e2e-gcp-ovn-rt-upgrade openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.13-e2e-gcp-ovn-rt-upgrade openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.12-e2e-gcp-ovn-rt-upgrade openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.11-e2e-gcp-ovn-rt-upgrade openshift/origin presubmit Registry content changed
periodic-ci-openshift-release-master-ci-4.12-upgrade-from-stable-4.11-e2e-gcp-ovn-rt-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.13-e2e-gcp-ovn-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.11-e2e-gcp-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-gcp-ovn-rt-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.9-e2e-gcp-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.13-upgrade-from-stable-4.12-e2e-gcp-ovn-rt-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.14-e2e-gcp-ovn-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.8-e2e-gcp-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.11-upgrade-from-stable-4.10-e2e-gcp-ovn-rt-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.6-e2e-gcp-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.10-e2e-gcp-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-ci-4.10-upgrade-from-stable-4.9-e2e-gcp-ovn-rt-upgrade N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.12-e2e-gcp-ovn-rt N/A periodic Registry content changed
periodic-ci-openshift-release-master-nightly-4.7-e2e-gcp-rt N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from nmars and sonam1412 April 25, 2023 14:06
@DennisPeriquet
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-gcp-ovn-rt-upgrade

@eggfoobar
Copy link
Contributor

/lgtm

1 similar comment
@jeff-roche
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@DennisPeriquet
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-release-master-ci-4.14-upgrade-from-stable-4.13-e2e-gcp-ovn-rt-upgrade

@stbenjam
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, eggfoobar, jeff-roche, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2023
@DennisPeriquet
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit 998cf01 into openshift:master Apr 25, 2023
13 of 14 checks passed
ascerra pushed a commit to ascerra/release that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
6 participants