Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSSM-3731: Add api postsubmit jobs #38733

Merged
merged 6 commits into from
May 9, 2023

Conversation

leoieggli
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 25, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 25, 2023

@leoieggli: This pull request references OSSM-3731 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leoieggli
Copy link
Contributor Author

/pj-rehearse

@leoieggli
Copy link
Contributor Author

/pj-rehearse

@leoieggli
Copy link
Contributor Author

/pj-rehearse

yxun added 2 commits May 3, 2023 10:51
Signed-off-by: Yuanlin <yuanlin.xu@redhat.com>
@yxun
Copy link
Contributor

yxun commented May 3, 2023

/pj-rehearse pull-ci-maistra-api-maistra-2.2-api-update-istio-2-2

@yxun
Copy link
Contributor

yxun commented May 3, 2023

/pj-rehearse pull-ci-maistra-api-maistra-2.2-api-update-istio-2-2

@yxun
Copy link
Contributor

yxun commented May 3, 2023

I used a workaround to verify the job by copying the current latest api maistra-2.2 branch commit SHA and assigning it to the temporary var.
After review, I will remove the workaround in another commit for the PR.

Copy link
Member

@jwendell jwendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Remove the workaround, add the postsubmit: true and remove an env variable from 2.4.

-m update_api_istio \
-b maistra-2.4
export BUILD_WITH_CONTAINER="0"
export GOFLAGS="-mod=vendor"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this. 2.4 doesn't use vendor

leoieggli and others added 2 commits May 8, 2023 15:34
Signed-off-by: Yuanlin <yuanlin.xu@redhat.com>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@leoieggli: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-maistra-api-maistra-2.2-api-update-istio-2-2 maistra/api presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2023

@leoieggli: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/maistra/api/maistra-2.4/api-update-istio-2.4 6215529 link unknown /pj-rehearse pull-ci-maistra-api-maistra-2.4-api-update-istio-2.4
ci/rehearse/maistra/api/maistra-2.3/api-update-istio-2.3 6215529 link unknown /pj-rehearse pull-ci-maistra-api-maistra-2.3-api-update-istio-2.3

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 8, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@leoieggli: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwendell, leoieggli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2023
@openshift-merge-robot openshift-merge-robot merged commit 2f200b8 into openshift:master May 9, 2023
17 of 18 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2023

@leoieggli: Updated the following 2 configmaps:

  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key maistra-api-maistra-2.2.yaml using file ci-operator/config/maistra/api/maistra-api-maistra-2.2.yaml
    • key maistra-api-maistra-2.3.yaml using file ci-operator/config/maistra/api/maistra-api-maistra-2.3.yaml
    • key maistra-api-maistra-2.4.yaml using file ci-operator/config/maistra/api/maistra-api-maistra-2.4.yaml
  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key maistra-api-maistra-2.2-postsubmits.yaml using file ci-operator/jobs/maistra/api/maistra-api-maistra-2.2-postsubmits.yaml
    • key maistra-api-maistra-2.3-postsubmits.yaml using file ci-operator/jobs/maistra/api/maistra-api-maistra-2.3-postsubmits.yaml
    • key maistra-api-maistra-2.4-postsubmits.yaml using file ci-operator/jobs/maistra/api/maistra-api-maistra-2.4-postsubmits.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
5 participants