-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSSM-3731: Add api postsubmit jobs #38733
Conversation
@leoieggli: This pull request references OSSM-3731 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/pj-rehearse |
/pj-rehearse |
/pj-rehearse |
Signed-off-by: Yuanlin <yuanlin.xu@redhat.com>
/pj-rehearse pull-ci-maistra-api-maistra-2.2-api-update-istio-2-2 |
/pj-rehearse pull-ci-maistra-api-maistra-2.2-api-update-istio-2-2 |
I used a workaround to verify the job by copying the current latest api maistra-2.2 branch commit SHA and assigning it to the temporary var. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Remove the workaround, add the postsubmit: true and remove an env variable from 2.4.
-m update_api_istio \ | ||
-b maistra-2.4 | ||
export BUILD_WITH_CONTAINER="0" | ||
export GOFLAGS="-mod=vendor" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this. 2.4 doesn't use vendor
Signed-off-by: Yuanlin <yuanlin.xu@redhat.com>
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
@leoieggli: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[REHEARSALNOTIFIER] Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jwendell, leoieggli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2f200b8
into
openshift:master
@leoieggli: Updated the following 2 configmaps:
In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.