Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Servicemesh scenario onboarding #38738

Merged
merged 20 commits into from May 10, 2023
Merged

Servicemesh scenario onboarding #38738

merged 20 commits into from May 10, 2023

Conversation

Simranpal
Copy link
Contributor

Creating this PR for onboarding service mesh testing into the OpenShift CI.

Service Mesh Test Suites:

Link to the JIRA ticket: LPTOCPCI-147

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2023
@FilipB
Copy link
Contributor

FilipB commented Apr 26, 2023

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@FilipB, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build03: failed waiting for imagestreamtag istio-system/kiali-ui-test:kiali-ui-test to appear: timed out waiting for the condition

If the problem persists, please contact Test Platform.

@FilipB
Copy link
Contributor

FilipB commented Apr 27, 2023

/pj-rehearse

@FilipB FilipB mentioned this pull request Apr 27, 2023
Closed
@FilipB
Copy link
Contributor

FilipB commented Apr 28, 2023

/pj-rehearse

2 similar comments
@FilipB
Copy link
Contributor

FilipB commented Apr 28, 2023

/pj-rehearse

@FilipB
Copy link
Contributor

FilipB commented Apr 28, 2023

/pj-rehearse

@FilipB FilipB mentioned this pull request Apr 28, 2023
Merged
@FilipB
Copy link
Contributor

FilipB commented Apr 28, 2023

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@FilipB, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase repo client

@FilipB
Copy link
Contributor

FilipB commented Apr 28, 2023

/pj-rehearse

8 similar comments
@FilipB
Copy link
Contributor

FilipB commented Apr 28, 2023

/pj-rehearse

@FilipB
Copy link
Contributor

FilipB commented Apr 28, 2023

/pj-rehearse

@Simranpal
Copy link
Contributor Author

/pj-rehearse

@Simranpal
Copy link
Contributor Author

/pj-rehearse

@FilipB
Copy link
Contributor

FilipB commented Apr 29, 2023

/pj-rehearse

@Simranpal
Copy link
Contributor Author

/pj-rehearse

@FilipB
Copy link
Contributor

FilipB commented May 1, 2023

/pj-rehearse

@FilipB
Copy link
Contributor

FilipB commented May 2, 2023

/pj-rehearse

@FilipB
Copy link
Contributor

FilipB commented May 2, 2023

Last failure (ImagePullBackOff for kiali-int-tests-runner) is expected as we are still missing #38861
But good news is that maistra test tool step was successful - "Step servicemesh-interop-aws-servicemesh-maistra-test-tool-execute succeeded after 23m16s."

@FilipB
Copy link
Contributor

FilipB commented May 2, 2023

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@FilipB, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build03: failed waiting for imagestreamtag ci/kiali-int-tests:v1.57 to appear: timed out waiting for the condition

If the problem persists, please contact Test Platform.

@FilipB
Copy link
Contributor

FilipB commented May 2, 2023

/pj-rehearse

2 similar comments
@FilipB
Copy link
Contributor

FilipB commented May 2, 2023

/pj-rehearse

@Simranpal
Copy link
Contributor Author

/pj-rehearse

@FilipB
Copy link
Contributor

FilipB commented May 3, 2023

/pj-rehearse

2 similar comments
@FilipB
Copy link
Contributor

FilipB commented May 3, 2023

/pj-rehearse

@FilipB
Copy link
Contributor

FilipB commented May 3, 2023

/pj-rehearse

@FilipB
Copy link
Contributor

FilipB commented May 5, 2023

Waiting for #39052 before we can run rehearse job

calebevans
calebevans reviewed May 8, 2023
View reviewed changes
Copy link
Contributor

@calebevans calebevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of things. Looking good so far!

...maistra-test-tool/maistra-maistra-test-tool-maistra-2.4__servicemesh-ocp4.13-lp-interop.yaml Outdated
memory: 200Mi
tests:
- as: servicemesh-interop-aws
cron: 0 1 * * 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cron: 0 1 * * 1
cron: 0 6 * * 1

These cron jobs use UTC. This should set the trigger time correctly

...maistra-test-tool/maistra-maistra-test-tool-maistra-2.4__servicemesh-ocp4.13-lp-interop.yaml Show resolved Hide resolved
ci-operator/jobs/maistra/maistra-test-tool/maistra-maistra-test-tool-maistra-2.4-periodics.yaml Show resolved Hide resolved
ci-operator/step-registry/servicemesh/kiali/OWNERS Show resolved Hide resolved
.../servicemesh/kiali/cypress-tests/execute/servicemesh-kiali-cypress-tests-execute-commands.sh Show resolved Hide resolved
...registry/servicemesh/kiali/int-tests/execute/servicemesh-kiali-int-tests-execute-commands.sh Show resolved Hide resolved
@FilipB
Copy link
Contributor

FilipB commented May 9, 2023

/pj-rehearse

1 similar comment
@FilipB
Copy link
Contributor

FilipB commented May 9, 2023

/pj-rehearse

@FilipB
Copy link
Contributor

FilipB commented May 9, 2023

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@Simranpal: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-maistra-maistra-test-tool-maistra-2.4-servicemesh-ocp4.13-lp-interop-images maistra/maistra-test-tool presubmit Presubmit changed
periodic-ci-maistra-maistra-test-tool-maistra-2.4-servicemesh-ocp4.13-lp-interop-servicemesh-interop-aws N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

calebevans
calebevans approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@calebevans calebevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I can officially approve once we get some more input on when the scenario should merge from Adam.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2023
@FilipB
Copy link
Contributor

FilipB commented May 10, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 10, 2023
@Simranpal Simranpal changed the title WIP: Servicemesh scenario onboarding Servicemesh scenario onboarding May 10, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2023
@FilipB
Copy link
Contributor

FilipB commented May 10, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ascerra, calebevans, FilipB, Simranpal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2023

@Simranpal: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d79dff6 into openshift:master May 10, 2023
22 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 10, 2023

@Simranpal: Updated the following 2 configmaps:

  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key maistra-maistra-test-tool-maistra-2.4__servicemesh-ocp4.13-lp-interop.yaml using file ci-operator/config/maistra/maistra-test-tool/maistra-maistra-test-tool-maistra-2.4__servicemesh-ocp4.13-lp-interop.yaml
  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key maistra-maistra-test-tool-maistra-2.4-periodics.yaml using file ci-operator/jobs/maistra/maistra-test-tool/maistra-maistra-test-tool-maistra-2.4-periodics.yaml
    • key maistra-maistra-test-tool-maistra-2.4-presubmits.yaml using file ci-operator/jobs/maistra/maistra-test-tool/maistra-maistra-test-tool-maistra-2.4-presubmits.yaml

In response to this:

Creating this PR for onboarding service mesh testing into the OpenShift CI.

Service Mesh Test Suites:

Link to the JIRA ticket: LPTOCPCI-147

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilipB FilipB FilipB left review comments

@ascerra ascerra ascerra approved these changes

@calebevans calebevans calebevans approved these changes

@jwendell jwendell Awaiting requested review from jwendell

@rcernich rcernich Awaiting requested review from rcernich

Assignees

@ascerra ascerra

@calebevans calebevans

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
6 participants
@Simranpal @FilipB @openshift-ci-robot @ascerra @calebevans @openshift-merge-robot