Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPCLOUD-2028: Remove old AWS CCM tests #38753

Merged
merged 1 commit into from
Apr 26, 2023
Merged

OCPCLOUD-2028: Remove old AWS CCM tests #38753

merged 1 commit into from
Apr 26, 2023

Conversation

RadekManak
Copy link
Contributor

CCM on AWS is GA in 4.14. We no longer need to run tests with CCM feature flag, as it is deployed by default.

Removed all jobs that matched "aws.*ccm" in files matching ".*master.yaml"

TechPreview jobs on CCM and CCCMO were already removed in previous PR: #37217

@RadekManak
Remove old AWS CCM tests
4429075 
CCM on AWS is GA in 4.14. We no longer need to run tests with CCM
feature flag as it is deployed by default.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 26, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 26, 2023 •
edited by openshift-ci bot

@RadekManak: This pull request references OCPCLOUD-2028 which is a valid jira issue.

In response to this:

CCM on AWS is GA in 4.14. We no longer need to run tests with CCM feature flag, as it is deployed by default.

Removed all jobs that matched "aws.*ccm" in files matching ".*master.yaml"

TechPreview jobs on CCM and CCCMO were already removed in previous PR: #37217

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 26, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@RadekManak: no rehearsable tests are affected by this change

@RadekManak
Copy link
Contributor Author

/assign @JoelSpeed

JoelSpeed
JoelSpeed reviewed Apr 26, 2023
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the status of the techpreview jobs for AWS on CCMO and the cloud-provider-aws repositories? Maybe we want to make those on-demand by setting always_run: false going forward? Since there should be no-diff between the two, WDYT?

@RadekManak
Copy link
Contributor Author

They were already removed by #37217

@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2023
@RadekManak
Copy link
Contributor Author

/assign @atiratree
/assign @sebsoto

@sebsoto
Copy link
Contributor

sebsoto commented Apr 26, 2023

/lgtm

1 similar comment
@atiratree
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, JoelSpeed, RadekManak, sebsoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2023

@RadekManak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ac50204 into openshift:master Apr 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 26, 2023

@RadekManak: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-kube-controller-manager-operator-master.yaml using file ci-operator/config/openshift/cluster-kube-controller-manager-operator/openshift-cluster-kube-controller-manager-operator-master.yaml
    • key openshift-windows-machine-config-bootstrapper-master.yaml using file ci-operator/config/openshift/windows-machine-config-bootstrapper/openshift-windows-machine-config-bootstrapper-master.yaml
    • key openshift-windows-machine-config-operator-master.yaml using file ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-kube-controller-manager-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-kube-controller-manager-operator/openshift-cluster-kube-controller-manager-operator-master-presubmits.yaml
    • key openshift-windows-machine-config-bootstrapper-master-presubmits.yaml using file ci-operator/jobs/openshift/windows-machine-config-bootstrapper/openshift-windows-machine-config-bootstrapper-master-presubmits.yaml
  • job-config-master-periodics configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-windows-machine-config-operator-master-periodics.yaml using file ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master-periodics.yaml

In response to this:

CCM on AWS is GA in 4.14. We no longer need to run tests with CCM feature flag, as it is deployed by default.

Removed all jobs that matched "aws.*ccm" in files matching ".*master.yaml"

TechPreview jobs on CCM and CCCMO were already removed in previous PR: #37217

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ascerra pushed a commit to ascerra/release that referenced this pull request May 8, 2023
@RadekManak @ascerra
Remove old AWS CCM tests (openshift#38753)
45295a8 
CCM on AWS is GA in 4.14. We no longer need to run tests with CCM
feature flag as it is deployed by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@aravindhp aravindhp Awaiting requested review from aravindhp

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@atiratree atiratree

@JoelSpeed JoelSpeed

@sebsoto sebsoto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
6 participants
@RadekManak @openshift-ci-robot @JoelSpeed @sebsoto @atiratree @openshift-merge-robot