Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTO: Extract PAO workloadhints test's to new lane #38754

Merged
merged 1 commit into from
Jun 19, 2023
Merged

NTO: Extract PAO workloadhints test's to new lane #38754

merged 1 commit into from
Jun 19, 2023

Conversation

jlojosnegros
Copy link
Contributor

Extract PAO workloadhints test suite to a new separate lane to avoid hitting the 4h timeout per ci-lane.

@jlojosnegros
Copy link
Contributor Author

/hold
Depends on : openshift/cluster-node-tuning-operator#631

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2023
@jlojosnegros
Copy link
Contributor Author

/pj-rehearse

@jlojosnegros jlojosnegros mentioned this pull request May 4, 2023
Merged
@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2023
@jlojosnegros
Copy link
Contributor Author

just rebasing over last master changes

@yanirq
Copy link
Contributor

yanirq commented Jun 12, 2023

@jlojosnegros please rebase and run the pj-rehearse jobs

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2023
@jlojosnegros
Copy link
Contributor Author

/pj-rehearse

@mrniranjan
Copy link
Contributor

/retest-required

@mrniranjan
Copy link
Contributor

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-gcp-pao-workloadhints

1 similar comment
@jlojosnegros
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-gcp-pao-workloadhints

@jlojosnegros
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2023
@jlojosnegros
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-gcp-pao-workloadhints

@yanirq
Copy link
Contributor

yanirq commented Jun 14, 2023

you will probably need to run make jobs again

@ffromani
Copy link
Contributor

/approve

we want this split

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2023
@yanirq
Copy link
Contributor

yanirq commented Jun 15, 2023

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-gcp-pao-workloadhints

@jlojosnegros
Copy link
Contributor Author

/pj-rehearse auto-ack

@jlojosnegros
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-gcp-pao-workloadhints

@jlojosnegros
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 16, 2023
@yanirq
Copy link
Contributor

yanirq commented Jun 19, 2023

@jlojosnegros please rebase

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2023
@jlojosnegros
NTO: Extract PAO workloadhints test's to new lane
d576c72 
Extract PAO workloadhints test suite to a new separate lane to avoid
hitting the 4h timeout per ci-lane.
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 19, 2023
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 19, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jlojosnegros: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-node-tuning-operator-master-e2e-gcp-pao-workloadhints openshift/cluster-node-tuning-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@ffromani
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, jlojosnegros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlojosnegros
Copy link
Contributor Author

/pj-rehearse

@jlojosnegros
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-cluster-node-tuning-operator-master-e2e-gcp-pao-workloadhints

@jlojosnegros
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

@jlojosnegros: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 627e0d4 into openshift:master Jun 19, 2023
19 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023

@jlojosnegros: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-node-tuning-operator-master.yaml using file ci-operator/config/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-master.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-node-tuning-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-node-tuning-operator/openshift-cluster-node-tuning-operator-master-presubmits.yaml

In response to this:

Extract PAO workloadhints test suite to a new separate lane to avoid hitting the 4h timeout per ci-lane.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jtaleric pushed a commit to jtaleric/release that referenced this pull request Jun 21, 2023
@jlojosnegros @jtaleric
NTO: Extract PAO workloadhints test's to new lane (openshift#38754)
5bf220f 
Extract PAO workloadhints test suite to a new separate lane to avoid
hitting the 4h timeout per ci-lane.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanirq yanirq yanirq left review comments

@dagrayvid dagrayvid Awaiting requested review from dagrayvid

@ffromani ffromani Awaiting requested review from ffromani

Assignees

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
7 participants
@jlojosnegros @openshift-bot @yanirq @mrniranjan @ffromani @openshift-ci-robot @openshift-merge-robot