OSSM-3732: Add istio postsubmit jobs #38817

leoieggli · 2023-04-27T14:55:54Z

No description provided.

openshift-ci-robot · 2023-04-27T14:55:57Z

@leoieggli: This pull request references OSSM-3732 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

leoieggli · 2023-04-27T15:01:26Z

/pj-rehearse

Signed-off-by: Yuanlin <yuanlin.xu@redhat.com>

yxun · 2023-05-03T19:23:12Z

/pj-rehearse

yxun · 2023-05-03T19:41:04Z

In maistra/istio-operator maistra-2.2 branch there is no make target 'update-2.1-charts'. and
make: *** No rule to make target 'update-2.2-charts'. Stop.
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/38817/rehearse-38817-pull-ci-maistra-istio-operator-maistra-2.2-update-charts-in-2-3/1653843042727104512
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/38817/rehearse-38817-pull-ci-maistra-istio-operator-maistra-2.2-update-charts-in-2-3/1653847872472354816

So remove that targets in the maistra-2.2 branch post submit jobs

yxun · 2023-05-03T19:42:41Z

/pj-rehearse

yxun · 2023-05-03T20:16:00Z

/pj-rehearse

yxun · 2023-05-08T12:53:05Z

/pj-rehearse

jwendell

I think it will be easier to review if you split this PR in two.

From what I can see, this PR incorporates OSSM-3732 and OSSM-3733.

jwendell · 2023-05-08T17:37:00Z

ci-operator/config/maistra/istio-operator/maistra-istio-operator-maistra-2.2.yaml

+      -r istio-operator \
+      -b maistra-2.4 \
+      -f /creds-github/token \
+      '-c make clean update-charts-2.3' \


@jwendell See my comment above

In maistra/istio-operator maistra-2.2 branch there is no make target 'update-2.1-charts'. and
make: *** No rule to make target 'update-2.2-charts'. Stop.
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/38817/rehearse-38817-pull-ci-maistra-istio-operator-maistra-2.2-update-charts-in-2-3/1653843042727104512
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/38817/rehearse-38817-pull-ci-maistra-istio-operator-maistra-2.2-update-charts-in-2-3/1653847872472354816

So remove that targets in the maistra-2.2 branch post submit jobs

oh, nvm, I see we have update-charts-2.2 . Let me update that

jwendell · 2023-05-08T17:37:09Z

ci-operator/config/maistra/istio-operator/maistra-istio-operator-maistra-2.2.yaml

+      -f /creds-github/token \
+      '-c make clean update-charts-2.3' \
+      '-t Automator: Update charts from previous versions' \
+      -m update_charts_from_previous_versions_2.3


yxun · 2023-05-08T19:05:20Z

/pj-rehearse pull-ci-maistra-istio-operator-maistra-2.2-update-charts-in-2-4

jwendell

Saying again:

I think it will be easier to review if you split this PR in two.

From what I can see, this PR incorporates OSSM-3732 and OSSM-3733.

yxun · 2023-05-09T15:02:48Z

/pj-rehearse pull-ci-maistra-istio-maistra-2.4-istio-update-operator-2-4

yxun · 2023-05-09T15:20:22Z

/pj-rehearse

openshift-ci · 2023-05-09T15:20:45Z

@leoieggli: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/maistra/istio/maistra-2.2/istio-update-operator-2.2	`e788dd4`	link	unknown	`/pj-rehearse pull-ci-maistra-istio-maistra-2.2-istio-update-operator-2.2`
ci/rehearse/maistra/istio-operator/maistra-2.2/update-charts-in-2-3	3e4e2fbca9786aacc3d700b2af0cf51cedfd9c08	link	unknown	`/pj-rehearse pull-ci-maistra-istio-operator-maistra-2.2-update-charts-in-2-3`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

yxun · 2023-05-15T18:57:43Z

/pj-rehearse ack

openshift-ci-robot · 2023-05-15T18:58:06Z

[REHEARSALNOTIFIER]
@leoieggli: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

yxun · 2023-05-15T20:51:11Z

@jwendell I added postsubmit true in the last commit and the ci bot removed the lgtm label.
Could you approve this PR again ? thanks.

nvm, I can add it . This PR was created by @leoieggli initially

yxun · 2023-05-15T20:53:06Z

/lgtm

openshift-ci · 2023-05-15T20:53:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwendell, leoieggli, yxun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~ci-operator/config/maistra/istio/OWNERS~~ [jwendell,leoieggli,yxun]
~~ci-operator/jobs/maistra/istio/OWNERS~~ [jwendell,leoieggli,yxun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2023-05-15T21:26:42Z

@leoieggli: Updated the following 2 configmaps:

ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
- key maistra-istio-maistra-2.2.yaml using file ci-operator/config/maistra/istio/maistra-istio-maistra-2.2.yaml
- key maistra-istio-maistra-2.3.yaml using file ci-operator/config/maistra/istio/maistra-istio-maistra-2.3.yaml
- key maistra-istio-maistra-2.4.yaml using file ci-operator/config/maistra/istio/maistra-istio-maistra-2.4.yaml
job-config-misc configmap in namespace ci at cluster app.ci using the following files:
- key maistra-istio-maistra-2.2-postsubmits.yaml using file ci-operator/jobs/maistra/istio/maistra-istio-maistra-2.2-postsubmits.yaml
- key maistra-istio-maistra-2.3-postsubmits.yaml using file ci-operator/jobs/maistra/istio/maistra-istio-maistra-2.3-postsubmits.yaml
- key maistra-istio-maistra-2.4-postsubmits.yaml using file ci-operator/jobs/maistra/istio/maistra-istio-maistra-2.4-postsubmits.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

OSSM-3732: Add istio postsubmit jobs

e788dd4

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 27, 2023

openshift-ci bot requested review from jwendell and rcernich April 27, 2023 14:57

yxun added 2 commits May 3, 2023 14:58

merge from master

d5cbd61

Update maistra istio and operator postsubmit jobs

49e607d

Signed-off-by: Yuanlin <yuanlin.xu@redhat.com>

remove deprecated target

2380a31

yxun force-pushed the OSSM-3732-fix branch from 3e4e2fb to 2380a31 Compare May 3, 2023 20:15

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2023

yxun added 2 commits May 8, 2023 08:50

Merge from master

8e2e5ea

merge from master

4d1fa38

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2023

jwendell suggested changes May 8, 2023

View reviewed changes

openshift-ci bot assigned jwendell May 8, 2023

leoieggli and others added 2 commits May 8, 2023 15:47

Merge branch 'openshift:master' into OSSM-3732-fix

b62291f

Fix operator 2.2 branch update charts job

d640aaa

jwendell suggested changes May 9, 2023

View reviewed changes

remove operator job change

86f59e9

yxun force-pushed the OSSM-3732-fix branch from 862ec16 to 86f59e9 Compare May 9, 2023 15:19

jwendell approved these changes May 15, 2023

View reviewed changes

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 15, 2023

Add postsubmit true

8473f17

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 15, 2023

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 15, 2023

openshift-ci bot assigned yxun May 15, 2023

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2023

openshift-merge-robot merged commit 471deb4 into openshift:master May 15, 2023
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OSSM-3732: Add istio postsubmit jobs #38817

OSSM-3732: Add istio postsubmit jobs #38817

leoieggli commented Apr 27, 2023

openshift-ci-robot commented Apr 27, 2023 •

edited by openshift-ci bot

leoieggli commented Apr 27, 2023

yxun commented May 3, 2023

yxun commented May 3, 2023 •

edited

yxun commented May 3, 2023

yxun commented May 3, 2023

yxun commented May 8, 2023

jwendell left a comment

jwendell May 8, 2023

yxun May 8, 2023

yxun May 8, 2023

jwendell May 8, 2023

yxun commented May 8, 2023

jwendell left a comment

yxun commented May 9, 2023

yxun commented May 9, 2023

openshift-ci bot commented May 9, 2023 •

edited

yxun commented May 15, 2023

openshift-ci-robot commented May 15, 2023

yxun commented May 15, 2023 •

edited

yxun commented May 15, 2023

openshift-ci bot commented May 15, 2023

openshift-ci bot commented May 15, 2023

OSSM-3732: Add istio postsubmit jobs #38817

OSSM-3732: Add istio postsubmit jobs #38817

Conversation

leoieggli commented Apr 27, 2023

openshift-ci-robot commented Apr 27, 2023 • edited by openshift-ci bot

leoieggli commented Apr 27, 2023

yxun commented May 3, 2023

yxun commented May 3, 2023 • edited

yxun commented May 3, 2023

yxun commented May 3, 2023

yxun commented May 8, 2023

jwendell left a comment

Choose a reason for hiding this comment

jwendell May 8, 2023

Choose a reason for hiding this comment

yxun May 8, 2023

Choose a reason for hiding this comment

yxun May 8, 2023

Choose a reason for hiding this comment

jwendell May 8, 2023

Choose a reason for hiding this comment

yxun commented May 8, 2023

jwendell left a comment

Choose a reason for hiding this comment

yxun commented May 9, 2023

yxun commented May 9, 2023

openshift-ci bot commented May 9, 2023 • edited

yxun commented May 15, 2023

openshift-ci-robot commented May 15, 2023

yxun commented May 15, 2023 • edited

yxun commented May 15, 2023

openshift-ci bot commented May 15, 2023

openshift-ci bot commented May 15, 2023

openshift-ci-robot commented Apr 27, 2023 •

edited by openshift-ci bot

yxun commented May 3, 2023 •

edited

openshift-ci bot commented May 9, 2023 •

edited

yxun commented May 15, 2023 •

edited