Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate icsp to idms #39122

Closed
wants to merge 1 commit into from
Closed

Conversation

QiWang19
Copy link
Member

@QiWang19 QiWang19 commented May 8, 2023

OCPNODE-521 has been implemented and will ship with openshift 4.13. This will introduce new CRD ImageDigestMirrorSet to redirect image pull for mirrored content. It is planned that other openshift components rely on ImageContentSource to migrate to ImageDigestMirrorSet in OCP 4.14.

This may need to cooperate PRs from other repositories, the following dependencies have been updated

[OCPNODE-521](https://issues.redhat.com/browse/OCPNODE-521) has been implemented and will ship with openshift 4.13. This will introduce new CRD [ImageDigestMirrorSet](https://github.com/openshift/api/blob/master/config/v1/0000_10_config-operator_01_imagedigestmirrorset.crd.yaml) to redirect image pull for mirrored content. It is planned that other openshift components rely on ImageContentSource to migrate to ImageDigestMirrorSet in OCP 4.14.

This may need to cooperate PRs from other repositories, the following dependencies have been updated
- [oc adm migrate icsp](openshift/oc#1238)  convert passed in icsp file to idms file
- [adm catalog mirror generates idms manifest](openshift/oc#1389)
- installer add [imageDigestSources](openshift/installer#6235) in install-config.yaml to replace imageContentSources

Signed-off-by: Qi Wang <qiwan@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@QiWang19: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-master-e2e-aws-operator openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.15-e2e-aws-operator openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.14-e2e-aws-operator openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.13-e2e-aws-operator openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.12-e2e-aws-operator openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.11-e2e-aws-operator openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.10-e2e-aws-operator openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.9-e2e-aws-operator openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.8-e2e-aws-operator openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.7-e2e-aws-operator openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.6-e2e-aws-operator openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.5-e2e-aws-operator openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.5-e2e-aws-operator-encryption openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.5-e2e-aws-operator-encryption-perf openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.4-e2e-aws-operator openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-master-e2e-aws openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.15-e2e-aws openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.14-e2e-aws openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.13-e2e-aws openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.12-e2e-aws openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.11-e2e-aws openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.10-e2e-aws openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.9-e2e-aws openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.8-e2e-aws openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.7-e2e-aws openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.6-e2e-aws openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.5-e2e-aws openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.4-e2e-aws openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-openshift-cluster-kube-storage-version-migrator-operator-release-4.3-e2e-aws openshift/cluster-kube-storage-version-migrator-operator presubmit Registry content changed
pull-ci-red-hat-data-services-opendatahub-operator-master-modh-operator-e2e red-hat-data-services/opendatahub-operator presubmit Registry content changed
pull-ci-red-hat-data-services-opendatahub-operator-master-48-modh-operator-e2e-48 red-hat-data-services/opendatahub-operator presubmit Registry content changed
pull-ci-maistra-proxy-maistra-2.3-maistra-proxy-unit-2-3 maistra/proxy presubmit Registry content changed
pull-ci-maistra-proxy-maistra-2.4-maistra-proxy-unit-2-4 maistra/proxy presubmit Registry content changed
pull-ci-maistra-proxy-maistra-2.2-maistra-proxy-unit-2-2 maistra/proxy presubmit Registry content changed
pull-ci-openshift-ironic-inspector-image-release-4.8-e2e-metal-ipi openshift/ironic-inspector-image presubmit Registry content changed

A total of 10990 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@QiWang19
Copy link
Member Author

QiWang19 commented May 8, 2023

/test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2023

@QiWang19: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build-clusters
  • /test build01-dry
  • /test build02-dry
  • /test build03-dry
  • /test build04-dry
  • /test build05-dry
  • /test check-gh-automation
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-bootstrap-config-validation
  • /test ci-testgrid-allow-list
  • /test clusterimageset-validate
  • /test config
  • /test core-valid
  • /test correctly-sharded-config
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test hive-dry
  • /test jira-lifecycle-config
  • /test multi01-dry
  • /test openshift-image-mirror-mappings
  • /test ordered-prow-config
  • /test owners
  • /test pr-reminder-config
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test pylint
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test supplemental-ci-images-mapping-files
  • /test sync-rover-groups
  • /test yamllint

The following commands are available to trigger optional jobs:

  • /test arm01-dry
  • /test vsphere-dry

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-release-master-app-ci-config-dry
  • pull-ci-openshift-release-master-arm01-dry
  • pull-ci-openshift-release-master-build-clusters
  • pull-ci-openshift-release-master-build01-dry
  • pull-ci-openshift-release-master-build02-dry
  • pull-ci-openshift-release-master-build03-dry
  • pull-ci-openshift-release-master-build04-dry
  • pull-ci-openshift-release-master-build05-dry
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-hive-dry
  • pull-ci-openshift-release-master-multi01-dry
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-master-vsphere-dry
  • pull-ci-openshift-release-openshift-image-mirror-mappings
  • pull-ci-openshift-release-sync-rover-groups
  • pull-ci-openshift-release-yamllint

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2023

@QiWang19: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build-clusters
  • /test build01-dry
  • /test build02-dry
  • /test build03-dry
  • /test build04-dry
  • /test build05-dry
  • /test check-gh-automation
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-bootstrap-config-validation
  • /test ci-testgrid-allow-list
  • /test clusterimageset-validate
  • /test config
  • /test core-valid
  • /test correctly-sharded-config
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test hive-dry
  • /test jira-lifecycle-config
  • /test multi01-dry
  • /test openshift-image-mirror-mappings
  • /test ordered-prow-config
  • /test owners
  • /test pr-reminder-config
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test pylint
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test supplemental-ci-images-mapping-files
  • /test sync-rover-groups
  • /test yamllint

The following commands are available to trigger optional jobs:

  • /test arm01-dry
  • /test vsphere-dry

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-release-master-app-ci-config-dry
  • pull-ci-openshift-release-master-arm01-dry
  • pull-ci-openshift-release-master-build-clusters
  • pull-ci-openshift-release-master-build01-dry
  • pull-ci-openshift-release-master-build02-dry
  • pull-ci-openshift-release-master-build03-dry
  • pull-ci-openshift-release-master-build04-dry
  • pull-ci-openshift-release-master-build05-dry
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-hive-dry
  • pull-ci-openshift-release-master-multi01-dry
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-master-vsphere-dry
  • pull-ci-openshift-release-openshift-image-mirror-mappings
  • pull-ci-openshift-release-sync-rover-groups
  • pull-ci-openshift-release-yamllint

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2023
@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 28, 2023
@openshift-bot
Copy link
Contributor

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2023

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/build-farm/build04-dry c34dda6 link true /test build04-dry
ci/prow/build-clusters c34dda6 link true /test build-clusters

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Aug 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

@openshift-bot: Closed this PR.

In response to this:

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
4 participants