Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-3173: manually disable ci/prow/versions test on release branches … #39152

Merged
merged 1 commit into from May 16, 2023
Merged

MON-3173: manually disable ci/prow/versions test on release branches … #39152

merged 1 commit into from May 16, 2023

Conversation

machine424
Copy link
Contributor

…from 4.10 to 4.15

@machine424
MON-3173: manually disable ci/prow/versions test on release branches …
9e579e8 
…from 4.10 to 4.15

Signed-off-by: machine424 <ayoubmrini424@gmail.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 9, 2023 •
edited by openshift-ci bot

@machine424: This pull request references MON-3173 which is a valid jira issue.

In response to this:

…from 4.10 to 4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 9, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@machine424: no rehearsable tests are affected by this change

@openshift-ci openshift-ci bot requested review from jan--f and raptorsun May 9, 2023 12:45
@danielmellado
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2023
@jan--f
Copy link
Contributor

jan--f commented May 16, 2023

Thanks, this
/lgtm

We will need to remove this check every time a new release- version is branched right? We have some release related tasks documented in https://github.com/openshift/cluster-monitoring-operator/blob/master/.github/ISSUE_TEMPLATE/release.md. Mind adding this there, even though its not the ideal place?
Ultimately this should probably move to our handbook.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, jan--f, machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2023

@machine424: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5947ab8 into openshift:master May 16, 2023
18 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2023

@machine424: Updated the following 12 configmaps:

  • ci-operator-4.14-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-monitoring-operator-release-4.14.yaml using file ci-operator/config/openshift/cluster-monitoring-operator/openshift-cluster-monitoring-operator-release-4.14.yaml
  • ci-operator-4.15-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-monitoring-operator-release-4.15.yaml using file ci-operator/config/openshift/cluster-monitoring-operator/openshift-cluster-monitoring-operator-release-4.15.yaml
  • job-config-4.10 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-monitoring-operator-release-4.10-presubmits.yaml using file ci-operator/jobs/openshift/cluster-monitoring-operator/openshift-cluster-monitoring-operator-release-4.10-presubmits.yaml
  • job-config-4.11 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-monitoring-operator-release-4.11-presubmits.yaml using file ci-operator/jobs/openshift/cluster-monitoring-operator/openshift-cluster-monitoring-operator-release-4.11-presubmits.yaml
  • job-config-4.13 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-monitoring-operator-release-4.13-presubmits.yaml using file ci-operator/jobs/openshift/cluster-monitoring-operator/openshift-cluster-monitoring-operator-release-4.13-presubmits.yaml
  • ci-operator-4.11-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-monitoring-operator-release-4.11.yaml using file ci-operator/config/openshift/cluster-monitoring-operator/openshift-cluster-monitoring-operator-release-4.11.yaml
  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-monitoring-operator-release-4.12.yaml using file ci-operator/config/openshift/cluster-monitoring-operator/openshift-cluster-monitoring-operator-release-4.12.yaml
  • job-config-4.12 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-monitoring-operator-release-4.12-presubmits.yaml using file ci-operator/jobs/openshift/cluster-monitoring-operator/openshift-cluster-monitoring-operator-release-4.12-presubmits.yaml
  • job-config-4.14 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-monitoring-operator-release-4.14-presubmits.yaml using file ci-operator/jobs/openshift/cluster-monitoring-operator/openshift-cluster-monitoring-operator-release-4.14-presubmits.yaml
  • job-config-4.15 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-monitoring-operator-release-4.15-presubmits.yaml using file ci-operator/jobs/openshift/cluster-monitoring-operator/openshift-cluster-monitoring-operator-release-4.15-presubmits.yaml
  • ci-operator-4.10-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-monitoring-operator-release-4.10.yaml using file ci-operator/config/openshift/cluster-monitoring-operator/openshift-cluster-monitoring-operator-release-4.10.yaml
  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-monitoring-operator-release-4.13.yaml using file ci-operator/config/openshift/cluster-monitoring-operator/openshift-cluster-monitoring-operator-release-4.13.yaml

In response to this:

…from 4.10 to 4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@machine424
Copy link
Contributor Author

Thanks to you both.

@jan--f Yes, as I mentioned in the ticket, this is not ideal, but will buy us some time to think about a better/automated solution.

I'll add the step to the template, I hope we'll not get used to doing this :)

@machine424
Copy link
Contributor Author

machine424 commented May 17, 2023 •
edited

Some of this (config for unreleased versions) was reverted by a lovely bot https://github.com/openshift/release/pull/39366/files

Maybe we need to consider the other options earlier than expected, I'll see

@jan--f
Copy link
Contributor

jan--f commented May 22, 2023

hm its possible that the brancher bot ensures that the release branches are tested just like the master branch is tested. Maybe we should fix this is our make versions target?

@machine424
Copy link
Contributor Author

Yep, I'm trying to apply solution #2 in here openshift/cluster-monitoring-operator#1969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan--f jan--f Awaiting requested review from jan--f

@raptorsun raptorsun Awaiting requested review from raptorsun

Assignees

@jan--f jan--f

@danielmellado danielmellado

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
5 participants
@machine424 @openshift-ci-robot @danielmellado @jan--f @openshift-merge-robot