Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSSM-3982: using main branch instead of maistra-2.4 in maistra test tool #39455

Merged
merged 3 commits into from
May 22, 2023
Merged

OSSM-3982: using main branch instead of maistra-2.4 in maistra test tool #39455

merged 3 commits into from
May 22, 2023

Conversation

FilipB
Copy link
Contributor

@FilipB FilipB commented May 18, 2023

No description provided.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 18, 2023 •
edited by openshift-ci bot

@FilipB: This pull request references OSSM-3982 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 18, 2023
@openshift-ci openshift-ci bot requested review from jwendell and liswang89 May 18, 2023 05:52
@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 18, 2023
@yxun
Copy link
Contributor

yxun commented May 18, 2023

/lgtm

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
@yxun
Copy link
Contributor

yxun commented May 18, 2023

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
yxun
yxun reviewed May 18, 2023
View reviewed changes
core-services/prow/02_config/_plugins.yaml Outdated
@@ -1951,7 +1951,7 @@ config_updater:
- ci
gzip: true
name: job-config-misc
ci-operator/jobs/maistra/**/*maistra-*.*.yaml:
ci-operator/jobs/maistra/**/*maistra*-[1-9].[0-9]*.yaml:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ci-operator/jobs/maistra/**/*maistra*-[1-9].[0-9]*.yaml:
ci-operator/jobs/maistra/**/*maistra-*[1-9].[0-9]*.yaml:

@FilipB
Copy link
Contributor Author

FilipB commented May 19, 2023

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@FilipB: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-maistra-maistra-test-tool-main-build maistra/maistra-test-tool presubmit Presubmit changed
pull-ci-maistra-maistra-test-tool-main-lint maistra/maistra-test-tool presubmit Presubmit changed
pull-ci-maistra-maistra-test-tool-main-servicemesh-ocp4.13-lp-interop-images maistra/maistra-test-tool presubmit Presubmit changed
periodic-ci-maistra-maistra-test-tool-main-servicemesh-ocp4.13-lp-interop-servicemesh-interop-aws N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@FilipB
Copy link
Contributor Author

FilipB commented May 19, 2023

/pj-rehearse

@FilipB FilipB requested a review from yxun May 19, 2023 13:25
Simranpal
Simranpal approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@Simranpal Simranpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2023
@FilipB
Copy link
Contributor Author

FilipB commented May 19, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 19, 2023
@bbguimaraes
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, FilipB, Simranpal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2023

@FilipB: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2460f7b into openshift:master May 22, 2023
24 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 22, 2023

@FilipB: Updated the following 5 configmaps:

  • ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:
    • key maistra-maistra-test-tool-maistra-2.4__servicemesh-ocp4.13-lp-interop.yaml using file ``
    • key maistra-maistra-test-tool-main__servicemesh-ocp4.13-lp-interop.yaml using file ci-operator/config/maistra/maistra-test-tool/maistra-maistra-test-tool-main__servicemesh-ocp4.13-lp-interop.yaml
  • job-config-master-periodics configmap in namespace ci at cluster app.ci using the following files:
    • key maistra-maistra-test-tool-maistra-2.4-periodics.yaml using file ``
    • key maistra-maistra-test-tool-main-periodics.yaml using file ci-operator/jobs/maistra/maistra-test-tool/maistra-maistra-test-tool-main-periodics.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key maistra-maistra-test-tool-maistra-2.4-presubmits.yaml using file ``
    • key maistra-maistra-test-tool-main-presubmits.yaml using file ci-operator/jobs/maistra/maistra-test-tool/maistra-maistra-test-tool-main-presubmits.yaml
  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key maistra-maistra-test-tool-maistra-2.4.yaml using file ``
    • key maistra-maistra-test-tool-main.yaml using file ci-operator/config/maistra/maistra-test-tool/maistra-maistra-test-tool-main.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simranpal Simranpal Simranpal approved these changes

@jwendell jwendell Awaiting requested review from jwendell

@liswang89 liswang89 Awaiting requested review from liswang89

@yxun yxun Awaiting requested review from yxun

Assignees

@yxun yxun

@Simranpal Simranpal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
6 participants
@FilipB @openshift-ci-robot @yxun @bbguimaraes @Simranpal @openshift-merge-robot