Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loki]: updates v2.8.0 to rhel-9 #39467

Conversation

JoaoBraveCoding
Copy link
Contributor

@JoaoBraveCoding JoaoBraveCoding commented May 18, 2023

@openshift-ci openshift-ci bot requested review from btaani and shwetaap May 18, 2023 09:43
@xperimental
Copy link
Contributor

xperimental commented May 22, 2023

Did you mean to modify the 2.8.0 build? The linked openshift/loki PR references the main branch and not 2.8.0...

@periklis
Copy link
Contributor

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@periklis, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build05: failed waiting for imagestreamtag openshift/release:golang-1.20 to appear: timed out waiting for the condition

If the problem persists, please contact Test Platform.

@JoaoBraveCoding
Copy link
Contributor Author

/pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@JoaoBraveCoding, pj-rehearse: failed to create rehearsal jobs ERROR:

failed to ensure imagestreamtags in cluster build05: failed waiting for imagestreamtag openshift/release:golang-1.20 to appear: timed out waiting for the condition

If the problem persists, please contact Test Platform.

Signed-off-by: Joao Marcal <jmarcal@redhat.com>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@JoaoBraveCoding: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-loki-upstream-v2.8.0-images openshift/loki presubmit Ci-operator config changed
pull-ci-openshift-loki-upstream-v2.8.0-test openshift/loki presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@JoaoBraveCoding
Copy link
Contributor Author

/pj-rehearse

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2023

@JoaoBraveCoding: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@periklis
Copy link
Contributor

/approve

@periklis
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 23, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@periklis
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoaoBraveCoding, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c0f0e13 into openshift:master May 24, 2023
18 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2023

@JoaoBraveCoding: Updated the ci-operator-misc-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-loki-upstream-v2.8.0.yaml using file ci-operator/config/openshift/loki/openshift-loki-upstream-v2.8.0.yaml

In response to this:

Relates to openshift/loki#138 and https://issues.redhat.com/browse/LOG-4054

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
5 participants